Pack is aliased framework aware and supports deduplication to allowed aliased projects to be packed. (#7227)

Author: nkolev92

.github/copilot-instructions.md

@@ -9,6 +9,7 @@
 
 - Use the following coding guidelines: https://github.com/NuGet/NuGet.Client/blob/dev/docs/coding-guidelines.md
 - Never use reflection.
+- When using value tuples, never use `var` (e.g., `var result = Method()`), but always use decomposed names (e.g., `(var name, var value) = Method()`).
 
 ## Project-Specific Rules
 

src/NuGet.Core/NuGet.Build.Tasks.Pack/GlobalSuppressions.cs

@@ -87,10 +87,6 @@
 [assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.BuildLicenseMetadata(NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem})~NuGet.Packaging.LicenseMetadata")]
 [assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.GetAssetsFile(NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem})~NuGet.ProjectModel.LockFile")]
 [assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.InitCurrentDirectoryAndFileName(NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem},NuGet.Commands.PackArgs)")]
-[assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.InitLibFiles(NuGet.Commands.IMSBuildItem[],System.Collections.Generic.IDictionary{System.String,System.String})~System.Collections.Generic.IEnumerable{NuGet.Commands.OutputLibFile}")]
 [assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.InitNuspecOutputPath(NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem},NuGet.Commands.PackArgs)")]
 [assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.InitOutputExtensions(System.Collections.Generic.IEnumerable{System.String})~System.Collections.Generic.HashSet{System.String}")]
-[assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.ParseFrameworks(NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem},System.Collections.Generic.IDictionary{System.String,System.String})~System.Collections.Generic.ISet{NuGet.Frameworks.NuGetFramework}")]
 [assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.ParsePackageTypes(NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem})~System.Collections.Generic.ICollection{NuGet.Packaging.Core.PackageType}")]
-[assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.PopulateFrameworkAssemblyReferences(NuGet.Packaging.PackageBuilder,NuGet.Build.Tasks.Pack.IPackTaskRequest{NuGet.Commands.IMSBuildItem})")]
-[assembly: SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>", Scope = "member", Target = "~M:NuGet.Build.Tasks.Pack.PackTaskLogic.PopulateFrameworkReferences(NuGet.Packaging.PackageBuilder,NuGet.ProjectModel.LockFile)")]

src/NuGet.Core/NuGet.Build.Tasks.Pack/PackTaskLogic.cs

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 
@@ -117,6 +117,16 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="AmbigiousFrameworkReferences" xml:space="preserve">
+    <value>Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</value>
+    <comment>0 - List of TargetFramework with framework refs</comment>
+  </data>
+  <data name="AmbigiousPackageAssemblies" xml:space="preserve">
+    <value>Ambiguous packaging content. The above frameworks have the same target path for {0}.</value>
+  </data>
+  <data name="AmbigiousPackageDependencies" xml:space="preserve">
+    <value>Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</value>
+  </data>
   <data name="AssetsFileDoesNotHaveValidPackageSpec" xml:space="preserve">
     <value>The assets file found does not contain a valid package spec. Try restoring the project again. The location of the assets file is {0}.</value>
     <comment>{0} is the path to the assets file.</comment>
@@ -125,6 +135,11 @@
     <value>The assets file produced by restore does not exist. Try restoring the project again. The expected location of the assets file is {0}.</value>
     <comment>{0} is the path to the assets file.</comment>
   </data>
+  <data name="DuplicateFrameworks" xml:space="preserve">
+    <value>This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</value>
+    <comment>0 - details about which framework 
+1 - Additional details</comment>
+  </data>
   <data name="Error_FileNotFound" xml:space="preserve">
     <value>The file '{0}' to be packed was not found on disk.</value>
     <comment>{0} is the file being packed.</comment>
@@ -172,4 +187,4 @@
     <value>The PackageLicenseUrl is being deprecated and cannot be used in conjunction with the PackageLicenseFile or PackageLicenseExpression.</value>
     <comment>Please don't localize PackageLicenseUrl, PackageLicenseFile and PackageLicenseExpression.</comment>
   </data>
-</root>
+</root>

src/NuGet.Core/NuGet.Build.Tasks.Pack/Strings.Designer.cs

@@ -2,6 +2,21 @@
 <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
   <file datatype="xml" source-language="en" target-language="cs" original="../Strings.resx">
     <body>
+      <trans-unit id="AmbigiousFrameworkReferences">
+        <source>Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</source>
+        <target state="new">Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</target>
+        <note>0 - List of TargetFramework with framework refs</note>
+      </trans-unit>
+      <trans-unit id="AmbigiousPackageAssemblies">
+        <source>Ambiguous packaging content. The above frameworks have the same target path for {0}.</source>
+        <target state="new">Ambiguous packaging content. The above frameworks have the same target path for {0}.</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="AmbigiousPackageDependencies">
+        <source>Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</source>
+        <target state="new">Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</target>
+        <note />
+      </trans-unit>
       <trans-unit id="AssetsFileDoesNotHaveValidPackageSpec">
         <source>The assets file found does not contain a valid package spec. Try restoring the project again. The location of the assets file is {0}.</source>
         <target state="translated">Soubor prostředků, který se našel, neobsahuje platnou specifikaci balíčku. Zkuste projekt obnovit znovu. Umístění souboru prostředků je {0}.</target>
@@ -12,6 +27,12 @@
         <target state="translated">Soubor prostředků, který se měl vytvořit při obnovování, neexistuje. Zkuste projekt obnovit znovu. Očekávané umístění souboru prostředků je {0}.</target>
         <note>{0} is the path to the assets file.</note>
       </trans-unit>
+      <trans-unit id="DuplicateFrameworks">
+        <source>This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</source>
+        <target state="new">This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</target>
+        <note>0 - details about which framework 
+1 - Additional details</note>
+      </trans-unit>
       <trans-unit id="Error_FileNotFound">
         <source>The file '{0}' to be packed was not found on disk.</source>
         <target state="translated">Soubor {0}, který se má zabalit, se na disku nenašel.</target>

src/NuGet.Core/NuGet.Build.Tasks.Pack/Strings.resx

@@ -2,6 +2,21 @@
 <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
   <file datatype="xml" source-language="en" target-language="de" original="../Strings.resx">
     <body>
+      <trans-unit id="AmbigiousFrameworkReferences">
+        <source>Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</source>
+        <target state="new">Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</target>
+        <note>0 - List of TargetFramework with framework refs</note>
+      </trans-unit>
+      <trans-unit id="AmbigiousPackageAssemblies">
+        <source>Ambiguous packaging content. The above frameworks have the same target path for {0}.</source>
+        <target state="new">Ambiguous packaging content. The above frameworks have the same target path for {0}.</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="AmbigiousPackageDependencies">
+        <source>Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</source>
+        <target state="new">Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</target>
+        <note />
+      </trans-unit>
       <trans-unit id="AssetsFileDoesNotHaveValidPackageSpec">
         <source>The assets file found does not contain a valid package spec. Try restoring the project again. The location of the assets file is {0}.</source>
         <target state="translated">Die gefundene Assetdatei enthält keine gültige Paketspezifikation (spec). Versuchen Sie erneut, das Paket wiederherzustellen. Der Speicherort der Assetdatei ist "{0}".</target>
@@ -12,6 +27,12 @@
         <target state="translated">Die durch die Wiederherstellung generierte Assetdatei ist nicht vorhanden. Versuchen Sie erneut, das Projekt wiederherzustellen. Der erwartete Speicherort für die Assetdatei ist "{0}".</target>
         <note>{0} is the path to the assets file.</note>
       </trans-unit>
+      <trans-unit id="DuplicateFrameworks">
+        <source>This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</source>
+        <target state="new">This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</target>
+        <note>0 - details about which framework 
+1 - Additional details</note>
+      </trans-unit>
       <trans-unit id="Error_FileNotFound">
         <source>The file '{0}' to be packed was not found on disk.</source>
         <target state="translated">Die im Paket einzubeziehende Datei "{0}" wurde auf dem Datenträger nicht gefunden.</target>

src/NuGet.Core/NuGet.Build.Tasks.Pack/xlf/Strings.cs.xlf

@@ -2,6 +2,21 @@
 <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.2" xsi:schemaLocation="urn:oasis:names:tc:xliff:document:1.2 xliff-core-1.2-transitional.xsd">
   <file datatype="xml" source-language="en" target-language="es" original="../Strings.resx">
     <body>
+      <trans-unit id="AmbigiousFrameworkReferences">
+        <source>Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</source>
+        <target state="new">Ambiguous framework references. The following target frameworks are both declaring framework references for packing: {0}</target>
+        <note>0 - List of TargetFramework with framework refs</note>
+      </trans-unit>
+      <trans-unit id="AmbigiousPackageAssemblies">
+        <source>Ambiguous packaging content. The above frameworks have the same target path for {0}.</source>
+        <target state="new">Ambiguous packaging content. The above frameworks have the same target path for {0}.</target>
+        <note />
+      </trans-unit>
+      <trans-unit id="AmbigiousPackageDependencies">
+        <source>Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</source>
+        <target state="new">Ambiguous package dependencies. The following target frameworks are both declaring package dependencies for packing: {0}</target>
+        <note />
+      </trans-unit>
       <trans-unit id="AssetsFileDoesNotHaveValidPackageSpec">
         <source>The assets file found does not contain a valid package spec. Try restoring the project again. The location of the assets file is {0}.</source>
         <target state="translated">El archivo de recursos encontrado no contiene una spec de paquete válida. Intente volver a restaurar el proyecto. La ubicación del archivo de recursos es {0}.</target>
@@ -12,6 +27,12 @@
         <target state="translated">El archivo de recursos que ha generado la restauración no existe. Intente volver a restaurar el proyecto. La ubicación esperada del archivo de recursos es {0}.</target>
         <note>{0} is the path to the assets file.</note>
       </trans-unit>
+      <trans-unit id="DuplicateFrameworks">
+        <source>This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</source>
+        <target state="new">This project is using aliased frameworks, the following TargetFramework properties map to the same effective frameworks '{0}' and pack is unable to disambiguate and create a single package. {1}</target>
+        <note>0 - details about which framework 
+1 - Additional details</note>
+      </trans-unit>
       <trans-unit id="Error_FileNotFound">
         <source>The file '{0}' to be packed was not found on disk.</source>
         <target state="translated">El archivo "{0}" que se va a empaquetar no se encuentra en el disco.</target>