Reduce allocation in GetNuGetProjects by providing capacity for List (#7050)

nareshjo · Naresh Joshi · web-flow · commit 1e800480da7b · 2026-01-22T11:53:35.000-08:00
Co-authored-by: Naresh Joshi &lt;Naresh.Joshi@microsoft.com&gt;
diff --git a/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Projects/ProjectSystemCache.cs b/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Projects/ProjectSystemCache.cs
@@ -182,9 +182,13 @@ public IReadOnlyList<NuGetProject> GetNuGetProjects()
 
             try
             {
-                return _primaryCache
-                    .Select(kv => kv.Value.NuGetProject)
-                    .ToList();
+                List<NuGetProject> result = new List<NuGetProject>(_primaryCache.Count);
+                foreach (var kv in _primaryCache)
+                {
+                    result.Add(kv.Value.NuGetProject);
+                }
+
+                return result;
             }
             finally
             {

Original file line number	Diff line number	Diff line change
`@@ -182,9 +182,13 @@ public IReadOnlyList<NuGetProject> GetNuGetProjects()`
`182`	`182`
`183`	`183`	`try`
`184`	`184`	`{`
`185`		`- return _primaryCache`
`186`		`- .Select(kv => kv.Value.NuGetProject)`
`187`		`- .ToList();`
	`185`	`+ List<NuGetProject> result = new List<NuGetProject>(_primaryCache.Count);`
	`186`	`+ foreach (var kv in _primaryCache)`
	`187`	`+ {`
	`188`	`+ result.Add(kv.Value.NuGetProject);`
	`189`	`+ }`
	`190`	`+`
	`191`	`+ return result;`
`188`	`192`	`}`
`189`	`193`	`finally`
`190`	`194`	`{`