Set HashSet capacity in dependency resolver (#6884)

jeffkl · web-flow · commit 1a7536a16426 · 2025-10-27T10:10:40.000-07:00
diff --git a/src/NuGet.Core/NuGet.Commands/RestoreCommand/DependencyGraphResolver.cs b/src/NuGet.Core/NuGet.Commands/RestoreCommand/DependencyGraphResolver.cs
@@ -1255,11 +1255,7 @@ .. chosenResolvedItem.Suppressions
                 if (isRootProject)
                 {
 
-#if NETSTANDARD
-                    directPackageReferences = new HashSet<LibraryDependencyIndex>();
-#else
                     directPackageReferences = new HashSet<LibraryDependencyIndex>(capacity: chosenResolvedItem.Item.Data.Dependencies.Count);
-#endif
 
                     for (int i = 0; i < chosenResolvedItem.Item.Data.Dependencies.Count; i++)
                     {
@@ -1293,7 +1289,7 @@ .. chosenResolvedItem.Suppressions
                         // Suppress this dependency if PrivateAssets is set to "All"
                         if (dependency.SuppressParent == LibraryIncludeFlags.All)
                         {
-                            suppressions ??= new HashSet<LibraryDependencyIndex>();
+                            suppressions ??= new HashSet<LibraryDependencyIndex>(capacity: chosenResolvedItem.Item.Data.Dependencies.Count - i);
 
                             suppressions.Add(chosenResolvedItemChildLibraryDependencyIndex);
                         }

Original file line number	Diff line number	Diff line change
`@@ -1255,11 +1255,7 @@ .. chosenResolvedItem.Suppressions`
`1255`	`1255`	`if (isRootProject)`
`1256`	`1256`	`{`
`1257`	`1257`
`1258`		`-#if NETSTANDARD`
`1259`		`- directPackageReferences = new HashSet<LibraryDependencyIndex>();`
`1260`		`-#else`
`1261`	`1258`	`directPackageReferences = new HashSet<LibraryDependencyIndex>(capacity: chosenResolvedItem.Item.Data.Dependencies.Count);`
`1262`		`-#endif`
`1263`	`1259`
`1264`	`1260`	`for (int i = 0; i < chosenResolvedItem.Item.Data.Dependencies.Count; i++)`
`1265`	`1261`	`{`
`@@ -1293,7 +1289,7 @@ .. chosenResolvedItem.Suppressions`
`1293`	`1289`	`// Suppress this dependency if PrivateAssets is set to "All"`
`1294`	`1290`	`if (dependency.SuppressParent == LibraryIncludeFlags.All)`
`1295`	`1291`	`{`
`1296`		`- suppressions ??= new HashSet<LibraryDependencyIndex>();`
	`1292`	`+ suppressions ??= new HashSet<LibraryDependencyIndex>(capacity: chosenResolvedItem.Item.Data.Dependencies.Count - i);`
`1297`	`1293`
`1298`	`1294`	`suppressions.Add(chosenResolvedItemChildLibraryDependencyIndex);`
`1299`	`1295`	`}`