Force initialize EnvDTE.Project because EnvDTE.Project initialization does not specify its thread affinity (#7292)

Author: nkolev92

src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Projects/CpsPackageReferenceProjectProvider.cs

@@ -84,6 +84,11 @@ public NuGetProject TryCreateNuGetProject(
 
             var projectServices = new CpsProjectSystemServices(vsProject, _scriptExecutor);
 
+            // Ensure the EnvDTE.Project is initialized.
+            // Under the hood VSProjectAdapter actually has a Lazy<EnvDte.project>, which needs the UI thread to satisfy the cast.
+            // If PMC is actually the first one that wants the EnvDTE.Project, it would fail because it's being called from the pipeline thread.
+            // This is a workaround to make sure the EnvDTE.Project is initialized before any PMC code tries to use it.
+            _ = vsProject.Project;
             var lazyUnconfiguredProject = new AsyncLazy<UnconfiguredProject>(async () =>
             {
                 await NuGetUIThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();

test/NuGet.Tests.Apex/NuGet.Tests.Apex/NuGetEndToEndTests/NuGetConsoleTestCase.cs

@@ -865,6 +865,22 @@ public async Task InstallPackageFromPMCWithWhatIf_DoesNotInstallPackageAsync()
             CommonUtility.AssertPackageNotInPackagesConfig(VisualStudio, testContext.Project, packageName, Logger);
         }
 
+        [TestMethod]
+        [Timeout(DefaultTimeout)]
+        public void GetProject_CanAccessProjectName()
+        {
+            using var testContext = new ApexTestContext(VisualStudio, ProjectTemplate.NetCoreConsoleApp, Logger);
+
+            var nugetConsole = GetConsole(testContext.Project);
+            nugetConsole.Clear();
+
+            nugetConsole.Execute("$proj = Get-Project; $proj.Name");
+
+            string pmcText = nugetConsole.GetText();
+            pmcText.Should().Contain(testContext.Project.Name, because: pmcText);
+            pmcText.Should().NotContain("FullyQualifiedErrorId", because: pmcText);
+        }
+
         public static IEnumerable<object[]> GetNetCoreTemplates()
         {
             yield return new object[] { ProjectTemplate.NetCoreConsoleApp };