common

Nigusu-Allehu · Nigusu-Allehu · commit 0ed7e52252c6 · 2026-04-21T15:51:53.000-07:00
diff --git a/build/Shared/AotCompatibilityAttributes.cs b/build/Shared/AotCompatibilityAttributes.cs
diff --git a/build/Shared/NuGetFeatureFlags.cs b/build/Shared/NuGetFeatureFlags.cs
@@ -6,7 +6,7 @@
 
 namespace NuGet.Common
 {
-    public static class NuGetFeatureFlags
+    internal static class NuGetFeatureFlags
     {
         internal const string UsesNSJDeserializationSwitchName = "NuGet.UsesNSJDeserialization";
         internal const string UsesNSJDeserializationEnvVar = "NUGET_USES_NSJ_DESERIALIZATION";
@@ -16,11 +16,11 @@ public static class NuGetFeatureFlags
 
         /// <summary>Feature switch for NSJ deserialization. Defaults to <see langword="true"/>.</summary>
         [FeatureSwitchDefinition(UsesNSJDeserializationSwitchName)]
-        public static bool NSJDeserializationFeatureSwitch { get; } =
+        internal static bool NSJDeserializationFeatureSwitch { get; } =
             !AppContext.TryGetSwitch(UsesNSJDeserializationSwitchName, out bool value) || value;
 
         /// <summary>Returns <see langword="false"/> when env var <c>NUGET_USES_NSJ_DESERIALIZATION</c> is <c>false</c>.</summary>
-        public static bool IsNSJDeserializationEnabledByEnvironment(IEnvironmentVariableReader? env = null)
+        internal static bool IsNSJDeserializationEnabledByEnvironment(IEnvironmentVariableReader? env = null)
         {
             if (env is null)
             {
diff --git a/src/NuGet.Core/NuGet.Common/NuGet.Common.csproj b/src/NuGet.Core/NuGet.Common/NuGet.Common.csproj
@@ -38,8 +38,10 @@
   </ItemGroup>
 
   <ItemGroup Label="NuGet Shared">
+    <Compile Include="$(SharedDirectory)\AotCompatibilityAttributes.cs" />
     <Compile Include="$(SharedDirectory)\EncodingUtility.cs" />
     <Compile Include="$(SharedDirectory)\NullableAttributes.cs" />
+    <Compile Include="$(SharedDirectory)\NuGetFeatureFlags.cs" />
     <Compile Include="$(SharedDirectory)\SimplePool.cs" />
     <Compile Include="$(SharedDirectory)\StringBuilderPool.cs" />
     <Compile Include="$(SharedDirectory)\TaskResult.cs" />
diff --git a/src/NuGet.Core/NuGet.Common/PublicAPI.Unshipped.txt b/src/NuGet.Core/NuGet.Common/PublicAPI.Unshipped.txt
@@ -1,4 +1 @@
 #nullable enable
-NuGet.Common.NuGetFeatureFlags
-static NuGet.Common.NuGetFeatureFlags.IsNSJDeserializationEnabledByEnvironment(NuGet.Common.IEnvironmentVariableReader? env = null) -> bool
-static NuGet.Common.NuGetFeatureFlags.NSJDeserializationFeatureSwitch.get -> bool
diff --git a/src/NuGet.Core/NuGet.Protocol/NuGet.Protocol.csproj b/src/NuGet.Core/NuGet.Protocol/NuGet.Protocol.csproj
@@ -39,6 +39,8 @@
     <Compile Include="$(SharedDirectory)\HashCodeCombiner.cs" />
     <Compile Include="$(SharedDirectory)\NoAllocEnumerateExtensions.cs" />
     <Compile Include="$(SharedDirectory)\NullableAttributes.cs" />
+    <Compile Include="$(SharedDirectory)\NuGetFeatureFlags.cs" />
+    <Compile Include="$(SharedDirectory)\AotCompatibilityAttributes.cs" />
     <Compile Include="$(SharedDirectory)\SimplePool.cs" />
     <Compile Include="$(SharedDirectory)\StringBuilderPool.cs" />
     <Compile Include="$(SharedDirectory)\TaskResult.cs" />

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace NuGet.Common`
`8`	`8`	`{`
`9`		`- public static class NuGetFeatureFlags`
	`9`	`+ internal static class NuGetFeatureFlags`
`10`	`10`	`{`
`11`	`11`	`internal const string UsesNSJDeserializationSwitchName = "NuGet.UsesNSJDeserialization";`
`12`	`12`	`internal const string UsesNSJDeserializationEnvVar = "NUGET_USES_NSJ_DESERIALIZATION";`
`@@ -16,11 +16,11 @@ public static class NuGetFeatureFlags`
`16`	`16`
`17`	`17`	`/// <summary>Feature switch for NSJ deserialization. Defaults to <see langword="true"/>.</summary>`
`18`	`18`	`[FeatureSwitchDefinition(UsesNSJDeserializationSwitchName)]`
`19`		`- public static bool NSJDeserializationFeatureSwitch { get; } =`
	`19`	`+ internal static bool NSJDeserializationFeatureSwitch { get; } =`
`20`	`20`	`!AppContext.TryGetSwitch(UsesNSJDeserializationSwitchName, out bool value) \|\| value;`
`21`	`21`
`22`	`22`	`/// <summary>Returns <see langword="false"/> when env var <c>NUGET_USES_NSJ_DESERIALIZATION</c> is <c>false</c>.</summary>`
`23`		`- public static bool IsNSJDeserializationEnabledByEnvironment(IEnvironmentVariableReader? env = null)`
	`23`	`+ internal static bool IsNSJDeserializationEnabledByEnvironment(IEnvironmentVariableReader? env = null)`
`24`	`24`	`{`
`25`	`25`	`if (env is null)`
`26`	`26`	`{`