Use TargetAlias in AssetsFileDependencies snapshot (#6843)

Author: nkolev92

src/NuGet.Clients/NuGet.VisualStudio.Implementation/SolutionExplorer/Models/AssetsFileDependenciesSnapshot.cs

@@ -96,11 +96,11 @@ private AssetsFileDependenciesSnapshot(LockFile? lockFile, AssetsFileDependencie
                     continue;
                 }
 
-                string targetAlias = GetTargetAlias(lockFileTarget.Name);
+                string targetAlias = lockFileTarget.TargetAlias;
 
                 previous.DataByTarget.TryGetValue(targetAlias, out AssetsFileTarget? previousTarget);
 
-                ImmutableArray<AssetsFileLogMessage> logMessages = ParseLogMessages(lockFile, previousTarget, lockFileTarget.Name);
+                ImmutableArray<AssetsFileLogMessage> logMessages = ParseLogMessages(lockFile, previousTarget, targetAlias);
 
                 dataByTarget.Add(
                     targetAlias,
@@ -114,34 +114,6 @@ private AssetsFileDependenciesSnapshot(LockFile? lockFile, AssetsFileDependencie
             DataByTarget = dataByTarget.ToImmutable();
             return;
 
-            string GetTargetAlias(string lockFileTargetName)
-            {
-                // In some places, the target alias specified in the project file (e.g. "net472") will not
-                // match the target name used throughout the lock file (e.g. ".NETFramework,Version=v4.7.2").
-                // The dependencies tree only uses the target alias (what's in the project file) so we need
-                // to map back to that. See https://github.com/dotnet/project-system/issues/6832.
-
-                if (lockFile.PackageSpec.TargetFrameworks.Any(t => t.TargetAlias == lockFileTargetName))
-                {
-                    // The target name used in the assets file matches the target alias in the project file.
-                    return lockFileTargetName;
-                }
-
-                // The target name used in the assets file does NOT match any target alias in the project.
-                // Attempt to find the name used in the project.
-                foreach (TargetFrameworkInformation targetInfo in lockFile.PackageSpec.TargetFrameworks)
-                {
-                    if (targetInfo.FrameworkName.DotNetFrameworkName == lockFileTargetName)
-                    {
-                        // We found a match, so return the alias.
-                        return targetInfo.TargetAlias;
-                    }
-                }
-
-                // No match was found. Not ideal. Nothing to do but return the original value.
-                return lockFileTargetName;
-            }
-
             static ImmutableArray<AssetsFileLogMessage> ParseLogMessages(LockFile lockFile, AssetsFileTarget? previousTarget, string target)
             {
                 if (lockFile.LogMessages.Count == 0)