Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit c37a080

Browse files
kzuadalon
authored andcommitted
Keep $(Out) property default where it can be shared among targets
This property was improperly moved to build.proj, therefore causing the projects to stop having a default value for it, and causing F5 scenarios to break for the VS extension authoring, which needs to package the .nupkg from the $(Out) directory for deployment to the experimental instance. This did work fine for CI builds, since the Out property is explicitly passed down when building solutions and projects.
1 parent 777898a commit c37a080

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

build.proj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
<PropertyGroup>
1414
<NuGetUrl Condition=" '$(NuGetUrl)' == '' ">https://dist.nuget.org/win-x86-commandline/v3.4.4/NuGet.exe</NuGetUrl>
1515
<RestorePackages>false</RestorePackages>
16-
<Out Condition=" '$(Out)' == '' ">$(MSBuildThisFileDirectory)out</Out>
1716
<RunCodeAnalysis Condition=" '$(RunCodeAnalysis)' == ''">false</RunCodeAnalysis>
1817
<IntermediateOutputPath>.nuget\</IntermediateOutputPath>
1918
<PackagesPath>$(IntermediateOutputPath)packages</PackagesPath>

build.props

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,9 @@
1616
<Message Importance="high" Text="$(VsInstallRoot)" />
1717
</Target>
1818

19+
<PropertyGroup>
20+
<!-- Keep this property here, since this .props file is also imported from the Shared.props file -->
21+
<Out Condition=" '$(Out)' == '' ">$(MSBuildThisFileDirectory)out</Out>
22+
</PropertyGroup>
23+
1924
</Project>

0 commit comments

Comments
 (0)