Build should fail when tests fail

Author: kzu

appveyor.yml

@@ -11,7 +11,11 @@ init:
     }
 
 build_script:
+# Ensure we have no dangling MSBuild processes that might lock the output assemblies
+- cmd: taskkill /f /im MSBuild.exe /fi "memusage gt 40" 2>NUL
 - cmd: build.cmd %BuildArgs%
+# Ensure we leave no dangling MSBuild processes
+- cmd: taskkill /f /im MSBuild.exe /fi "memusage gt 40" 2>NUL
 
 install:
 - cmd: git submodule update --init --recursive

build.cmd

@@ -13,12 +13,11 @@ IF "%msb%"=="" (
 )
 
 SETLOCAL ENABLEEXTENSIONS ENABLEDELAYEDEXPANSION
-PUSHD "%~dp0" >NUL
 
 IF EXIST .nuget\nuget.exe goto restore
 IF NOT EXIST .nuget md .nuget
 echo Downloading latest version of NuGet.exe...
-@powershell -NoProfile -ExecutionPolicy unrestricted -Command "$ProgressPreference = 'SilentlyContinue'; Invoke-WebRequest 'https://dist.nuget.org/win-x86-commandline/latest/nuget.exe' -OutFile .nuget/nuget.exe"
+@powershell -NoProfile -ExecutionPolicy RemoteSigned -Command "$ProgressPreference = 'SilentlyContinue'; Invoke-WebRequest 'https://dist.nuget.org/win-x86-commandline/latest/nuget.exe' -OutFile .nuget/nuget.exe"
 
 :restore
 :: Build script packages have no version in the path, so we install them to .nuget\packages to avoid conflicts with 
@@ -31,15 +30,4 @@ IF "%Verbosity%"=="" (
     set Verbosity=minimal
 )
 
-:: Ensure we have no dangling MSBuild processes that might lock the output assemblies
-taskkill /f /im MSBuild.exe /fi "memusage gt 40" 2>NUL
-
-ECHO ON
-"%msb%" build.proj /v:%Verbosity% /nr:true /m %1 %2 %3 %4 %5 %6 %7 %8 %9
-@ECHO OFF
-
-:: Ensure we leave no dangling MSBuild processes
-taskkill /f /im MSBuild.exe /fi "memusage gt 40" 2>NUL
-
-POPD >NUL
-ENDLOCAL
+"%msb%" build.proj /v:%Verbosity% %1 %2 %3 %4 %5 %6 %7 %8 %9

build.proj

@@ -69,8 +69,7 @@
 		<xunit Assemblies="@(TestAssembly)"
 			   Html="$(Out)\test.html"
 			   Xml="$(Out)\test.xml"
-			   ParallelizeAssemblies="true"
-			   ParallelizeTestCollections="true" />
+			   Reporter="appveyor" />
 	</Target>
 
 	<Target Name="Coverage" DependsOnTargets="Build">
@@ -126,6 +125,10 @@
 	<Import Project="src\PackageVersion.targets" />
 
 	<Target Name="Configure" DependsOnTargets="DownloadNuGet;GetPackageVersion">
+		<Message Importance="high" Text="************************************************************************************************************************" />
+		<Message Importance="high" Text="$([System.Environment]::CommandLine)" />
+		<Message Importance="high" Text="************************************************************************************************************************" />
+
 		<Exec Command='"$(NuGet)" Install "$(MSBuildThisFileDirectory)packages.config" -OutputDirectory "$(PackagesPath)" -ExcludeVersion -Verbosity quiet'
 			  StandardOutputImportance="low"
 			  Condition=" '$(PendingRestore)' == 'true' " />