Avoiding to show a warning when a project reference to a legacy .csproj is added

And also enabling NuProj -> NuProj project references

Author: adalon

src/VisualStudio/NuGet.Packaging.VisualStudio.15/ProjectSystem/NuProjValidProjectReferenceChecker.cs

@@ -1,93 +1,39 @@
-//using System;
-//using System.ComponentModel.Composition;
-//using System.Diagnostics.CodeAnalysis;
-//using System.Threading.Tasks;
-
-//using System.Collections.Immutable;
-//using Microsoft.VisualStudio.ProjectSystem;
-//using Microsoft.VisualStudio.ProjectSystem.References;
-//using Microsoft.VisualStudio.Shell.Interop;
-
-//namespace NuGet.Packaging.VisualStudio
-//{
-//    [Export(typeof(IValidProjectReferenceChecker))]
-//    [Order(1000)]
-//    [AppliesTo(NuProjCapabilities.NuProj)]
-//    public class NuProjValidProjectReferenceChecker : IValidProjectReferenceChecker
-//    {
-//        // This import must be present so that this part applies to a specific project.
-//        [Import]
-//        [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly")]
-//        public UnconfiguredProject UnconfiguredProject { get; set; }
-
-//        public Task<SupportedCheckResult> CanAddProjectReferenceAsync(object referencedProject)
-//        {
-//            var result = CanAddProjectReference(referencedProject);
-//            return Task.FromResult(result);
-//        }
-
-//        public Task<CanAddProjectReferencesResult> CanAddProjectReferencesAsync(IImmutableSet<object> referencedProjects)
-//        {
-//            if (referencedProjects == null)
-//                throw new ArgumentNullException("referencedProjects");
-
-//            var results = ImmutableDictionary<object, SupportedCheckResult>.Empty;
-
-//            foreach (object referencedProject in referencedProjects)
-//            {
-//                var result = CanAddProjectReference(referencedProject);
-//                results = results.Add(referencedProject, result);
-//            }
-
-//            return Task.FromResult(new CanAddProjectReferencesResult(results, null));
-//        }
-
-//        public Task<SupportedCheckResult> CanBeReferencedAsync(object referencingProject)
-//        {
-//            return Task.FromResult(SupportedCheckResult.NotSupported);
-//        }
-
-//        private static SupportedCheckResult CanAddProjectReference(object referencedProject)
-//        {
-//            return CanReference(referencedProject)
-//                   ? SupportedCheckResult.Supported
-//                   : SupportedCheckResult.Unknown;
-//        }
-
-//        private static bool CanReference(object referencedProject)
-//        {
-//            var r = referencedProject as IVsProjectReference;
-//            return r != null &&
-//                   CanReference(r.FullPath);
-//        }
-
-//        private static bool CanReference(string path)
-//        {
-//            return IsNuProj(path) ||
-//                   HasGetNuGetOutputAndTargetFrameworkInformationTarget(path);
-//        }
-
-//        private static bool IsNuProj(string path)
-//        {
-//            return HasExtension(path, "." + Constants.ProjectExtension);
-//        }
-
-//        private static bool HasGetNuGetOutputAndTargetFrameworkInformationTarget(string path)
-//        {
-//            // Here we are cheating like no tomorrow. Ideally, we'd actually inspect in the project file and check
-//            // whether it actually has an MSBuild target named "GetNuGetOutputAndTargetFrameworkInformation".
-//            //
-//            // For now we'll just whitelist the known project files C#, VB and F#.
-//            return HasExtension(path, ".csproj") ||
-//                   HasExtension(path, ".vbproj") ||
-//                   HasExtension(path, ".fsproj");
-//        }
-
-//        private static bool HasExtension(string path, string extension)
-//        {
-//            return path != null &&
-//                   extension != null &&
-//                   path.EndsWith(extension, StringComparison.OrdinalIgnoreCase);
-//        }
-//    }
-//}
+using System;
+using System.ComponentModel.Composition;
+using System.Diagnostics.CodeAnalysis;
+using System.Threading.Tasks;
+using System.Linq;
+using System.Collections.Immutable;
+using Microsoft.VisualStudio.ProjectSystem;
+using Microsoft.VisualStudio.ProjectSystem.References;
+using System.Collections.Generic;
+
+namespace NuGet.Packaging.VisualStudio
+{
+	[Export(typeof(IValidProjectReferenceChecker))]
+	[Order(1000)]
+	[AppliesTo(NuProjCapabilities.NuProj)]
+	public class NuProjValidProjectReferenceChecker : IValidProjectReferenceChecker
+	{
+		// This import must be present so that this part applies to a specific project.
+		[Import]
+		[SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly")]
+		public UnconfiguredProject UnconfiguredProject { get; set; }
+
+		public Task<SupportedCheckResult> CanAddProjectReferenceAsync(object referencedProject) =>
+			Task.FromResult(CanAddProjectReference(referencedProject));
+
+		public Task<CanAddProjectReferencesResult> CanAddProjectReferencesAsync(IImmutableSet<object> referencedProjects) =>
+			Task.FromResult(
+				new CanAddProjectReferencesResult(
+					ImmutableDictionary<object, SupportedCheckResult>.Empty.AddRange(
+						referencedProjects.Select(x =>
+							new KeyValuePair<object, SupportedCheckResult>(x, CanAddProjectReference(x)))
+						), null));
+
+		public Task<SupportedCheckResult> CanBeReferencedAsync(object referencingProject) =>
+			Task.FromResult(SupportedCheckResult.Supported);
+
+		SupportedCheckResult CanAddProjectReference(object referencedProject) => SupportedCheckResult.Supported;
+	}
+}