Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 67040f3

Browse files
committed
Add missing primary output in package
1 parent 0d94aa7 commit 67040f3

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

build.proj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@
125125
<Import Project="src\PackageVersion.targets" />
126126

127127
<Target Name="Configure" DependsOnTargets="DownloadNuGet;GetPackageVersion">
128-
<Message Importance="high" Text="************************************************************************************************************************" />
128+
<Message Importance="high" Text="*********************************************************************************************************************" />
129129
<Message Importance="high" Text="$([System.Environment]::CommandLine)" />
130-
<Message Importance="high" Text="************************************************************************************************************************" />
130+
<Message Importance="high" Text="*********************************************************************************************************************" />
131131

132132
<Exec Command='"$(NuGet)" Install "$(MSBuildThisFileDirectory)packages.config" -OutputDirectory "$(PackagesPath)" -ExcludeVersion -Verbosity quiet'
133133
StandardOutputImportance="low"

src/Build/NuGet.Build.Packaging.Tasks/NuGet.Build.Packaging.Tasks.targets

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525

2626
<Import Project="$(OutputPath)NuGet.Build.Packaging.targets"
2727
Condition="'$(PackOnBuild)' == 'true' and Exists('$(OutputPath)NuGet.Build.Packaging.targets')" />
28-
29-
<Target Name="AddBuiltOutput" BeforeTargets="GetPackageContents" Returns="@(PackageFile)">
28+
29+
<Target Name="AddBuiltOutput" BeforeTargets="GetPackageContents" DependsOnTargets="AllProjectOutputGroups" Returns="@(PackageFile)">
3030
<!-- Update packaging version targets -->
3131
<PropertyGroup>
3232
<XmlNs>&lt;Namespace Prefix='msb' Uri='http://schemas.microsoft.com/developer/msbuild/2003'/&gt;</XmlNs>
@@ -35,6 +35,7 @@
3535
XmlInputPath="$(OutputPath)NuGet.Build.Packaging.Version.props"
3636
Query="/msb:Project/msb:PropertyGroup/msb:PackagingTargetsVersion"
3737
Value="$(PackageVersion)"/>
38+
3839
<ItemGroup>
3940
<PackageFile Include="$(OutputPath)ApiIntersect.exe">
4041
<PackagePath>build\ApiIntersect.exe</PackagePath>
@@ -142,8 +143,6 @@ namespace $(RootNamespace)
142143
<Target Name="ILMerge"
143144
AfterTargets="CoreCompile"
144145
DependsOnTargets="CoreCompile"
145-
Inputs="@(IntermediateAssembly)"
146-
Outputs="$(TargetPath)"
147146
Returns="@(MergedAssemblies)"
148147
Condition="'$(Configuration)' == 'Release' And '$(ILMerge)' != 'false'">
149148
<GetReferenceAssemblyPaths BypassFrameworkInstallChecks="False" TargetFrameworkMoniker="$(TargetFrameworkMoniker)">

src/Build/NuGet.Build.Packaging.Tests/given_a_library_with_non_nugetized_reference.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void when_getting_contents_then_fails()
2727
{
2828
Configuration = "Release",
2929
IncludeFrameworkReferences = "false",
30-
}, projectName: "a", target: "GetPackageContents", output: output);
30+
}, projectName: "a", target: "GetPackageContents");
3131

3232
Assert.Equal(TargetResultCode.Failure, result.ResultCode);
3333
Assert.Contains(result.Logger.Errors, error => error.Code == "NG0011");

0 commit comments

Comments
 (0)