Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 1a65ddd

Browse files
committed
If debug symbols are produced at all, default to always including them
The default should not depend on the project configuration, and rather on the inclusion of outputs instead. Whether or not there are symbols to include would by default depend on whether they were generated in the first place instead, which is a more sensible default.
1 parent b41f052 commit 1a65ddd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/Build/NuGet.Build.Packaging.Tasks/NuGet.Build.Packaging.Inference.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Copyright (c) .NET Foundation. All rights reserved.
2727
<!-- Whether to include @(BuiltProjectOutputGroupOutput), @(DocumentationProjectOutputGroupOutput) and @(SatelliteDllsProjectOutputGroupOutput) items in the package -->
2828
<IncludeOutputsInPackage Condition="'$(IncludeOutputsInPackage)' == ''">true</IncludeOutputsInPackage>
2929
<!-- Whether to include @(DebugSymbolsProjectOutputGroupOutput) items in the package -->
30-
<IncludeSymbolsInPackage Condition="'$(IncludeSymbolsInPackage)' == '' and '$(IncludeOutputsInPackage)' == 'true' and '$(Configuration)' == 'Debug'">true</IncludeSymbolsInPackage>
30+
<IncludeSymbolsInPackage Condition="'$(IncludeSymbolsInPackage)' == '' and '$(IncludeOutputsInPackage)' == 'true'">true</IncludeSymbolsInPackage>
3131
<!-- Whether to include framework references (%(ReferencePath.ResolvedFrom)' == '{TargetFrameworkDirectory}') in the package -->
3232

3333
<!-- Only default to true if the project isn't a nuget packaging project itself and its primary output is lib. -->
@@ -239,4 +239,4 @@ Copyright (c) .NET Foundation. All rights reserved.
239239
</ReadLegacyConfigDependencies>
240240
</Target>
241241

242-
</Project>
242+
</Project>

0 commit comments

Comments
 (0)