Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 0c0bc97

Browse files
committed
Bump GitInfo and unify how we reference it
Instead of having it scattered all over, keep it in PackageVersion.targets
1 parent 2906fd2 commit 0c0bc97

8 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/Build/NuGet.Build.Packaging.Tasks/NuGet.Build.Packaging.Tasks.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
<NuGetBuildTasksPackTargets>NO-SDK-PACK</NuGetBuildTasksPackTargets>
77
</PropertyGroup>
88
<ItemGroup>
9-
<PackageReference Include="GitInfo" Version="1.1.61" PrivateAssets="all" />
109
<PackageReference Include="ILRepack" Version="2.0.13" PrivateAssets="all" />
1110
<PackageReference Include="netfx-System.StringResources" Version="3.1.5" PrivateAssets="all" />
1211
<PackageReference Include="Microsoft.Build" Version="14.3.0" PrivateAssets="all" />

src/Build/NuGet.Build.Packaging.Tasks/NuGet.Build.Packaging.Tasks.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
</ItemDefinitionGroup>
1313

1414
<PropertyGroup>
15-
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
16-
15+
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
16+
1717
<PackageId>NuGet.Build.Packaging</PackageId>
1818
<Title>NuGetizer-3000</Title>
1919
<Description>NuGetizer-3000</Description>

src/Build/NuGet.Build.Packaging.Tests/NuGet.Build.Packaging.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
</Reference>
1414
</ItemGroup>
1515
<ItemGroup>
16-
<PackageReference Include="GitInfo" Version="1.1.61" />
1716
<PackageReference Include="Microsoft.Build" Version="14.3.0" />
1817
<PackageReference Include="Microsoft.Build.Logging.StructuredLogger" Version="1.1.168" />
1918
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="14.3.0" />

src/NuGet.Build.Packaging.Shared.props

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="..\build.props" />
4-
4+
55
<PropertyGroup>
66
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
77
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
@@ -10,7 +10,7 @@
1010
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
1111
<AssemblyName>$(MSBuildProjectName)</AssemblyName>
1212
<RootNamespace>NuGet.Build.Packaging</RootNamespace>
13-
13+
1414
<OutputPath Condition=" '$(OutputPath)' == '' ">bin\$(Configuration)\</OutputPath>
1515
<OutputType>Library</OutputType>
1616
<AppDesignerFolder>Properties</AppDesignerFolder>
@@ -46,11 +46,11 @@
4646

4747
<!-- Redefined by the GitInfo targets import -->
4848
<Target Name="GitVersion" />
49-
49+
5050
<Import Project="$(MSBuildProjectDirectory)\$(MSBuildProjectName).props" Condition="Exists('$(MSBuildProjectDirectory)\$(MSBuildProjectName).props')" />
5151

5252
<PropertyGroup>
53-
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
53+
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
5454
<NuGetPackagingPropsImported>true</NuGetPackagingPropsImported>
5555
</PropertyGroup>
5656

src/NuGet.Build.Packaging.Shared.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<Import Project="$(MSBuildProjectDirectory)\$(MSBuildProjectName).targets" Condition="Exists('$(MSBuildProjectDirectory)\$(MSBuildProjectName).targets')" />
1111

1212
<PropertyGroup>
13-
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
13+
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
1414
<NuGetPackagingTargetsImported>true</NuGetPackagingTargetsImported>
1515
</PropertyGroup>
1616

src/PackageVersion.targets

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33

44
<PropertyGroup>
5-
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
5+
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
66
<!-- We use branch and file version sources only -->
77
<GitIgnoreTagVersion>true</GitIgnoreTagVersion>
88
<BuildDependsOn>
@@ -11,6 +11,10 @@
1111
</BuildDependsOn>
1212
</PropertyGroup>
1313

14+
<ItemGroup>
15+
<PackageReference Include="GitInfo" Version="2.0.7" PrivateAssets="all" />
16+
</ItemGroup>
17+
1418
<Target Name="GetPackageVersion" BeforeTargets="ThisProjectInfo" DependsOnTargets="GitVersion" Returns="$(PackageVersion)">
1519
<PropertyGroup>
1620
<!-- PR builds are *always* prerelease -->

src/VisualStudio/NuGet.Packaging.VisualStudio.15/NuGet.Packaging.VisualStudio.15.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
<PackageReference Include="Clarius.VisualStudio" Version="2.0.13" />
4848
<PackageReference Include="Clide" Version="3.0.107-pre" />
4949
<PackageReference Include="Clide.Installer" Version="3.0.107-pre" />
50-
<PackageReference Include="GitInfo" Version="1.1.61" />
5150
<PackageReference Include="Merq" Version="1.0.0-rc" />
5251
<PackageReference Include="Merq.Async" Version="1.1.17-rc" />
5352
<PackageReference Include="Microsoft.Build" Version="15.1.548" />

src/VisualStudio/NuGet.Packaging.VisualStudio/NuGet.Packaging.VisualStudio.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
</ItemGroup>
3030
<ItemGroup>
3131
<PackageReference Include="Clide" Version="3.0.107-pre" />
32-
<PackageReference Include="GitInfo" Version="1.1.61" />
3332
<PackageReference Include="Merq" Version="1.0.0-rc" />
3433
<PackageReference Include="Microsoft.VisualStudio.Shell.14.0" Version="14.3.25407" />
3534
<PackageReference Include="Microsoft.VisualStudio.Shell.Interop.11.0" Version="11.0.61030" />

0 commit comments

Comments
 (0)