Skip to content

Commit 68121ce

Browse files
Merge pull request #306993 from pthippeswamy/pt-discovery-create
Removing tenant ID as workspaceroots
2 parents b17dee8 + 25b74f5 commit 68121ce

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

articles/storage-discovery/create-workspace-bicep.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ The template lists [Discovery workspace properties](/azure/templates/microsoft.s
6565

6666
| Name | Description |
6767
|------------------|-------------|
68-
|`workspaceRoots` | The workspace root designates the storage resources to get insights for. This `string[]` can contain a combination of subscription IDs and resource group IDs. You may mix and match these resource types. The identity under which you deploy this template [must have permissions](deployment-planning.md#permissions-to-your-storage-resources) to all resources you list at the time of deployment. Alternatively, you may also provide a single tenant URI in this array. All storage resources under the tenant are then covered by this workspace. When choosing this option, you must not provide any other resource IDs. |
68+
|`workspaceRoots` | The workspace root designates the storage resources to get insights for. This `string[]` can contain a combination of subscription IDs and resource group IDs. You may mix and match these resource types. The identity under which you deploy this template [must have permissions](deployment-planning.md#permissions-to-your-storage-resources) to all resources you list at the time of deployment. |
6969
|`scopes` | You can create several scopes in a workspace. A scope allows you to filter the storage resources the workspace covers and obtain different reports for each of these scopes. Filtering is based on ARM resource tags on your storage resources. This property expects a `JSON` object containing sections for `tag key name` : `value` combinations or `tag key names` only. When your storage resources have matching ARM resource tags, they're included in this scope.|
7070

7171
Here's an example of the `JSON` structure defining a single scope in a Discovery workspace.

articles/storage-discovery/create-workspace.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,11 @@ Select the subscriptions and/or resource groups you want to include in the works
4646
> [!NOTE]
4747
> - Ensure that the user or service principal deploying the workspace is granted at least **Reader** access to each specified root.
4848
> - Up to 100 resources - subscriptions and/or resource groups can be included in one workspace.
49+
> - The default limit of 100 resources per workspace can be increased. Reach out [Azure Support](https://portal.azure.com/#blade/Microsoft_Azure_Support/HelpAndSupportBlade/overview). Provide the tenantID, SubscriptionID where you would want this limit to be increased.
4950
5051
:::image source="media/create-workspace/workspace-roots-checks-sml.png" alt-text="Screenshot of the workspaceRoots." lightbox="media/create-workspace/workspace-roots-checks.png":::
5152

52-
After you add your subscriptions, resource groups, or tenant to your workspace, the service runs an access check to verify that the user has `Microsoft.Storage/storageAccounts/read` on the added resources. The following image provides an example of an access check failure with the associated status message.
53+
After you add your subscriptions or resource groups to your workspace, the service runs an access check to verify that the user has `Microsoft.Storage/storageAccounts/read` on the added resources. The following image provides an example of an access check failure with the associated status message.
5354

5455
:::image source="media/create-workspace/create-access-sml.png" alt-text="Screenshot of the access check on workspaceRoots." lightbox="media/create-workspace/create-access.png":::
5556

@@ -68,7 +69,7 @@ You can optionally add tags to this workspace resource. Then select **Review and
6869
:::image source="media/create-workspace/access-check-sml.png" alt-text="Screenshot of access checks running." lightbox="media/create-workspace/access-check.png":::
6970

7071
> [!NOTE]
71-
> Discovery resource creation fails if the access checks on any subscription, resource group, or tenant isn't successful.
72+
> Discovery resource creation fails if the access checks on any subscription or resource group isn't successful.
7273
7374
After the access checks complete successfully, the resource can be deployed as shown in the following sample image.
7475

@@ -125,7 +126,7 @@ az storage-discovery workspace create \
125126
| resource-group | The resource group where the workspace is created. |
126127
| name | The name of the workspace. |
127128
| location | Azure region for deployment. |
128-
| workspace-roots | The workspace root designates the storage resources to get insights for. This `string[]` can contain a combination of subscription IDs and resource group IDs. You may mix and match these resource types. The identity under which you deploy the workspace [must have permissions](deployment-planning.md#permissions-to-your-storage-resources) to all resources you list at the time of deployment. Alternatively, you may also provide a single tenant ID in this array. All storage resources under the tenant are then covered by this workspace. When choosing this option, you must not provide any other resource IDs. |
129+
| workspace-roots | The workspace root designates the storage resources to get insights for. This `string[]` can contain a combination of subscription IDs and resource group IDs. You may mix and match these resource types. The identity under which you deploy the workspace [must have permissions](deployment-planning.md#permissions-to-your-storage-resources) to all resources you list at the time of deployment. |
129130
| scopes | You can create several scopes in a workspace. A scope allows you to filter the storage resources the workspace covers and obtain different reports for each of these scopes. Filtering is based on ARM resource tags on your storage resources. This property expects a `JSON` object containing sections for `tag key name` : `value` combinations or `tag key names` only. When your storage resources have matching ARM resource tags, they're included in this scope. |
130131
| sku | Pricing tier (Free or Standard). |
131132

articles/storage-discovery/management-components.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ You also need a workspace when asking the Azure Copilot about insights from Stor
2424

2525
## Workspace Root
2626

27-
The workspace root designates the storage resources to get insights for. A workspace root can contain a combination of subscriptions and resource groups. You may mix and match these resource types. The identity under which you deploy the workspace [must have permissions](deployment-planning.md#permissions-to-your-storage-resources) to all resources you list at the time of deployment. Alternatively, you may also provide a single tenant ID in this array. All storage resources under the tenant are then covered by this workspace. When choosing this option, you must not provide any other resource IDs.
27+
The workspace root designates the storage resources to get insights for. A workspace root can contain a combination of subscriptions and resource groups. You may mix and match these resource types. The identity under which you deploy the workspace [must have permissions](deployment-planning.md#permissions-to-your-storage-resources) to all resources you list at the time of deployment.
2828

2929
Example:
3030

0 commit comments

Comments
 (0)