From 276296239a77d7aeadb0808bc5b5be502d160632 Mon Sep 17 00:00:00 2001 From: Sarthak Kharka Date: Tue, 16 Dec 2025 00:35:41 +0530 Subject: [PATCH 1/3] chore: refactor pull request template for better structure and UI guidance Signed-off-by: Sarthak Kharka :wq --- .github/pull_request_template.md | 146 +++++++++++++++++-------------- 1 file changed, 80 insertions(+), 66 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 43d5946d7c..69006432fc 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,66 +1,80 @@ -### Pull Request Description - - -### Related Issue - -Issue Number: - -### Pull Request Type - - - -### Pull request checklist - -- [ ] Did you explain or provide a way of how can we test your code ? -- [ ] If your pull request is related to frontend modifications provide a print of before and after screen -- [ ] Did you provide a general summary of your changes ? -- [ ] Try to limit your pull request to one type, submit multiple pull requests if needed -- [ ] I implemented tests that cover my contribution - -
-How to see this running using GitHub Codespaces - -### 1. Open the Codespace -- Authenticate to GitHub -- Go to the branch: [chore/reduce-configure-check-time](https://github.com/LibreSign/libresign/tree/chore/reduce-configure-check-time) -- Click the `Code` button and select the `Codespaces` tab. -- Click **"Create codespace on feat/customize-signature-stamp"** - -### 2. Wait for the environment to start -- A progress bar will appear on the left. -- After that, the terminal will show the build process. -- Wait until you see the message: - ```bash - โœ๏ธ LibreSign is up! - ``` - This may take a few minutes. - -### 3. Access LibreSign in the browser -- Open the **Ports** tab (next to the **Terminal**). -- Look for the service running on port **80**. -- Hover over the URL and click the **globe icon** ๐ŸŒ to open it in your browser. - -### 4. (Optional) Make the service public -- If you want to share the app with people **not logged in to GitHub**, you must change the port visibility: - - Click the three dots `โ‹ฎ` on the row for port 80. - - Select `Change visibility` โ†’ `Public`. - -### 5. Login credentials -- **Username**: `admin` -- **Password**: `admin` - -Done! ๐ŸŽ‰ -You're now ready to test this. -
+## โ˜‘๏ธ Resolves +Fixes # + +--- + +## ๐Ÿ“ Summary +Provide a short, clear summary of what this pull request does and why it is needed. + +--- + +## ๐Ÿงช How to Test (GitHub Codespaces) + +> Follow these steps to test this pull request using GitHub Codespaces. + +1. Open the repository and click **Code โ†’ Codespaces** +2. Create a new Codespace for this branch +3. Wait for the environment to finish setting up + You should see: +โœ๏ธ LibreSign is up! +4. Open the **Ports** tab +5. Open the service running on **port 80** +6. Login using: +- **Username:** admin +- **Password:** admin + +Done! ๐ŸŽ‰ You are now ready to test this. + +--- + +## ๐ŸŽจ UI (Frontend) Changes + +> Complete this section only if this pull request includes UI changes. + +### ๐Ÿ–ผ๏ธ Screenshots / Screencasts + +| Before | After | +|--------|-------| +| _Insert screenshot_ | _Insert screenshot_ | + +### ๐Ÿšง UI Tasks +- [ ] UI changes implemented +- [ ] Visual consistency checked +- [ ] Accessibility considerations applied (if applicable) + +### ๐Ÿ UI Checklist +- [ ] Tested on Chromium-based browsers (Chrome / Edge / Brave) +- [ ] Tested on Firefox +- [ ] UI does not rely on browser-specific behavior +- [ ] Design reviewed, approved, or inspired by existing LibreSign / Nextcloud UI +- [ ] User-facing documentation updated (if required) + +--- + +## ๐Ÿ› ๏ธ API / Backend Changes + +> Complete this section only if this pull request includes backend or API changes. + +### ๐Ÿšง API Tasks +- [ ] Backend logic implemented or updated +- [ ] API contracts reviewed +- [ ] Database or migration changes documented (if applicable) + +### ๐Ÿ API Checklist +- [ ] Unit and/or integration tests added, or not required +- [ ] API documentation in `docs/` updated (if required) +- [ ] Capability added or confirmed not needed + +--- + +## ๐Ÿ“‹ General Checklist +- [ ] PR is focused on a single concern +- [ ] Code follows project conventions +- [ ] Relevant tests added or justified +- [ ] Documentation updated if needed +- [ ] No breaking changes (or clearly documented) + +--- + +## โ„น๏ธ Additional Notes +Add any additional context if necessary. \ No newline at end of file From 990302fe2113ea5da4de4f6230b3947e984e5077 Mon Sep 17 00:00:00 2001 From: Sarthak Kharka Date: Tue, 16 Dec 2025 01:11:32 +0530 Subject: [PATCH 2/3] chore: align pull request template with existing Codespaces and UI conventions Signed-off-by: Sarthak Kharka --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 69006432fc..161a718188 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -33,9 +33,9 @@ Done! ๐ŸŽ‰ You are now ready to test this. ### ๐Ÿ–ผ๏ธ Screenshots / Screencasts -| Before | After | -|--------|-------| -| _Insert screenshot_ | _Insert screenshot_ | +๐Ÿš๏ธ Before | ๐Ÿก After +-- | -- +Screenshot before | Screenshot after ### ๐Ÿšง UI Tasks - [ ] UI changes implemented From 0a2003851a07620a2cd95d93192e0d41a061d8d8 Mon Sep 17 00:00:00 2001 From: Sarthak Kharka Date: Tue, 16 Dec 2025 01:44:15 +0530 Subject: [PATCH 3/3] chore(docs): refactor pull request template for clearer UI and API guidance Signed-off-by: Sarthak Kharka --- .github/pull_request_template.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 161a718188..267ec72a76 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,23 +8,26 @@ Provide a short, clear summary of what this pull request does and why it is need --- -## ๐Ÿงช How to Test (GitHub Codespaces) +
+๐Ÿงช How to Test (GitHub Codespaces) > Follow these steps to test this pull request using GitHub Codespaces. 1. Open the repository and click **Code โ†’ Codespaces** 2. Create a new Codespace for this branch 3. Wait for the environment to finish setting up - You should see: -โœ๏ธ LibreSign is up! + You should see: + โœ๏ธ LibreSign is up! 4. Open the **Ports** tab 5. Open the service running on **port 80** 6. Login using: -- **Username:** admin -- **Password:** admin + - **Username:** admin + - **Password:** admin Done! ๐ŸŽ‰ You are now ready to test this. +
+ --- ## ๐ŸŽจ UI (Frontend) Changes