From 03ce6277161d4be8e844a62d08481e1933409749 Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Thu, 11 Dec 2025 09:54:11 -0300 Subject: [PATCH] fix: correct parameter order in getUserConfigByKey method Optional parameter declared before required parameter causes implicit required treatment. Changed method signature to put required parameter $key before optional parameter $user, and updated all call sites. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- lib/Service/AccountService.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Service/AccountService.php b/lib/Service/AccountService.php index 5341d5ebfc..6d8ed5903d 100644 --- a/lib/Service/AccountService.php +++ b/lib/Service/AccountService.php @@ -198,14 +198,14 @@ public function getConfig(?IUser $user = null): array { $info['id_docs_sort'] = $this->getUserConfigIdDocsSort($user); $info['crl_filters'] = $this->getUserConfigCrlFilters($user); $info['crl_sort'] = $this->getUserConfigCrlSort($user); - $info['grid_view'] = $this->getUserConfigByKey($user, 'grid_view') === '1'; + $info['grid_view'] = $this->getUserConfigByKey('grid_view', $user) === '1'; return array_filter($info); } public function getConfigFilters(?IUser $user = null): array { - $info['filter_modified'] = $this->getUserConfigByKey($user, 'filter_modified'); - $info['filter_status'] = $this->getUserConfigByKey($user, 'filter_status'); + $info['filter_modified'] = $this->getUserConfigByKey('filter_modified', $user); + $info['filter_status'] = $this->getUserConfigByKey('filter_status', $user); return $info; } @@ -246,7 +246,7 @@ public function hasSignatureFile(?IUser $user = null): bool { } } - private function getUserConfigByKey(?IUser $user = null, string $key): string { + private function getUserConfigByKey(string $key, ?IUser $user = null): string { if (!$user) { return ''; }