From 2d975b8e1d3f3fc43478927820f9c3aa05a47a7c Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Wed, 10 Dec 2025 15:22:45 -0300 Subject: [PATCH 1/2] fix: remove event emission on draft save to keep sidebar open The 'libresign:visible-elements-saved' event was being emitted when saving draft signatures, causing the sidebar to close unexpectedly. This event should only be emitted when sending signature requests, not when saving drafts. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/Components/Request/VisibleElements.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Components/Request/VisibleElements.vue b/src/Components/Request/VisibleElements.vue index 8ecd6594c6..7dac0cc7ed 100644 --- a/src/Components/Request/VisibleElements.vue +++ b/src/Components/Request/VisibleElements.vue @@ -299,7 +299,6 @@ export default { const response = await this.filesStore.saveWithVisibleElements({ visibleElements }) showSuccess(t('libresign', response.message)) this.closeModal() - emit('libresign:visible-elements-saved') this.loading = false return true } catch (error) { From cf68be28d4ce73f3df9c2d97a8fdd52c80ff315e Mon Sep 17 00:00:00 2001 From: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> Date: Wed, 10 Dec 2025 15:22:58 -0300 Subject: [PATCH 2/2] refactor: remove unused event listeners for visible-elements-saved Since the 'libresign:visible-elements-saved' event is no longer emitted on draft saves, the event listeners and related methods in Request.vue and FilesList.vue are no longer needed. - Removed subscribe/unsubscribe calls - Removed closeSidebar() methods - Removed unused imports from @nextcloud/event-bus Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> --- src/views/FilesList/FilesList.vue | 6 ------ src/views/Request.vue | 9 --------- 2 files changed, 15 deletions(-) diff --git a/src/views/FilesList/FilesList.vue b/src/views/FilesList/FilesList.vue index c87421bbd4..bf048053de 100644 --- a/src/views/FilesList/FilesList.vue +++ b/src/views/FilesList/FilesList.vue @@ -78,7 +78,6 @@ import FolderIcon from 'vue-material-design-icons/Folder.vue' import ListViewIcon from 'vue-material-design-icons/FormatListBulletedSquare.vue' import ViewGridIcon from 'vue-material-design-icons/ViewGrid.vue' -import { subscribe, unsubscribe } from '@nextcloud/event-bus' import { loadState } from '@nextcloud/initial-state' import NcAppContent from '@nextcloud/vue/components/NcAppContent' @@ -152,11 +151,9 @@ export default { async mounted() { await this.filesStore.getAllFiles({ force_fetch: true }) this.loading = false - subscribe('libresign:visible-elements-saved', this.closeSidebar) this.filesStore.disableIdentifySigner() }, beforeUnmount() { - unsubscribe('libresign:visible-elements-saved') this.filesStore.selectFile() }, methods: { @@ -166,9 +163,6 @@ export default { toggleGridView() { this.userConfigStore.update('grid_view', !this.userConfigStore.grid_view) }, - closeSidebar() { - this.filesStore.selectFile() - }, }, } diff --git a/src/views/Request.vue b/src/views/Request.vue index 424dfef5b8..98176c47ff 100644 --- a/src/views/Request.vue +++ b/src/views/Request.vue @@ -22,8 +22,6 @@