test: Add unit tests for nodeId validation support

Add comprehensive test coverage for:
- ValidateHelper nodeId validation (success, invalid nodeId, missing user)
- FileService nodeId-based node retrieval
- Precedence of fileId over nodeId when both are provided

These tests ensure the new nodeId functionality works correctly
while maintaining backward compatibility with existing fileId behavior.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Helper/ValidateHelper.php

@@ -130,7 +130,7 @@ public function validateFile(array $data, int $type = self::TYPE_TO_SIGN, ?IUser
 				throw new LibresignException($this->l10n->t('File type: %s. Invalid fileID.', [$this->getTypeOfFile($type)]));
 			}
 			if (!is_a($user, IUser::class)) {
-				if (!is_a($data['userManager'], IUser::class)) {
+				if (!isset($data['userManager']) || !is_a($data['userManager'], IUser::class)) {
 					throw new LibresignException($this->l10n->t('User not found.'));
 				}
 			}

tests/php/Unit/Helper/ValidateHelperTest.php

@@ -135,6 +135,47 @@ public function testValidateNewFileUsingFileIdWithSuccess():void {
 		$this->assertNull($actual);
 	}
 
+	public function testValidateNewFileUsingNodeIdWithSuccess():void {
+		$file = $this->createMock(\OCP\Files\File::class);
+		$file
+			->method('getMimeType')
+			->willReturn('application/pdf');
+		$this->root
+			->method('getUserFolder')
+			->willReturn($this->root);
+		$this->root
+			->method('getFirstNodeById')
+			->willReturn($file);
+
+		$user = $this->createMock(\OCP\IUser::class);
+		$user->method('getUID')->willReturn('john.doe');
+		$actual = $this->getValidateHelper()->validateNewFile([
+			'file' => ['nodeId' => 35523],
+			'name' => 'test',
+			'userManager' => $user,
+		]);
+		$this->assertNull($actual);
+	}
+
+	public function testValidateFileWithInvalidNodeId():void {
+		$this->expectExceptionMessage('Invalid fileID');
+		$user = $this->createMock(\OCP\IUser::class);
+		$user->method('getUID')->willReturn('john.doe');
+		$this->getValidateHelper()->validateFile([
+			'file' => ['nodeId' => 'invalid'],
+			'name' => 'test',
+			'userManager' => $user,
+		]);
+	}
+
+	public function testValidateFileWithNodeIdWithoutUser():void {
+		$this->expectExceptionMessage('User not found');
+		$this->getValidateHelper()->validateFile([
+			'file' => ['nodeId' => 35523],
+			'name' => 'test',
+		]);
+	}
+
 	public function testValidateNotRequestedSignWhenAlreadyAskedToSignThisDocument():void {
 		$this->signRequestMapper->method('getByNodeId')->willReturn('exists');
 		$this->expectExceptionMessage('Already asked to sign this document');

tests/php/Unit/Service/FileServiceTest.php

@@ -88,4 +88,76 @@ public function testSetFileByIdSetsFile(): void {
 		$this->assertInstanceOf(FileService::class, $returned);
 		$this->assertSame(1, $service->getStatus());
 	}
+
+	public function testGetNodeFromDataWithNodeId(): void {
+		$node = $this->createMock(\OCP\Files\File::class);
+		$folderService = $this->createMock(\OCA\Libresign\Service\FolderService::class);
+		$folderService->method('getUserId')->willReturn('testuser');
+		$folderService->method('getFileByNodeId')->with(35523)->willReturn($node);
+
+		$userManager = $this->createMock(\OCP\IUser::class);
+		$userManager->method('getUID')->willReturn('testuser');
+
+		$service = $this->createFileService([
+			\OCA\Libresign\Service\FolderService::class => $folderService,
+		]);
+
+		$data = [
+			'file' => ['nodeId' => 35523],
+			'userManager' => $userManager,
+		];
+
+		$result = $service->getNodeFromData($data);
+		$this->assertSame($node, $result);
+	}
+
+	public function testGetNodeFromDataWithFileId(): void {
+		$node = $this->createMock(\OCP\Files\File::class);
+		$folderService = $this->createMock(\OCA\Libresign\Service\FolderService::class);
+		$folderService->method('getUserId')->willReturn('testuser');
+		$folderService->method('getFileByNodeId')->with(12345)->willReturn($node);
+
+		$userManager = $this->createMock(\OCP\IUser::class);
+		$userManager->method('getUID')->willReturn('testuser');
+
+		$service = $this->createFileService([
+			\OCA\Libresign\Service\FolderService::class => $folderService,
+		]);
+
+		$data = [
+			'file' => ['fileId' => 12345],
+			'userManager' => $userManager,
+		];
+
+		$result = $service->getNodeFromData($data);
+		$this->assertSame($node, $result);
+	}
+
+	public function testGetNodeFromDataPrefersFileIdOverNodeId(): void {
+		$nodeFromFileId = $this->createMock(\OCP\Files\File::class);
+		$folderService = $this->createMock(\OCA\Libresign\Service\FolderService::class);
+		$folderService->method('getUserId')->willReturn('testuser');
+		$folderService->expects($this->once())
+			->method('getFileByNodeId')
+			->with(12345)
+			->willReturn($nodeFromFileId);
+
+		$userManager = $this->createMock(\OCP\IUser::class);
+		$userManager->method('getUID')->willReturn('testuser');
+
+		$service = $this->createFileService([
+			\OCA\Libresign\Service\FolderService::class => $folderService,
+		]);
+
+		$data = [
+			'file' => [
+				'fileId' => 12345,
+				'nodeId' => 35523, // This should be ignored
+			],
+			'userManager' => $userManager,
+		];
+
+		$result = $service->getNodeFromData($data);
+		$this->assertSame($nodeFromFileId, $result);
+	}
 }