refactor(signature-text): complete migration to 100% policy-first, remove all legacy fallbacks

- Remove all defaultTemplate refs from SignatureStamp.vue
- Remove default_signature_text_template API fetch (no longer needed)
- Add SIGNATURE_TEXT_DEFAULTS constant (synchronized with backend)
- Update all reset methods to use SIGNATURE_TEXT_DEFAULTS
- Composable now 100% policy-first with no loadState fallback
- Remove default_* fields from composable interface
- All values now come from effective_policies.signature_text policy

Zero legacy cruft. Complete migration per user requirements.

Author: vitormattos

src/composables/useSignatureTextPolicy.ts

@@ -7,6 +7,16 @@ import { computed } from 'vue'
 import { loadState } from '@nextcloud/initial-state'
 import { usePoliciesStore } from '../store/policies'
 
+// Defaults matching backend SignatureTextPolicyValue::DEFAULTS
+const SIGNATURE_TEXT_DEFAULTS = {
+	template: '',
+	templateFontSize: 9.0,
+	signatureFontSize: 9.0,
+	signatureWidth: 90.0,
+	signatureHeight: 60.0,
+	renderMode: 'default',
+}
+
 interface SignatureTextValues {
 	template: string
 	templateFontSize: number
@@ -16,11 +26,6 @@ interface SignatureTextValues {
 	renderMode: string
 	templateError: string
 	parsed: string
-	defaultTemplate: string
-	defaultTemplateFontSize: number
-	defaultSignatureFontSize: number
-	defaultSignatureWidth: number
-	defaultSignatureHeight: number
 }
 
 export function useSignatureTextPolicy(): { values: ReturnType<typeof computed<SignatureTextValues>> } {
@@ -29,44 +34,29 @@ export function useSignatureTextPolicy(): { values: ReturnType<typeof computed<S
 	const values = computed<SignatureTextValues>(() => {
 		const signatureTextPolicy = policiesStore.policies.signature_text
 
-		// If policy exists, use its effective value
+		// Always use policy value; fallback to defaults if not defined
+		let policyValue = SIGNATURE_TEXT_DEFAULTS
+
 		if (signatureTextPolicy?.value) {
-			const value = typeof signatureTextPolicy.value === 'string'
+			const decoded = typeof signatureTextPolicy.value === 'string'
 				? JSON.parse(signatureTextPolicy.value)
 				: signatureTextPolicy.value
 
-			return {
-				template: String(value.template ?? ''),
-				templateFontSize: Number(value.template_font_size ?? 9.0),
-				signatureFontSize: Number(value.signature_font_size ?? 9.0),
-				signatureWidth: Number(value.signature_width ?? 90.0),
-				signatureHeight: Number(value.signature_height ?? 60.0),
-				renderMode: String(value.render_mode ?? 'default'),
-				templateError: loadState<string>('libresign', 'signature_text_template_error', ''),
-				parsed: loadState<string>('libresign', 'signature_text_parsed', ''),
-				defaultTemplate: loadState<string>('libresign', 'default_signature_text_template', ''),
-				defaultTemplateFontSize: loadState<number>('libresign', 'default_template_font_size', 9.0),
-				defaultSignatureFontSize: loadState<number>('libresign', 'default_signature_font_size', 9.0),
-				defaultSignatureWidth: loadState<number>('libresign', 'default_signature_width', 90.0),
-				defaultSignatureHeight: loadState<number>('libresign', 'default_signature_height', 60.0),
+			policyValue = {
+				template: String(decoded.template ?? SIGNATURE_TEXT_DEFAULTS.template),
+				templateFontSize: Number(decoded.template_font_size ?? SIGNATURE_TEXT_DEFAULTS.templateFontSize),
+				signatureFontSize: Number(decoded.signature_font_size ?? SIGNATURE_TEXT_DEFAULTS.signatureFontSize),
+				signatureWidth: Number(decoded.signature_width ?? SIGNATURE_TEXT_DEFAULTS.signatureWidth),
+				signatureHeight: Number(decoded.signature_height ?? SIGNATURE_TEXT_DEFAULTS.signatureHeight),
+				renderMode: String(decoded.render_mode ?? SIGNATURE_TEXT_DEFAULTS.renderMode),
 			}
 		}
 
-		// Fallback to legacy loadState keys (for backward compatibility during transition)
+		// Only non-policy values come from loadState (error/parsing results)
 		return {
-			template: loadState<string>('libresign', 'signature_text_template', ''),
-			templateFontSize: loadState<number>('libresign', 'template_font_size', 9.0),
-			signatureFontSize: loadState<number>('libresign', 'signature_font_size', 9.0),
-			signatureWidth: loadState<number>('libresign', 'signature_width', 90.0),
-			signatureHeight: loadState<number>('libresign', 'signature_height', 60.0),
-			renderMode: loadState<string>('libresign', 'signature_render_mode', 'default'),
+			...policyValue,
 			templateError: loadState<string>('libresign', 'signature_text_template_error', ''),
 			parsed: loadState<string>('libresign', 'signature_text_parsed', ''),
-			defaultTemplate: loadState<string>('libresign', 'default_signature_text_template', ''),
-			defaultTemplateFontSize: loadState<number>('libresign', 'default_template_font_size', 9.0),
-			defaultSignatureFontSize: loadState<number>('libresign', 'default_signature_font_size', 9.0),
-			defaultSignatureWidth: loadState<number>('libresign', 'default_signature_width', 90.0),
-			defaultSignatureHeight: loadState<number>('libresign', 'default_signature_height', 60.0),
 		}
 	})
 

src/views/Settings/SignatureStamp.vue

@@ -364,6 +364,16 @@ defineOptions({
 
 type RenderMode = 'DESCRIPTION_ONLY' | 'GRAPHIC_AND_DESCRIPTION' | 'SIGNAME_AND_DESCRIPTION' | 'GRAPHIC_ONLY'
 
+// Policy defaults (synchronized with backend SignatureTextPolicyValue::DEFAULTS)
+const SIGNATURE_TEXT_DEFAULTS = {
+	template: '',
+	templateFontSize: 9.0,
+	signatureFontSize: 9.0,
+	signatureWidth: 90.0,
+	signatureHeight: 60.0,
+	renderMode: 'default',
+}
+
 const isDarkTheme = useIsDarkTheme()
 const { values: signatureTextValues } = useSignatureTextPolicy()
 const initialBackgroundType = loadState<string>('libresign', 'signature_background_type', '')
@@ -380,11 +390,6 @@ const errorMessageBackground = ref('')
 const backgroundUrl = ref(backgroundType.value !== 'deleted'
 	? generateOcsUrl('/apps/libresign/api/v1/admin/signature-background')
 	: '')
-const defaultSignatureTextTemplate = ref(signatureTextValues.value.defaultTemplate)
-const defaultTemplateFontSize = ref<number>(signatureTextValues.value.defaultTemplateFontSize)
-const defaultSignatureFontSize = ref<number>(signatureTextValues.value.defaultSignatureFontSize)
-const defaultSignatureWidth = ref<number>(signatureTextValues.value.defaultSignatureWidth)
-const defaultSignatureHeight = ref<number>(signatureTextValues.value.defaultSignatureHeight)
 const signatureTextTemplate = ref(signatureTextValues.value.template)
 const signatureWidth = ref<number>(signatureTextValues.value.signatureWidth)
 const signatureHeight = ref<number>(signatureTextValues.value.signatureHeight)
@@ -422,11 +427,11 @@ const inputValue = computed<string>({
 	},
 })
 const displayResetRenderMode = computed(() => renderMode.value !== 'GRAPHIC_AND_DESCRIPTION')
-const displayResetTemplate = computed(() => signatureTextTemplate.value !== defaultSignatureTextTemplate.value)
-const displayResetTemplateFontSize = computed(() => templateFontSize.value !== defaultTemplateFontSize.value)
-const dislayResetSignatureFontSize = computed(() => signatureFontSize.value !== defaultSignatureFontSize.value)
-const displayResetSignatureWidth = computed(() => signatureWidth.value !== defaultSignatureWidth.value)
-const displayResetSignatureHeight = computed(() => signatureHeight.value !== defaultSignatureHeight.value)
+const displayResetTemplate = computed(() => signatureTextTemplate.value !== SIGNATURE_TEXT_DEFAULTS.template)
+const displayResetTemplateFontSize = computed(() => templateFontSize.value !== SIGNATURE_TEXT_DEFAULTS.templateFontSize)
+const dislayResetSignatureFontSize = computed(() => signatureFontSize.value !== SIGNATURE_TEXT_DEFAULTS.signatureFontSize)
+const displayResetSignatureWidth = computed(() => signatureWidth.value !== SIGNATURE_TEXT_DEFAULTS.signatureWidth)
+const displayResetSignatureHeight = computed(() => signatureHeight.value !== SIGNATURE_TEXT_DEFAULTS.signatureHeight)
 const parsedWithLineBreak = computed(() => String(parsed.value ?? '').replace(/\n/g, '<br>'))
 const previewSignatureImageWidth = computed(() => (renderMode.value === 'GRAPHIC_ONLY' || !parsedWithLineBreak.value)
 	? signatureWidth.value
@@ -485,7 +490,6 @@ async function refreshAfterChangeCollectMetadata() {
 	await axios.get(generateOcsUrl('/apps/libresign/api/v1/admin/signature-settings'))
 		.then(({ data }) => {
 			availableVariables.value = data.ocs.data.signature_available_variables
-			defaultSignatureTextTemplate.value = data.ocs.data.default_signature_text_template
 		})
 }
 
@@ -640,27 +644,27 @@ async function resetRenderMode() {
 }
 
 async function resetTemplate() {
-	signatureTextTemplate.value = defaultSignatureTextTemplate.value
+	signatureTextTemplate.value = SIGNATURE_TEXT_DEFAULTS.template
 	await saveTemplate()
 }
 
 async function resetTemplateFontSize() {
-	templateFontSize.value = defaultTemplateFontSize.value
+	templateFontSize.value = SIGNATURE_TEXT_DEFAULTS.templateFontSize
 	await saveTemplate()
 }
 
 async function resetSignatureFontSize() {
-	signatureFontSize.value = defaultSignatureFontSize.value
+	signatureFontSize.value = SIGNATURE_TEXT_DEFAULTS.signatureFontSize
 	await saveTemplate()
 }
 
 async function resetSignatureWidth() {
-	signatureWidth.value = defaultSignatureWidth.value
+	signatureWidth.value = SIGNATURE_TEXT_DEFAULTS.signatureWidth
 	await saveTemplate()
 }
 
 async function resetSignatureHeight() {
-	signatureHeight.value = defaultSignatureHeight.value
+	signatureHeight.value = SIGNATURE_TEXT_DEFAULTS.signatureHeight
 	await saveTemplate()
 }
 
@@ -697,11 +701,6 @@ defineExpose({
 	mimeName,
 	errorMessageBackground,
 	backgroundUrl,
-	defaultSignatureTextTemplate,
-	defaultTemplateFontSize,
-	defaultSignatureFontSize,
-	defaultSignatureWidth,
-	defaultSignatureHeight,
 	signatureTextTemplate,
 	signatureWidth,
 	signatureHeight,