chore(refactor): Move logic of save multiple files to service

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Controller/FileController.php

@@ -651,28 +651,14 @@ private function saveFiles(array $files, string $name, array $settings): DataRes
 			throw new LibresignException($this->l10n->t('File or files parameter is required'));
 		}
 
-		if (count($files) === 1) {
-			$fileData = $files[0];
-			$fileName = $name;
-			$prepared = $this->prepareFileForSaving($fileData, $fileName, $settings);
-			$savedFile = $this->requestSignatureService->save([
-				'file' => ['fileNode' => $prepared['node']],
-				'name' => $prepared['name'],
-				'userManager' => $this->userSession->getUser(),
-				'status' => FileEntity::STATUS_DRAFT,
-			]);
-
-			return $this->formatFileResponse($savedFile, [$savedFile]);
-		}
-
-		$result = $this->requestSignatureService->saveEnvelope([
+		$result = $this->requestSignatureService->saveFiles([
 			'files' => $files,
 			'name' => $name,
 			'userManager' => $this->userSession->getUser(),
 			'settings' => $settings,
 		]);
 
-		return $this->formatFileResponse($result['envelope'], $result['files']);
+		return $this->formatFileResponse($result['file'], $result['children']);
 	}
 
 	/**

lib/Service/RequestSignatureService.php

@@ -17,6 +17,7 @@
 use OCA\Libresign\Db\SignRequestMapper;
 use OCA\Libresign\Enum\SignatureFlow;
 use OCA\Libresign\Events\SignRequestCanceledEvent;
+use OCA\Libresign\Exception\LibresignException;
 use OCA\Libresign\Handler\DocMdpHandler;
 use OCA\Libresign\Helper\FileUploadHelper;
 use OCA\Libresign\Helper\ValidateHelper;
@@ -63,6 +64,45 @@ public function __construct(
 	) {
 	}
 
+	/**
+	 * Save files - creates single file or envelope based on files count
+	 *
+	 * @param array{files: array, name: string, settings: array, userManager: IUser} $data
+	 * @return array{file: FileEntity, children: FileEntity[]}
+	 */
+	public function saveFiles(array $data): array {
+		if (empty($data['files'])) {
+			throw new LibresignException('Files parameter is required');
+		}
+
+		if (count($data['files']) === 1) {
+			$fileData = $data['files'][0];
+			$savedFile = $this->save([
+				'file' => ['fileNode' => $fileData['node']],
+				'name' => $fileData['name'],
+				'userManager' => $data['userManager'],
+				'status' => FileEntity::STATUS_DRAFT,
+			]);
+
+			return [
+				'file' => $savedFile,
+				'children' => [$savedFile],
+			];
+		}
+
+		$result = $this->saveEnvelope([
+			'files' => $data['files'],
+			'name' => $data['name'],
+			'userManager' => $data['userManager'],
+			'settings' => $data['settings'],
+		]);
+
+		return [
+			'file' => $result['envelope'],
+			'children' => $result['files'],
+		];
+	}
+
 	public function save(array $data): FileEntity {
 		$file = $this->saveFile($data);
 		$this->saveVisibleElements($data, $file);