Skip to content

Commit ac5cc98

Browse files
committed
refactor: centralize signature text UI defaults
Signed-off-by: Vitor Mattos <[email protected]>
1 parent 54ef7d2 commit ac5cc98

2 files changed

Lines changed: 25 additions & 20 deletions

File tree

src/views/Settings/PolicyWorkbench/settings/signature-text/useSignatureTextPolicy.ts

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,9 @@
66
import { computed, type ComputedRef } from 'vue'
77
import { loadState } from '@nextcloud/initial-state'
88
import { usePoliciesStore } from '../../../../../store/policies'
9+
import { getDefaultSignatureTextPolicyConfig } from './model'
910

10-
// Defaults matching backend SignatureTextPolicyValue::DEFAULTS
11-
const SIGNATURE_TEXT_DEFAULTS = {
12-
template: '',
13-
templateFontSize: 9.0,
14-
signatureFontSize: 9.0,
15-
signatureWidth: 90.0,
16-
signatureHeight: 60.0,
17-
renderMode: 'default',
18-
}
11+
const SIGNATURE_TEXT_DEFAULTS = getDefaultSignatureTextPolicyConfig()
1912

2013
interface SignatureTextValues {
2114
template: string
@@ -28,6 +21,27 @@ interface SignatureTextValues {
2821
parsed: string
2922
}
3023

24+
export interface SignatureTextUiDefaults {
25+
template: string
26+
templateFontSize: number
27+
signatureFontSize: number
28+
signatureWidth: number
29+
signatureHeight: number
30+
renderMode: string
31+
}
32+
33+
export function getSignatureTextUiDefaults(): SignatureTextUiDefaults {
34+
return {
35+
template: loadState<string>('libresign', 'default_signature_text_template', SIGNATURE_TEXT_DEFAULTS.template),
36+
templateFontSize: Number(loadState<number>('libresign', 'default_template_font_size', SIGNATURE_TEXT_DEFAULTS.templateFontSize)),
37+
signatureFontSize: Number(loadState<number>('libresign', 'default_signature_font_size', SIGNATURE_TEXT_DEFAULTS.signatureFontSize)),
38+
signatureWidth: Number(loadState<number>('libresign', 'default_signature_width', SIGNATURE_TEXT_DEFAULTS.signatureWidth)),
39+
signatureHeight: Number(loadState<number>('libresign', 'default_signature_height', SIGNATURE_TEXT_DEFAULTS.signatureHeight)),
40+
// Reset must use canonical default, not current effective value.
41+
renderMode: 'GRAPHIC_AND_DESCRIPTION',
42+
}
43+
}
44+
3145
export function useSignatureTextPolicy(): { values: ComputedRef<SignatureTextValues> } {
3246
const policiesStore = usePoliciesStore()
3347

src/views/Settings/SignatureStamp.vue

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -356,24 +356,15 @@ import NcTextField from '@nextcloud/vue/components/NcTextField'
356356
import { useIsDarkTheme } from '@nextcloud/vue/composables/useIsDarkTheme'
357357
358358
import CodeEditor from '../../components/CodeEditor.vue'
359-
import { useSignatureTextPolicy } from './PolicyWorkbench/settings/signature-text/useSignatureTextPolicy'
359+
import { getSignatureTextUiDefaults, useSignatureTextPolicy } from './PolicyWorkbench/settings/signature-text/useSignatureTextPolicy'
360360
361361
defineOptions({
362362
name: 'SignatureStamp',
363363
})
364364
365365
type RenderMode = 'DESCRIPTION_ONLY' | 'GRAPHIC_AND_DESCRIPTION' | 'SIGNAME_AND_DESCRIPTION' | 'GRAPHIC_ONLY'
366366
367-
// Defaults used by UI reset actions.
368-
const SIGNATURE_TEXT_DEFAULTS = {
369-
template: loadState<string>('libresign', 'default_signature_text_template', ''),
370-
templateFontSize: Number(loadState<number>('libresign', 'default_template_font_size', 9.0)),
371-
signatureFontSize: Number(loadState<number>('libresign', 'default_signature_font_size', 9.0)),
372-
signatureWidth: Number(loadState<number>('libresign', 'default_signature_width', 90.0)),
373-
signatureHeight: Number(loadState<number>('libresign', 'default_signature_height', 60.0)),
374-
// Reset must use canonical default, not current effective value.
375-
renderMode: 'GRAPHIC_AND_DESCRIPTION',
376-
}
367+
const SIGNATURE_TEXT_DEFAULTS = getSignatureTextUiDefaults()
377368
378369
const isDarkTheme = useIsDarkTheme()
379370
const { values: signatureTextValues } = useSignatureTextPolicy()

0 commit comments

Comments
 (0)