Skip to content

Commit 9e642e7

Browse files
authored
Merge pull request #5269 from LibreSign/fix/previous-pr
fix: move back to separated job
2 parents 3ee45de + f1db340 commit 9e642e7

1 file changed

Lines changed: 14 additions & 11 deletions

File tree

.github/workflows/phpunit-mysql.yml

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ jobs:
7171
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
7272
server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }}
7373
mysql-versions: ["8.4"]
74-
xdebug_mode: ['coverage']
7574

7675
name: MySQL ${{ matrix.mysql-versions }} PHP ${{ matrix.php-versions }} Nextcloud ${{ matrix.server-versions }}
7776

@@ -168,18 +167,8 @@ jobs:
168167
# Only run if phpunit config file exists
169168
if: steps.check_phpunit.outcome == 'success'
170169
working-directory: apps/${{ env.APP_NAME }}
171-
env:
172-
XDEBUG_MODE: ${{ matrix.xdebug_mode }}
173170
run: composer run test:coverage
174171

175-
- name: Upload coverage results to Coveralls
176-
working-directory: apps/${{ env.APP_NAME }}
177-
env:
178-
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
179-
COVERALLS_PARALLEL: true
180-
COVERALLS_FLAG_NAME: php-${{ matrix.php-versions }}
181-
run: vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml --json_path=build/logs/coveralls-upload.json -v
182-
183172
- name: Check PHPUnit integration script is defined
184173
id: check_integration
185174
continue-on-error: true
@@ -224,6 +213,20 @@ jobs:
224213
- name: Summary status
225214
run: if ${{ needs.changes.outputs.src != 'false' && needs.phpunit-mysql.result != 'success' }}; then exit 1; fi
226215

216+
upload-coverage:
217+
needs: phpunit-mysql
218+
runs-on: ubuntu-latest
219+
strategy:
220+
matrix:
221+
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
222+
steps:
223+
- name: Upload coverage results to Coveralls
224+
working-directory: apps/${{ env.APP_NAME }}
225+
env:
226+
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
227+
COVERALLS_PARALLEL: true
228+
COVERALLS_FLAG_NAME: php-${{ matrix.php-versions }}
229+
run: vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml --json_path=build/logs/coveralls-upload.json -v
227230
finish-coverage:
228231
needs: phpunit-mysql
229232
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)