fix: Correct TypeScript types and PHP formatting for signature_text policy

- Fix useSignatureTextPolicy.ts accessing .effectiveValue instead of non-existent .value
- Simplify useSignatureTextPolicy return type annotation using ComputedRef
- Fix model.ts serializeSignatureTextPolicyConfig to return JSON string
- Fix model.ts normalizeSignatureTextPolicyConfig to handle JSON string inputs
- Fix SignatureTextRuleEditor.vue Emits type to use EffectivePolicyValue
- Remove trailing newline from SignatureTextPolicy.php

Fixes: TypeScript type checking and PHP-CS formatting failures in PR #7518
Tests: npm run ts:check passes, php-cs formatting validated

Author: vitormattos

lib/Service/Policy/Provider/SignatureText/SignatureTextPolicy.php

@@ -107,5 +107,4 @@ private function normalizePolicyKey(string|\BackedEnum $policyKey): string {
 
 		return $policyKey;
 	}
-}
-
+}

src/views/Settings/PolicyWorkbench/settings/signature-text/SignatureTextRuleEditor.vue

@@ -92,7 +92,7 @@ interface Props {
 }
 
 interface Emits {
-	(e: 'update:value', value: Record<string, unknown>): void
+	(e: 'update:value', value: EffectivePolicyValue): void
 }
 
 const props = defineProps<Props>()

src/views/Settings/PolicyWorkbench/settings/signature-text/model.ts

@@ -23,20 +23,32 @@ export function getDefaultSignatureTextPolicyConfig(): SignatureTextPolicyConfig
 	}
 }
 
-export function serializeSignatureTextPolicyConfig(config: Partial<SignatureTextPolicyConfig>): Record<string, unknown> {
-	return {
+export function serializeSignatureTextPolicyConfig(config: Partial<SignatureTextPolicyConfig>): string {
+	return JSON.stringify({
 		template: config.template ?? '',
 		template_font_size: config.templateFontSize ?? 9.0,
 		signature_font_size: config.signatureFontSize ?? 9.0,
 		signature_width: config.signatureWidth ?? 90.0,
 		signature_height: config.signatureHeight ?? 60.0,
 		render_mode: config.renderMode ?? 'default',
-	}
+	})
 }
 
 export function normalizeSignatureTextPolicyConfig(rawValue: unknown): SignatureTextPolicyConfig {
-	if (typeof rawValue === 'object' && rawValue !== null) {
-		const obj = rawValue as Record<string, unknown>
+	let obj: Record<string, unknown> | null = null
+
+	// Parse JSON string if needed
+	if (typeof rawValue === 'string') {
+		try {
+			obj = JSON.parse(rawValue) as Record<string, unknown>
+		} catch {
+			return getDefaultSignatureTextPolicyConfig()
+		}
+	} else if (typeof rawValue === 'object' && rawValue !== null) {
+		obj = rawValue as Record<string, unknown>
+	}
+
+	if (obj) {
 		return {
 			template: String(obj.template ?? obj.signature_text_template ?? '').trim(),
 			templateFontSize: Number(obj.template_font_size ?? obj.templateFontSize ?? 9.0),

src/views/Settings/PolicyWorkbench/settings/signature-text/useSignatureTextPolicy.ts

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { computed } from 'vue'
+import { computed, type ComputedRef } from 'vue'
 import { loadState } from '@nextcloud/initial-state'
 import { usePoliciesStore } from '../../../../../store/policies'
 
@@ -28,7 +28,7 @@ interface SignatureTextValues {
 	parsed: string
 }
 
-export function useSignatureTextPolicy(): { values: ReturnType<typeof computed<SignatureTextValues>> } {
+export function useSignatureTextPolicy(): { values: ComputedRef<SignatureTextValues> } {
 	const policiesStore = usePoliciesStore()
 
 	const values = computed<SignatureTextValues>(() => {
@@ -37,10 +37,10 @@ export function useSignatureTextPolicy(): { values: ReturnType<typeof computed<S
 		// Always use policy value; fallback to defaults if not defined
 		let policyValue = SIGNATURE_TEXT_DEFAULTS
 
-		if (signatureTextPolicy?.value) {
-			const decoded = typeof signatureTextPolicy.value === 'string'
-				? JSON.parse(signatureTextPolicy.value)
-				: signatureTextPolicy.value
+		if (signatureTextPolicy?.effectiveValue) {
+			const decoded = typeof signatureTextPolicy.effectiveValue === 'string'
+				? JSON.parse(signatureTextPolicy.effectiveValue)
+				: signatureTextPolicy.effectiveValue
 
 			policyValue = {
 				template: String(decoded.template ?? SIGNATURE_TEXT_DEFAULTS.template),