fix: cascade delete signer to identify_method

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Db/IdentifyMethodMapper.php

@@ -74,6 +74,16 @@ public function neutralizeDeletedUser(string $userId, string $displayName): void
 		}
 	}
 
+	public function deleteBySignRequestId(int $signRequestId): void {
+		$qb = $this->db->getQueryBuilder();
+		$qb->delete('libresign_identify_method')
+			->where(
+				$qb->expr()->eq('sign_request_id', $qb->createNamedParameter($signRequestId, IQueryBuilder::PARAM_INT))
+			)
+			->executeStatement();
+		unset($this->methodsBySignRequest[$signRequestId]);
+	}
+
 	/**
 	 * @return array<string, string>[]
 	 */

lib/Service/FileService.php

@@ -809,6 +809,7 @@ public function delete(int $fileId): void {
 		$this->fileElementService->deleteVisibleElements($file->getId());
 		$list = $this->signRequestMapper->getByFileId($file->getId());
 		foreach ($list as $signRequest) {
+			$this->identifyMethodService->deleteBySignRequestId($signRequest->getId());
 			$this->signRequestMapper->delete($signRequest);
 		}
 		$this->idDocsMapper->deleteByFileId($file->getId());

lib/Service/IdentifyMethodService.php

@@ -220,6 +220,11 @@ public function getIdentifiedMethod(int $signRequestId): IIdentifyMethod {
 		throw new LibresignException($this->l10n->t('Invalid identification method'), 1);
 	}
 
+	public function deleteBySignRequestId(int $signRequestId): void {
+		$this->identifyMethodMapper->deleteBySignRequestId($signRequestId);
+		$this->clearCache();
+	}
+
 	public function getSignMethodsOfIdentifiedFactors(int $signRequestId): array {
 		$matrix = $this->getIdentifyMethodsFromSignRequestId($signRequestId);
 		$return = [];

lib/Service/RequestSignatureService.php

@@ -545,11 +545,7 @@ public function unassociateToUser(int $fileId, int $signRequestId): void {
 
 		try {
 			$this->signRequestMapper->delete($signRequest);
-			foreach ($groupedIdentifyMethods as $identifyMethods) {
-				foreach ($identifyMethods as $identifyMethod) {
-					$this->identifyMethodMapper->delete($identifyMethod->getEntity());
-				}
-			}
+			$this->identifyMethod->deleteBySignRequestId($signRequestId);
 			$visibleElements = $this->fileElementMapper->getByFileIdAndSignRequestId($file->getId(), $signRequestId);
 			foreach ($visibleElements as $visibleElement) {
 				$this->fileElementMapper->delete($visibleElement);
@@ -630,6 +626,7 @@ public function deleteRequestSignature(array $data): void {
 			throw new \Exception($this->l10n->t('Please provide either UUID or File object'));
 		}
 		foreach ($signatures as $signRequest) {
+			$this->identifyMethod->deleteBySignRequestId($signRequest->getId());
 			$this->signRequestMapper->delete($signRequest);
 		}
 		$this->fileMapper->delete($fileData);

tests/php/Unit/TestCase.php

@@ -180,6 +180,7 @@ private function cleanDatabase(): void {
 
 		$delete = $db->getQueryBuilder();
 		$delete->delete('libresign_file')->executeStatement();
+		$delete->delete('libresign_identify_method')->executeStatement();
 		$delete->delete('libresign_sign_request')->executeStatement();
 		$delete->delete('libresign_user_element')->executeStatement();
 		$delete->delete('libresign_file_element')->executeStatement();