test(policy): route collect_metadata unit assertions through PolicyService

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

tests/php/Unit/Service/SignFileServiceTest.php

@@ -48,6 +48,8 @@
 use OCA\Libresign\Service\IdentifyMethodService;
 use OCA\Libresign\Service\PdfSignatureDetectionService;
 use OCA\Libresign\Service\PfxProvider;
+use OCA\Libresign\Service\Policy\Model\ResolvedPolicy;
+use OCA\Libresign\Service\Policy\PolicyService;
 use OCA\Libresign\Service\SignerElementsService;
 use OCA\Libresign\Service\SignFileService;
 use OCA\Libresign\Service\SigningCoordinatorService;
@@ -121,6 +123,7 @@ final class SignFileServiceTest extends \OCA\Libresign\Tests\Unit\TestCase {
 	private PfxProvider $pfxProvider;
 	private SubjectAlternativeNameService&MockObject $subjectAlternativeNameService;
 	private SignRequestService&MockObject $signRequestService;
+	private PolicyService&MockObject $policyService;
 
 	public function setUp(): void {
 		parent::setUp();
@@ -172,6 +175,7 @@ public function setUp(): void {
 			$this->secureRandom,
 		);
 		$this->signRequestService = $this->createMock(SignRequestService::class);
+		$this->policyService = $this->createMock(PolicyService::class);
 	}
 
 	public function testClickToSignUsesShortLivedCertificate(): void {
@@ -472,6 +476,7 @@ private function getService(array $methods = []): SignFileService|MockObject {
 					$this->pfxProvider,
 					$this->subjectAlternativeNameService,
 					$this->signRequestService,
+					$this->policyService,
 				])
 				->onlyMethods($methods)
 				->getMock();
@@ -516,6 +521,7 @@ private function getService(array $methods = []): SignFileService|MockObject {
 			$this->pfxProvider,
 			$this->subjectAlternativeNameService,
 			$this->signRequestService,
+			$this->policyService,
 		);
 	}
 
@@ -1144,7 +1150,13 @@ public function testGetSignRequestsToSignWhenFileHasParentEnvelope(): void {
 	#[DataProvider('providerStoreUserMetadata')]
 	public function testStoreUserMetadata(bool $collectMetadata, ?array $previous, array $new, ?array $expected): void {
 		$signRequest = new \OCA\Libresign\Db\SignRequest();
-		$this->appConfig->setValueBool('libresign', 'collect_metadata', $collectMetadata);
+		$this->policyService
+			->expects($this->any())
+			->method('resolve')
+			->willReturn(
+				(new ResolvedPolicy())
+					->setEffectiveValue($collectMetadata)
+			);
 		$signRequest->setMetadata($previous);
 		$this->getService()
 			->setSignRequest($signRequest)