Skip to content

Commit 733da55

Browse files
committed
fix: only set signer as me when identifier matches current user
Remove owner-based shortcut that marked all signers as me for the file owner, and rely solely on identifier matching (identifyMethodId, UID, or email). Signed-off-by: Vitor Mattos <[email protected]>
1 parent 4eb5818 commit 733da55

1 file changed

Lines changed: 9 additions & 16 deletions

File tree

lib/Service/File/SignersLoader.php

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ public function loadLibreSignSigners(
6464
if (!empty($found)) {
6565
$index = key($found);
6666
} else {
67-
// Find next available index
6867
$index = count($fileData->signers);
6968
}
7069
} else {
@@ -144,21 +143,15 @@ public function loadLibreSignSigners(
144143
if ($options->getMe() || $options->getIdentifyMethodId()) {
145144
$currentUserData = new stdClass();
146145
$currentUserData->me = false;
147-
if ($options->getMe()?->getUID() === $file->getUserId()) {
148-
$currentUserData->me = true;
149-
}
150-
if (!$currentUserData->me) {
151-
foreach ($identifyMethods as $methods) {
152-
foreach ($methods as $identifyMethod) {
153-
$entity = $identifyMethod->getEntity();
154-
if (!$currentUserData->me) {
155-
if ($options->getIdentifyMethodId() === $entity->getId()
156-
|| $options->getMe()?->getUID() === $entity->getIdentifierValue()
157-
|| $options->getMe()?->getEMailAddress() === $entity->getIdentifierValue()
158-
) {
159-
$currentUserData->me = true;
160-
}
161-
}
146+
foreach ($identifyMethods as $methods) {
147+
foreach ($methods as $identifyMethod) {
148+
$entity = $identifyMethod->getEntity();
149+
if ($options->getIdentifyMethodId() === $entity->getId()
150+
|| $options->getMe()?->getUID() === $entity->getIdentifierValue()
151+
|| $options->getMe()?->getEMailAddress() === $entity->getIdentifierValue()
152+
) {
153+
$currentUserData->me = true;
154+
break 2;
162155
}
163156
}
164157
}

0 commit comments

Comments
 (0)