refactor: translate signature validation messages via l10n

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Service/Signature/PdfSignatureValidationService.php

@@ -14,6 +14,7 @@
 use LibreSign\PdfSignatureValidator\Model\ValidationState;
 use OCA\Libresign\AppInfo\Application;
 use OCP\IAppConfig;
+use OCP\IL10N;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -29,6 +30,7 @@ class PdfSignatureValidationService {
 
 	public function __construct(
 		private IAppConfig $appConfig,
+		private IL10N $l10n,
 		private LoggerInterface $logger,
 	) {
 		$this->validator = new PdfSignatureValidator();
@@ -158,31 +160,31 @@ private function mapSignatureValidation(ValidationResult $result): array {
 		return match ($result->state) {
 			ValidationState::SIGNATURE_VALID => [
 				'id' => 1,
-				'label' => 'Signature is valid.',
+				'label' => $this->l10n->t('Signature is valid.'),
 				'isValid' => true,
 			],
 			ValidationState::SIGNATURE_INVALID => [
 				'id' => 2,
-				'label' => 'Signature is invalid.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Signature is invalid.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			ValidationState::DIGEST_MISMATCH => [
 				'id' => 3,
-				'label' => 'Digest mismatch.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Digest mismatch.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			ValidationState::NOT_VERIFIED => [
 				'id' => 5,
-				'label' => 'Signature has not yet been verified.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Signature has not yet been verified.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			default => [
 				'id' => 6,
-				'label' => 'Unknown validation failure.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Unknown validation failure.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 		};
@@ -195,48 +197,56 @@ private function mapCertificateValidation(ValidationResult $result): array {
 		return match ($result->state) {
 			ValidationState::CERT_TRUSTED => [
 				'id' => 1,
-				'label' => 'Certificate is trusted.',
+				'label' => $this->l10n->t('Certificate is trusted.'),
 				'isValid' => true,
 			],
 			ValidationState::CERT_ISSUER_NOT_TRUSTED => [
 				'id' => 2,
-				'label' => "Certificate issuer isn't trusted.",
-				'reason' => $result->reason,
+				'label' => $this->l10n->t("Certificate issuer isn't trusted."),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			ValidationState::CERT_ISSUER_UNKNOWN => [
 				'id' => 3,
-				'label' => 'Certificate issuer is unknown.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Certificate issuer is unknown.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			ValidationState::CERT_REVOKED => [
 				'id' => 4,
-				'label' => 'Certificate has been revoked.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Certificate has been revoked.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			ValidationState::CERT_EXPIRED => [
 				'id' => 5,
-				'label' => 'Certificate has expired.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Certificate has expired.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			ValidationState::CERT_NOT_VERIFIED => [
 				'id' => 6,
-				'label' => 'Certificate has not yet been verified.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Certificate has not yet been verified.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 			default => [
 				'id' => 7,
-				'label' => 'Unknown issue with certificate or corrupted data.',
-				'reason' => $result->reason,
+				'label' => $this->l10n->t('Unknown issue with certificate or corrupted data.'),
+				'reason' => $this->translateReason($result->reason),
 				'isValid' => false,
 			],
 		};
 	}
 
+	private function translateReason(?string $reason): ?string {
+		if ($reason === null || $reason === '') {
+			return $reason;
+		}
+
+		return $this->l10n->t($reason);
+	}
+
 	/**
 	 * Check if LibreSign CA is loaded.
 	 */

tests/php/Unit/Service/Signature/PdfSignatureValidationServiceTest.php

@@ -12,8 +12,20 @@
 use LibreSign\PdfSignatureValidator\Model\ValidationState;
 use OCA\Libresign\Service\Signature\PdfSignatureValidationService;
 use OCA\Libresign\Tests\Unit\TestCase;
+use OCP\IL10N;
+use PHPUnit\Framework\MockObject\MockObject;
 
 final class PdfSignatureValidationServiceTest extends TestCase {
+	private IL10N&MockObject $l10n;
+
+	public function setUp(): void {
+		parent::setUp();
+		$this->l10n = $this->createMock(IL10N::class);
+		$this->l10n
+			->method('t')
+			->willReturnCallback(static fn (string $text): string => $text);
+	}
+
 	public function testMapSignatureValidationWithEnumState(): void {
 		$service = $this->newServiceWithoutConstructor();
 		$result = $this->invokePrivateMethod(
@@ -45,6 +57,11 @@ private function newServiceWithoutConstructor(): PdfSignatureValidationService {
 		$reflection = new \ReflectionClass(PdfSignatureValidationService::class);
 		/** @var PdfSignatureValidationService $service */
 		$service = $reflection->newInstanceWithoutConstructor();
+
+		$l10nProperty = $reflection->getProperty('l10n');
+		$l10nProperty->setAccessible(true);
+		$l10nProperty->setValue($service, $this->l10n);
+
 		return $service;
 	}