refactor: extract cancellation event logic to dedicated method

Extracts the SignRequestCanceledEvent dispatching logic from
unassociateToUser into a dedicated dispatchCancellationEventIfNeeded
method for better code organization and single responsibility.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Service/RequestSignatureService.php

@@ -482,28 +482,11 @@ private function getSignRequestByIdentifyMethod(IIdentifyMethod $identifyMethod,
 	public function unassociateToUser(int $fileId, int $signRequestId): void {
 		$signRequest = $this->signRequestMapper->getByFileIdAndSignRequestId($fileId, $signRequestId);
 		$deletedOrder = $signRequest->getSigningOrder();
-
-		// Get identify methods before deletion
 		$groupedIdentifyMethods = $this->identifyMethod->getIdentifyMethodsFromSignRequestId($signRequestId);
 
-		// Dispatch canceled event if status is ABLE_TO_SIGN (1)
-		if ($signRequest->getStatus() === \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN->value) {
-			try {
-				$libreSignFile = $this->fileMapper->getByFileId($fileId);
-				foreach ($groupedIdentifyMethods as $identifyMethods) {
-					foreach ($identifyMethods as $identifyMethod) {
-						$event = new SignRequestCanceledEvent(
-							$signRequest,
-							$libreSignFile,
-							$identifyMethod,
-						);
-						$this->eventDispatcher->dispatchTyped($event);
-					}
-				}
-			} catch (\Throwable $e) {
-				$this->logger->error('Error dispatching SignRequestCanceledEvent: ' . $e->getMessage(), ['exception' => $e]);
-			}
-		}		try {
+		$this->dispatchCancellationEventIfNeeded($signRequest, $fileId, $groupedIdentifyMethods);
+
+		try {
 			$this->signRequestMapper->delete($signRequest);
 			foreach ($groupedIdentifyMethods as $identifyMethods) {
 				foreach ($identifyMethods as $identifyMethod) {
@@ -520,6 +503,32 @@ public function unassociateToUser(int $fileId, int $signRequestId): void {
 		}
 	}
 
+	private function dispatchCancellationEventIfNeeded(
+		SignRequestEntity $signRequest,
+		int $fileId,
+		array $groupedIdentifyMethods
+	): void {
+		if ($signRequest->getStatus() !== \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN->value) {
+			return;
+		}
+
+		try {
+			$libreSignFile = $this->fileMapper->getByFileId($fileId);
+			foreach ($groupedIdentifyMethods as $identifyMethods) {
+				foreach ($identifyMethods as $identifyMethod) {
+					$event = new SignRequestCanceledEvent(
+						$signRequest,
+						$libreSignFile,
+						$identifyMethod,
+					);
+					$this->eventDispatcher->dispatchTyped($event);
+				}
+			}
+		} catch (\Throwable $e) {
+			$this->logger->error('Error dispatching SignRequestCanceledEvent: ' . $e->getMessage(), ['exception' => $e]);
+		}
+	}
+
 	public function deleteRequestSignature(array $data): void {
 		if (!empty($data['uuid'])) {
 			$signatures = $this->signRequestMapper->getByFileUuid($data['uuid']);