feat: implement atomic envelope creation with rollback

Envelope creation now ensures atomicity:
- Generate envelope UUID and folderName before creating nodes
- Create nodes with correct settings containing folderName
- Rollback all changes (nodes, files, envelope) on any error

Added dedicated rollback methods:
- rollbackEnvelopeCreation: orchestrates complete rollback
- rollbackCreatedNodes: removes filesystem nodes
- rollbackCreatedFiles: removes file entities from database
- rollbackEnvelope: removes envelope entity from database

This prevents partial envelope creation and ensures data consistency.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Service/RequestSignatureService.php

@@ -79,28 +79,93 @@ public function saveEnvelope(array $data): array {
 		$userManager = $data['userManager'] ?? null;
 		$userId = $userManager instanceof IUser ? $userManager->getUID() : null;
 
-		$envelope = $this->envelopeService->createEnvelope($envelopeName, $userId);
+		$envelope = null;
+		$files = [];
+		$createdNodes = [];
 
-		$envelopeFolderName = 'envelope-' . $envelope->getUuid();
-		$envelopeSettings = array_merge($data['settings'] ?? [], [
-			'folderName' => $envelopeFolderName,
-		]);
+		try {
+			$envelope = $this->envelopeService->createEnvelope($envelopeName, $userId);
+
+			$envelopeFolderName = 'envelope-' . $envelope->getUuid();
+			$envelopeSettings = array_merge($data['settings'] ?? [], [
+				'folderName' => $envelopeFolderName,
+			]);
+
+			foreach ($data['files'] as $fileData) {
+				if (isset($fileData['uploadedFile'])) {
+					$node = $this->getNodeFromUploadedFile([
+						'userManager' => $userManager,
+						'name' => $fileData['name'],
+						'uploadedFile' => $fileData['uploadedFile'],
+						'settings' => $envelopeSettings,
+					]);
+					$fileData['node'] = $node;
+					$createdNodes[] = $node;
+				}
+				$fileEntity = $this->createFileForEnvelope(
+					$fileData,
+					$userManager,
+					$envelopeSettings
+				);
+				$this->envelopeService->addFileToEnvelope($envelope->getId(), $fileEntity);
+				$files[] = $fileEntity;
+			}
 
-		$files = [];
-		foreach ($data['files'] as $fileData) {
-			$fileEntity = $this->createFileForEnvelope(
-				$fileData,
-				$userManager,
-				$envelopeSettings
-			);
-			$this->envelopeService->addFileToEnvelope($envelope->getId(), $fileEntity);
-			$files[] = $fileEntity;
-		}
-
-		return [
-			'envelope' => $envelope,
-			'files' => $files,
-		];
+			return [
+				'envelope' => $envelope,
+				'files' => $files,
+			];
+		} catch (\Throwable $e) {
+			$this->rollbackEnvelopeCreation($envelope, $files, $createdNodes);
+			throw $e;
+		}
+	}
+
+	private function rollbackEnvelopeCreation(?FileEntity $envelope, array $files, array $createdNodes): void {
+		$this->rollbackCreatedNodes($createdNodes);
+		$this->rollbackCreatedFiles($files);
+		$this->rollbackEnvelope($envelope);
+	}
+
+	private function rollbackCreatedNodes(array $nodes): void {
+		foreach ($nodes as $node) {
+			try {
+				$node->delete();
+			} catch (\Throwable $deleteError) {
+				$this->logger->error('Failed to rollback created node in envelope', [
+					'nodeId' => $node->getId(),
+					'error' => $deleteError->getMessage(),
+				]);
+			}
+		}
+	}
+
+	private function rollbackCreatedFiles(array $files): void {
+		foreach ($files as $file) {
+			try {
+				$this->fileMapper->delete($file);
+			} catch (\Throwable $deleteError) {
+				$this->logger->error('Failed to rollback created file entity in envelope', [
+					'fileId' => $file->getId(),
+					'error' => $deleteError->getMessage(),
+				]);
+			}
+		}
+	}
+
+	private function rollbackEnvelope(?FileEntity $envelope): void {
+		if ($envelope === null) {
+			return;
+		}
+
+		try {
+			$this->fileMapper->delete($envelope);
+		} catch (\Throwable $deleteError) {
+			$this->logger->error('Failed to rollback created envelope', [
+				'envelopeId' => $envelope->getId(),
+				'error' => $deleteError->getMessage(),
+			]);
+		}
 	}
 
 	private function createFileForEnvelope(array $fileData, ?IUser $userManager, array $settings): FileEntity {
@@ -116,6 +181,7 @@ private function createFileForEnvelope(array $fileData, ?IUser $userManager, arr
 			'name' => $fileName,
 			'userManager' => $userManager,
 			'status' => FileEntity::STATUS_DRAFT,
+			'settings' => $settings,
 		]);
 	}