refactor(policy): remove footer legacy appconfig fallback

Consolidate add_footer runtime and persistence on PolicyService:
- remove footer_template fallback in FooterHandler
- persist template customization via PolicyService in FooterService
- stop using footer_template as FooterPolicy baseline
- remove initial-state dependency for footer_template_is_default in Validation view
- update FooterServiceTest for policy-first flow

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Handler/FooterHandler.php

@@ -209,11 +209,6 @@ public function getTemplate(): string {
 				return $policyTemplate;
 			}
 		}
-
-		$footerTemplate = $this->appConfig->getValueString(Application::APP_ID, 'footer_template', '');
-		if ($footerTemplate) {
-			return $footerTemplate;
-		}
 		return $this->getDefaultTemplate();
 	}
 

lib/Service/FooterService.php

@@ -8,25 +8,19 @@
 
 namespace OCA\Libresign\Service;
 
-use OCA\Libresign\AppInfo\Application;
 use OCA\Libresign\Handler\FooterHandler;
+use OCA\Libresign\Service\Policy\PolicyService;
 use OCA\Libresign\Service\Policy\Provider\Footer\FooterPolicy;
 use OCA\Libresign\Service\Policy\Provider\Footer\FooterPolicyValue;
-use OCP\IAppConfig;
 
 class FooterService {
 	public function __construct(
-		private IAppConfig $appConfig,
+		private PolicyService $policyService,
 		private FooterHandler $footerHandler,
 	) {
 	}
 
 	public function isDefaultTemplate(): bool {
-		$legacyCustomTemplate = $this->appConfig->getValueString(Application::APP_ID, 'footer_template', '');
-		if ($legacyCustomTemplate !== '') {
-			return false;
-		}
-
 		$footerPolicy = $this->getEffectiveFooterPolicy();
 		return !$footerPolicy['customizeFooterTemplate'];
 	}
@@ -40,38 +34,31 @@ public function saveTemplate(string $template = ''): void {
 		$defaultTemplateFromPolicy = $currentPolicy['footerTemplate'];
 
 		if (empty($template)) {
-			$this->appConfig->deleteKey(Application::APP_ID, 'footer_template');
 			$this->syncFooterPolicyTemplate('', false);
 			return;
 		}
 
 		$isProvidedTemplateEqualsDefault = $template === $defaultTemplateFromPolicy;
 
 		if ($isProvidedTemplateEqualsDefault) {
-			$this->appConfig->deleteKey(Application::APP_ID, 'footer_template');
 			$this->syncFooterPolicyTemplate('', false);
 		} else {
-			$this->appConfig->setValueString(Application::APP_ID, 'footer_template', $template);
 			$this->syncFooterPolicyTemplate($template, true);
 		}
 	}
 
 	private function syncFooterPolicyTemplate(string $template, bool $customizeFooterTemplate): void {
 		$currentPolicy = $this->getEffectiveFooterPolicy();
-		$defaultTemplate = $currentPolicy['footerTemplate'];
-
-		$normalizedPolicy = FooterPolicyValue::normalize(
-			$this->appConfig->getValueString(Application::APP_ID, FooterPolicy::KEY, ''),
-			$defaultTemplate
-		);
+		$normalizedPolicy = FooterPolicyValue::normalize($currentPolicy);
 
 		$normalizedPolicy['customizeFooterTemplate'] = $customizeFooterTemplate;
 		$normalizedPolicy['footerTemplate'] = $customizeFooterTemplate ? $template : '';
 
-		$this->appConfig->setValueString(
-			Application::APP_ID,
+		$allowChildOverride = $this->policyService->getSystemPolicy(FooterPolicy::KEY)?->isAllowChildOverride() ?? false;
+		$this->policyService->saveSystem(
 			FooterPolicy::KEY,
-			FooterPolicyValue::encode($normalizedPolicy)
+			FooterPolicyValue::encode($normalizedPolicy),
+			$allowChildOverride,
 		);
 	}
 

lib/Service/Policy/Provider/Footer/FooterPolicy.php

@@ -8,22 +8,15 @@
 
 namespace OCA\Libresign\Service\Policy\Provider\Footer;
 
-use OCA\Libresign\AppInfo\Application;
 use OCA\Libresign\Service\Policy\Contract\IPolicyDefinition;
 use OCA\Libresign\Service\Policy\Contract\IPolicyDefinitionProvider;
 use OCA\Libresign\Service\Policy\Model\PolicyContext;
 use OCA\Libresign\Service\Policy\Model\PolicySpec;
-use OCP\IAppConfig;
 
 final class FooterPolicy implements IPolicyDefinitionProvider {
 	public const KEY = 'add_footer';
 	public const SYSTEM_APP_CONFIG_KEY = 'add_footer';
 
-	public function __construct(
-		private ?IAppConfig $appConfig = null,
-	) {
-	}
-
 	#[\Override]
 	public function keys(): array {
 		return [
@@ -81,15 +74,6 @@ private static function canManageTechnicalFooterSettings(PolicyContext $context)
 	}
 
 	private function resolveInstanceBaseTemplate(): string {
-		if ($this->appConfig === null) {
-			return '';
-		}
-
-		$templateFromConfig = $this->appConfig->getValueString(Application::APP_ID, 'footer_template', '');
-		if ($templateFromConfig !== '') {
-			return $templateFromConfig;
-		}
-
 		$defaultTemplatePath = __DIR__ . '/../../../../Handler/Templates/footer.twig';
 		$defaultTemplate = @file_get_contents($defaultTemplatePath);
 

src/views/Settings/Validation.vue

@@ -53,7 +53,6 @@
 </template>
 <script setup lang="ts">
 import axios from '@nextcloud/axios'
-import { loadState } from '@nextcloud/initial-state'
 import { generateOcsUrl } from '@nextcloud/router'
 import { t } from '@nextcloud/l10n'
 import { onMounted, ref } from 'vue'
@@ -92,15 +91,13 @@ defineOptions({
 	name: 'Validation',
 })
 
-const isDefaultFooterTemplateState = loadState('libresign', 'footer_template_is_default', true)
-
 const paternValidadeUrl = ref('https://validador.librecode.coop/')
 const makeValidationUrlPrivate = ref(false)
 const url = ref<string | null>(null)
 const addFooter = ref(true)
 const writeQrcodeOnFooter = ref(true)
-const isDefaultFooterTemplate = ref(isDefaultFooterTemplateState)
-const customizeFooter = ref(!isDefaultFooterTemplateState)
+const isDefaultFooterTemplate = ref(true)
+const customizeFooter = ref(false)
 const policiesStore = usePoliciesStore()
 
 const urlInput = ref<HTMLInputElement | null>(null)