fix: sync IAppConfig cache when CA ID is empty

When getCaId() finds an empty CA ID in cache, it now calls
clearCache(true) to reload from database before generating a new one.
This prevents race conditions in test environments where CLI commands
and HTTP requests may execute simultaneously with independent caches.

The solution is simpler than using file locks and works transparently
in both test and production environments with minimal overhead.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Handler/CertificateEngine/AEngineHandler.php

@@ -143,47 +143,10 @@ public function readCertificate(string $certificate, string $privateKey): array
 	public function getCaId(): string {
 		$caId = $this->caIdentifierService->getCaId();
 		if (empty($caId)) {
-			// In debug mode (tests), use file lock and cache clear to prevent race conditions
-			// between CLI commands and HTTP requests executing simultaneously.
-			// In production, this is not needed as setup commands run before HTTP requests.
-			if ($this->config->getSystemValueBool('debug', false)) {
-				$caId = $this->getCaIdWithLock();
-			} else {
-				$caId = $this->caIdentifierService->generateCaId($this->getName());
-			}
-		}
-		return $caId;
-	}
-
-	private function getCaIdWithLock(): string {
-		$lockFilePath = $this->tempManager->getTempBaseDir() . '/libresign_ca_id.lock';
-		$lockFile = fopen($lockFilePath, 'c+');
-		if ($lockFile === false) {
-			throw new \RuntimeException('Failed to open lock file');
-		}
-		
-		try {
-			// Acquire exclusive lock (blocks until available)
-			if (!flock($lockFile, LOCK_EX)) {
-				throw new \RuntimeException('Failed to acquire lock');
-			}
-
-			// Clear IAppConfig cache and reload from database
-			// This is critical because IAppConfig cache is per-process
 			$this->appConfig->clearCache(true);
-
-			// Check again after cache refresh - another process might have created it
-			$caId = $this->caIdentifierService->getCaId();
-			if (empty($caId)) {
-				$caId = $this->caIdentifierService->generateCaId($this->getName());
-			}
-			
-			return $caId;
-		} finally {
-			// Release lock and close file
-			flock($lockFile, LOCK_UN);
-			fclose($lockFile);
+			$caId = $this->caIdentifierService->getCaId() ?: $this->caIdentifierService->generateCaId($this->getName());
 		}
+		return $caId;
 	}
 
 	#[\Override]