fix: migrate CRL admin state to effective policies

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Settings/Admin.php

@@ -83,7 +83,6 @@ public function getForm(): TemplateResponse {
 		$this->initialState->provideInitialState('signing_mode', $this->getSigningModeInitialState());
 		$this->initialState->provideInitialState('worker_type', $this->getWorkerTypeInitialState());
 		$this->initialState->provideInitialState('parallel_workers', $this->appConfig->getValueString(Application::APP_ID, 'parallel_workers', '4'));
-		$this->initialState->provideInitialState('crl_external_validation_enabled', $this->appConfig->getValueBool(Application::APP_ID, 'crl_external_validation_enabled', true));
 		$this->initialState->provideInitialState('ldap_extension_available', function_exists('ldap_connect'));
 
 		$response = new TemplateResponse(Application::APP_ID, 'admin_settings');

src/types/index.ts

@@ -134,10 +134,7 @@ export type AdminInitialState = {
 	signing_mode: SigningModeState
 	worker_type: WorkerTypeState
 	parallel_workers: string
-	show_confetti_after_signing: boolean
-	crl_external_validation_enabled: boolean
 	ldap_extension_available: boolean
-	envelope_enabled: boolean
 }
 
 export type RuntimeFileSettingsRecord = FileSettings & Partial<SettingsRecord>

tests/integration/features/admin/initial_state.feature

@@ -162,6 +162,7 @@ Feature: admin/initial_state
       | (jq)(.policies.approval_group.effectiveValue \| fromjson \| .[0]) | admin                           |
       | (jq).policies.envelope_enabled.effectiveValue               | true                                  |
       | (jq).policies.show_confetti_after_signing.effectiveValue    | true                                  |
+      | (jq).policies.crl_external_validation_enabled.effectiveValue | true                                 |
       | (jq).policies.tsa_settings.policyKey                                      | tsa_settings |
       | (jq).policies.tsa_settings.sourceScope                                    | system       |
       | (jq)(.policies.tsa_settings.effectiveValue \| fromjson).auth_type          | none         |
@@ -177,10 +178,6 @@ Feature: admin/initial_state
       """
       "4"
       """
-    And the response should contain the initial state "libresign-crl_external_validation_enabled" with the following values:
-      """
-      true
-      """
     And run the command "user:setting admin libresign files_list_sorting_mode --delete" with result code 0
     And run the command "user:setting admin libresign files_list_sorting_direction --delete" with result code 0
 
@@ -292,6 +289,7 @@ Feature: admin/initial_state
       | (jq)(.policies.approval_group.effectiveValue \| fromjson \| .[1]) | staff                           |
       | (jq).policies.envelope_enabled.effectiveValue               | false                                 |
       | (jq).policies.show_confetti_after_signing.effectiveValue    | false                                 |
+      | (jq).policies.crl_external_validation_enabled.effectiveValue | false                                |
       | (jq).policies.tsa_settings.policyKey                                      | tsa_settings                 |
       | (jq).policies.tsa_settings.sourceScope                                    | global                       |
       | (jq)(.policies.tsa_settings.effectiveValue \| fromjson).url                | https://tsa.example.test/tsr |
@@ -310,10 +308,6 @@ Feature: admin/initial_state
       """
       "9"
       """
-    And the response should contain the initial state "libresign-crl_external_validation_enabled" with the following values:
-      """
-      false
-      """
     And the following libresign app config is set
       | certificate_engine                | openssl                  |
       | certificate_policies_oid          |                          |