Skip to content

Commit 32bcdb3

Browse files
committed
fix: add pending code after code review
Signed-off-by: Vitor Mattos <[email protected]>
1 parent 0adc0b1 commit 32bcdb3

6 files changed

Lines changed: 44 additions & 3 deletions

File tree

lib/ResponseDefinitions.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
* email?: string,
2929
* account?: string,
3030
* },
31+
* signingOrder?: non-negative-int,
3132
* }
3233
* @psalm-type LibresignNewFile = array{
3334
* base64?: string,
@@ -172,6 +173,7 @@
172173
* hash_algorithm?: string,
173174
* me: bool,
174175
* signRequestId: non-negative-int,
176+
* signingOrder?: non-negative-int,
175177
* identifyMethods?: LibresignIdentifyMethod[],
176178
* visibleElements?: LibresignVisibleElement[],
177179
* signatureMethods?: LibresignSignatureMethods,

openapi-full.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,11 @@
513513
"type": "string"
514514
}
515515
}
516+
},
517+
"signingOrder": {
518+
"type": "integer",
519+
"format": "int64",
520+
"minimum": 0
516521
}
517522
}
518523
},
@@ -912,6 +917,11 @@
912917
"format": "int64",
913918
"minimum": 0
914919
},
920+
"signingOrder": {
921+
"type": "integer",
922+
"format": "int64",
923+
"minimum": 0
924+
},
915925
"identifyMethods": {
916926
"type": "array",
917927
"items": {

openapi.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,11 @@
443443
"type": "string"
444444
}
445445
}
446+
},
447+
"signingOrder": {
448+
"type": "integer",
449+
"format": "int64",
450+
"minimum": 0
446451
}
447452
}
448453
},
@@ -762,6 +767,11 @@
762767
"format": "int64",
763768
"minimum": 0
764769
},
770+
"signingOrder": {
771+
"type": "integer",
772+
"format": "int64",
773+
"minimum": 0
774+
},
765775
"identifyMethods": {
766776
"type": "array",
767777
"items": {

src/Components/RightSidebar/RequestSignatureTab.vue

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,20 @@
99
@click="addSigner">
1010
{{ t('libresign', 'Add signer') }}
1111
</NcButton>
12-
<Signers :signers="filesStore.signers"
13-
event="libresign:edit-signer">
14-
<template #actions="{signer}">
12+
<Signers event="libresign:edit-signer"
13+
@signing-order-changed="debouncedSave">
14+
<template #actions="{signer, closeActions}">
15+
<NcActionInput v-if="isOrderedNumeric && totalSigners > 1 && filesStore.canSave() && !signer.signed"
16+
:label="t('libresign', 'Signing order')"
17+
type="number"
18+
:value="signer.signingOrder || 1"
19+
@update:value="updateSigningOrder(signer, $event)"
20+
@submit="confirmSigningOrder(signer); closeActions()"
21+
@blur="confirmSigningOrder(signer)">
22+
<template #icon>
23+
<OrderNumericAscending :size="20" />
24+
</template>
25+
</NcActionInput>
1526
<NcActionButton v-if="filesStore.canSave() && !signer.signed"
1627
aria-label="Delete"
1728
:close-after-click="true"

src/types/openapi/openapi-full.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1603,6 +1603,8 @@ export type components = {
16031603
email?: string;
16041604
account?: string;
16051605
};
1606+
/** Format: int64 */
1607+
signingOrder?: number;
16061608
};
16071609
NextcloudFile: {
16081610
message: string;
@@ -1713,6 +1715,8 @@ export type components = {
17131715
me: boolean;
17141716
/** Format: int64 */
17151717
signRequestId: number;
1718+
/** Format: int64 */
1719+
signingOrder?: number;
17161720
identifyMethods?: components["schemas"]["IdentifyMethod"][];
17171721
visibleElements?: components["schemas"]["VisibleElement"][];
17181722
signatureMethods?: components["schemas"]["SignatureMethods"];

src/types/openapi/openapi.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1147,6 +1147,8 @@ export type components = {
11471147
email?: string;
11481148
account?: string;
11491149
};
1150+
/** Format: int64 */
1151+
signingOrder?: number;
11501152
};
11511153
NextcloudFile: {
11521154
message: string;
@@ -1235,6 +1237,8 @@ export type components = {
12351237
me: boolean;
12361238
/** Format: int64 */
12371239
signRequestId: number;
1240+
/** Format: int64 */
1241+
signingOrder?: number;
12381242
identifyMethods?: components["schemas"]["IdentifyMethod"][];
12391243
visibleElements?: components["schemas"]["VisibleElement"][];
12401244
signatureMethods?: components["schemas"]["SignatureMethods"];

0 commit comments

Comments
 (0)