refactor: remove redundant localize* methods

The service's validateFromResource() already returns properly formatted
arrays with id, label, isValid, and reason. The localize* methods were
unnecessarily converting numbers back to enums and then back to numbers.

Now Pkcs12Handler uses the validation results directly without the
circular conversion, eliminating code duplication and improving clarity.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Handler/SignEngine/Pkcs12Handler.php

@@ -301,11 +301,11 @@ private function enrichLeafWithNativeData(array $result, array $metadata, array
 		}
 
 		if (isset($validation['signatureValidation']) && is_array($validation['signatureValidation'])) {
-			$leaf['signature_validation'] = $this->pdfSignatureValidationService->localizeSignatureValidation($validation['signatureValidation']);
+			$leaf['signature_validation'] = $validation['signatureValidation'];
 		}
 
 		if (isset($validation['certificateValidation']) && is_array($validation['certificateValidation'])) {
-			$leaf['certificate_validation'] = $this->pdfSignatureValidationService->localizeCertificateValidation($validation['certificateValidation']);
+			$leaf['certificate_validation'] = $validation['certificateValidation'];
 		}
 
 		if (!isset($leaf['certificate_validation'])) {

lib/Service/Signature/PdfSignatureValidationService.php

@@ -69,48 +69,6 @@ public function setTrustedRoots(array $certificates): void {
 		$this->validator->setTrustedRoots($certificates);
 	}
 
-	/**
-	 * Normalize a signature validation payload by id/reason to the canonical LibreSign shape.
-	 *
-	 * @param array{id?: int|string, reason?: mixed} $validation
-	 */
-	public function localizeSignatureValidation(array $validation): array {
-		$id = (int)($validation['id'] ?? 6);
-		$reason = is_string($validation['reason'] ?? null) ? $validation['reason'] : null;
-
-		$state = match ($id) {
-			1 => ValidationState::SIGNATURE_VALID,
-			2 => ValidationState::SIGNATURE_INVALID,
-			3 => ValidationState::DIGEST_MISMATCH,
-			5 => ValidationState::NOT_VERIFIED,
-			default => ValidationState::NOT_VERIFIED,
-		};
-
-		return $this->mapSignatureValidation(new ValidationResult($state, $reason));
-	}
-
-	/**
-	 * Normalize a certificate validation payload by id/reason to the canonical LibreSign shape.
-	 *
-	 * @param array{id?: int|string, reason?: mixed} $validation
-	 */
-	public function localizeCertificateValidation(array $validation): array {
-		$id = (int)($validation['id'] ?? 7);
-		$reason = is_string($validation['reason'] ?? null) ? $validation['reason'] : null;
-
-		$state = match ($id) {
-			1 => ValidationState::CERT_TRUSTED,
-			2 => ValidationState::CERT_ISSUER_NOT_TRUSTED,
-			3 => ValidationState::CERT_ISSUER_UNKNOWN,
-			4 => ValidationState::CERT_REVOKED,
-			5 => ValidationState::CERT_EXPIRED,
-			6 => ValidationState::CERT_NOT_VERIFIED,
-			default => ValidationState::CERT_NOT_VERIFIED,
-		};
-
-		return $this->mapCertificateValidation(new ValidationResult($state, $reason));
-	}
-
 	/**
 	 * Validate PDF signatures from file resource.
 	 *