fix: Prioritize file status over signer status in parallel flow

When file status is ABLE_TO_SIGN (1) in parallel flow, all signers
should be set to ABLE_TO_SIGN regardless of individual signer status
sent by frontend. This fixes the issue where signers remained in DRAFT
status (0) even after clicking 'Request signatures'.

The logic now:
1. Check file status DRAFT first - keep all signers as DRAFT
2. Check file status ABLE_TO_SIGN - apply flow-based logic:
   - Parallel: All signers get ABLE_TO_SIGN
   - Ordered: Only first signer gets ABLE_TO_SIGN
3. Fallback to individual signer status for other cases

Resolves issue where sign_request records stayed at status 0 while
libresign_file was updated to status 1.

Signed-off-by: Vitor Mattos <[email protected]>

Author: vitormattos

lib/Service/RequestSignatureService.php

@@ -333,26 +333,13 @@ private function determineInitialStatus(
 		?\OCA\Libresign\Enum\SignRequestStatus $currentStatus = null,
 		?int $fileId = null,
 	): \OCA\Libresign\Enum\SignRequestStatus {
-		if ($signerStatus !== null) {
-			$desiredStatus = \OCA\Libresign\Enum\SignRequestStatus::from($signerStatus);
-			if ($currentStatus !== null && !$this->sequentialSigningService->isStatusUpgrade($currentStatus, $desiredStatus)) {
-				return $currentStatus;
-			}
-
-			// Validate status transition based on signing order
-			if ($fileId !== null) {
-				return $this->sequentialSigningService->validateStatusByOrder($desiredStatus, $signingOrder, $fileId);
-			}
-
-			return $desiredStatus;
-		}
-
 		// If fileStatus is explicitly DRAFT (0), keep signer as DRAFT
 		// This allows adding new signers in DRAFT mode even when file is not in DRAFT status
 		if ($fileStatus === FileEntity::STATUS_DRAFT) {
 			return \OCA\Libresign\Enum\SignRequestStatus::DRAFT;
 		}
 
+		// If file status is ABLE_TO_SIGN, apply flow-based logic
 		if ($fileStatus === FileEntity::STATUS_ABLE_TO_SIGN) {
 			if ($this->sequentialSigningService->isOrderedNumericFlow()) {
 				// In ordered flow, only first signer (order 1) should be ABLE_TO_SIGN
@@ -361,10 +348,26 @@ private function determineInitialStatus(
 					? \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN
 					: \OCA\Libresign\Enum\SignRequestStatus::DRAFT;
 			}
-			// In parallel flow, all can sign
+			// In parallel flow, all can sign - ignore individual signer status if file is ABLE_TO_SIGN
 			return \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN;
 		}
 
+		// Handle explicit signer status when file status is not DRAFT or ABLE_TO_SIGN
+		if ($signerStatus !== null) {
+			$desiredStatus = \OCA\Libresign\Enum\SignRequestStatus::from($signerStatus);
+			if ($currentStatus !== null && !$this->sequentialSigningService->isStatusUpgrade($currentStatus, $desiredStatus)) {
+				return $currentStatus;
+			}
+
+			// Validate status transition based on signing order
+			if ($fileId !== null) {
+				return $this->sequentialSigningService->validateStatusByOrder($desiredStatus, $signingOrder, $fileId);
+			}
+
+			return $desiredStatus;
+		}
+
+		// Default fallback based on flow type
 		if (!$this->sequentialSigningService->isOrderedNumericFlow()) {
 			return \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN;
 		}