Skip to content

Commit 0136847

Browse files
committed
test: fix unit tests to include SequentialSigningService mock
- Add SequentialSigningService mock in RequestSignatureServiceTest - Add SequentialSigningService mock in SignFileServiceTest - Update constructor calls in both test files to include new dependency Signed-off-by: Vitor Mattos <[email protected]>
1 parent a936114 commit 0136847

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

tests/php/Unit/Service/RequestSignatureServiceTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ final class RequestSignatureServiceTest extends \OCA\Libresign\Tests\Unit\TestCa
4646
private IClientService&MockObject $client;
4747
private DocMdpHandler&MockObject $docMdpHandler;
4848
private LoggerInterface&MockObject $loggerInterface;
49+
private \OCA\Libresign\Service\SequentialSigningService&MockObject $sequentialSigningService;
4950

5051
public function setUp(): void {
5152
parent::setUp();
@@ -70,6 +71,7 @@ public function setUp(): void {
7071
$this->client = $this->createMock(IClientService::class);
7172
$this->docMdpHandler = $this->createMock(DocMdpHandler::class);
7273
$this->loggerInterface = $this->createMock(LoggerInterface::class);
74+
$this->sequentialSigningService = $this->createMock(\OCA\Libresign\Service\SequentialSigningService::class);
7375
}
7476

7577
private function getService(): RequestSignatureService {
@@ -88,7 +90,8 @@ private function getService(): RequestSignatureService {
8890
$this->validateHelper,
8991
$this->client,
9092
$this->docMdpHandler,
91-
$this->loggerInterface
93+
$this->loggerInterface,
94+
$this->sequentialSigningService
9295
);
9396
}
9497

tests/php/Unit/Service/SignFileServiceTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ final class SignFileServiceTest extends \OCA\Libresign\Tests\Unit\TestCase {
9191
private Pdf&MockObject $pdf;
9292
private DocMdpHandler $docMdpHandler;
9393
private PdfSignatureDetectionService&MockObject $pdfSignatureDetectionService;
94+
private \OCA\Libresign\Service\SequentialSigningService&MockObject $sequentialSigningService;
9495

9596
public function setUp(): void {
9697
parent::setUp();
@@ -127,6 +128,7 @@ public function setUp(): void {
127128
$this->pdf = $this->createMock(Pdf::class);
128129
$this->docMdpHandler = new DocMdpHandler($this->l10n);
129130
$this->pdfSignatureDetectionService = $this->createMock(PdfSignatureDetectionService::class);
131+
$this->sequentialSigningService = $this->createMock(\OCA\Libresign\Service\SequentialSigningService::class);
130132
}
131133

132134
private function getService(array $methods = []): SignFileService|MockObject {
@@ -162,6 +164,7 @@ private function getService(array $methods = []): SignFileService|MockObject {
162164
$this->pdf,
163165
$this->docMdpHandler,
164166
$this->pdfSignatureDetectionService,
167+
$this->sequentialSigningService,
165168
])
166169
->onlyMethods($methods)
167170
->getMock();
@@ -196,6 +199,7 @@ private function getService(array $methods = []): SignFileService|MockObject {
196199
$this->pdf,
197200
$this->docMdpHandler,
198201
$this->pdfSignatureDetectionService,
202+
$this->sequentialSigningService,
199203
);
200204
}
201205

0 commit comments

Comments
 (0)