-
-
Notifications
You must be signed in to change notification settings - Fork 111
Expand file tree
/
Copy pathSigners.spec.ts
More file actions
368 lines (307 loc) · 9.36 KB
/
Signers.spec.ts
File metadata and controls
368 lines (307 loc) · 9.36 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
/**
* SPDX-FileCopyrightText: 2026 LibreCode coop and contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
import { shallowMount } from '@vue/test-utils'
import type { VueWrapper } from '@vue/test-utils'
import { createPinia, setActivePinia } from 'pinia'
import type { Pinia } from 'pinia'
type SignersComponent = typeof import('../../../components/Signers/Signers.vue').default
let Signers: SignersComponent
import { useFilesStore } from '../../../store/files.js'
vi.mock('@nextcloud/initial-state', () => ({
loadState: vi.fn(),
}))
beforeAll(async () => {
;({ default: Signers } = await import('../../../components/Signers/Signers.vue'))
})
describe('Signers', () => {
let wrapper: VueWrapper<unknown> | null
let filesStore: ReturnType<typeof useFilesStore>
let pinia: Pinia
const createWrapper = (props: Partial<{ event: string }> = {}) => {
return shallowMount(Signers, {
props: {
event: '',
...props,
},
global: {
plugins: [pinia],
stubs: {
Signer: true,
// Stub for vuedraggable 4 (Vue 3) which uses #item slot per element
draggable: {
name: 'draggable',
template: `
<div>
<template v-for="(element, index) in modelValue" :key="index">
<slot name="item" :element="element" :index="index" />
</template>
</div>
`,
props: ['modelValue', 'itemKey', 'tag', 'handle', 'class', 'chosenClass', 'dragClass'],
},
},
},
})
}
beforeEach(() => {
pinia = createPinia()
setActivePinia(pinia)
filesStore = useFilesStore()
filesStore.selectedFile = { signers: [] }
filesStore.getFile = () => filesStore.selectedFile
filesStore.canSave = vi.fn(() => true)
if (wrapper) {
wrapper.unmount()
wrapper = null
}
vi.clearAllMocks()
})
describe('RULE: signers returns signers from file store', () => {
it('returns signers array from selected file', () => {
filesStore.selectedFile = {
signers: [
{ id: 1, displayName: 'Alice' },
{ id: 2, displayName: 'Bob' },
],
}
wrapper = createWrapper()
expect(wrapper.vm.signers).toEqual([
{ id: 1, displayName: 'Alice' },
{ id: 2, displayName: 'Bob' },
])
})
it('returns undefined when no file selected', () => {
filesStore.selectedFile = {}
wrapper = createWrapper()
expect(wrapper.vm.signers).toBeUndefined()
})
})
describe('RULE: sortableSigners getter and setter modify file signers', () => {
it('getter returns signers', () => {
filesStore.selectedFile = {
signers: [{ id: 1 }],
}
wrapper = createWrapper()
expect(wrapper.vm.sortableSigners).toEqual([{ id: 1 }])
})
it('setter updates file signers', async () => {
filesStore.selectedFile = {
signers: [{ id: 1 }],
}
wrapper = createWrapper()
wrapper.vm.sortableSigners = [{ id: 2 }, { id: 3 }]
expect(filesStore.selectedFile.signers).toEqual([{ id: 2 }, { id: 3 }])
})
})
describe('RULE: isOrderedNumeric checks if signatureFlow is ordered_numeric', () => {
it('returns true for ordered_numeric string', () => {
filesStore.selectedFile = {
signatureFlow: 'ordered_numeric',
signers: [],
}
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(true)
})
it('returns false for parallel string', () => {
filesStore.selectedFile = {
signatureFlow: 'parallel',
signers: [],
}
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(false)
})
it('returns true for numeric value 2', () => {
filesStore.selectedFile = {
signatureFlow: 2,
signers: [],
}
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(true)
})
it('returns false for numeric value 1 (parallel)', () => {
filesStore.selectedFile = {
signatureFlow: 1,
signers: [],
}
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(false)
})
it('returns false for numeric value 0 (none)', () => {
filesStore.selectedFile = {
signatureFlow: 0,
signers: [],
}
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(false)
})
it('returns false when signatureFlow undefined', () => {
filesStore.selectedFile = {
signers: [],
}
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(false)
})
})
describe('RULE: canReorder requires canSave and multiple signers', () => {
it('returns true when can save and has multiple signers', () => {
filesStore.selectedFile = {
signers: [{}, {}],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
expect(wrapper.vm.canReorder).toBe(true)
})
it('returns false when cannot save', () => {
filesStore.selectedFile = {
signers: [{}, {}],
}
filesStore.canSave = vi.fn().mockReturnValue(false)
wrapper = createWrapper()
expect(wrapper.vm.canReorder).toBe(false)
})
it('returns false with single signer', () => {
filesStore.selectedFile = {
signers: [{}],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
expect(wrapper.vm.canReorder).toBe(false)
})
it('returns false with no signers', () => {
filesStore.selectedFile = {
signers: [],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
expect(wrapper.vm.canReorder).toBe(false)
})
})
describe('RULE: onDragEnd recalculates signing orders sequentially', () => {
it('updates signing orders starting from 1', () => {
filesStore.selectedFile = {
signers: [
{ signingOrder: 1 },
{ signingOrder: 2 },
{ signingOrder: 3 },
],
}
wrapper = createWrapper()
wrapper.vm.onDragEnd({ oldIndex: 0, newIndex: 2 })
expect(filesStore.selectedFile.signers[0].signingOrder).toBe(1)
expect(filesStore.selectedFile.signers[1].signingOrder).toBe(2)
expect(filesStore.selectedFile.signers[2].signingOrder).toBe(3)
})
it('emits signing-order-changed event', async () => {
filesStore.selectedFile = {
signers: [
{ signingOrder: 1 },
{ signingOrder: 2 },
],
}
wrapper = createWrapper()
wrapper.vm.onDragEnd({ oldIndex: 0, newIndex: 1 })
expect(wrapper.emitted('signing-order-changed')).toBeTruthy()
})
it('does not emit when dragged to same position', () => {
filesStore.selectedFile = {
signers: [
{ signingOrder: 1 },
{ signingOrder: 2 },
],
}
wrapper = createWrapper()
wrapper.vm.onDragEnd({ oldIndex: 1, newIndex: 1 })
expect(wrapper.emitted('signing-order-changed')).toBeFalsy()
})
it('handles out of order initial values', () => {
filesStore.selectedFile = {
signers: [
{ signingOrder: 5 },
{ signingOrder: 10 },
{ signingOrder: 7 },
],
}
wrapper = createWrapper()
wrapper.vm.onDragEnd({ oldIndex: 1, newIndex: 2 })
expect(filesStore.selectedFile.signers[0].signingOrder).toBe(1)
expect(filesStore.selectedFile.signers[1].signingOrder).toBe(2)
expect(filesStore.selectedFile.signers[2].signingOrder).toBe(3)
})
it('handles many signers correctly', () => {
filesStore.selectedFile = {
signers: [
{ signingOrder: 1 },
{ signingOrder: 2 },
{ signingOrder: 3 },
{ signingOrder: 4 },
{ signingOrder: 5 },
],
}
wrapper = createWrapper()
wrapper.vm.onDragEnd({ oldIndex: 0, newIndex: 4 })
for (let i = 0; i < 5; i++) {
expect(filesStore.selectedFile.signers[i].signingOrder).toBe(i + 1)
}
})
})
describe('RULE: component renders draggable when ordered_numeric and canReorder', () => {
it('uses draggable component when conditions met', () => {
filesStore.selectedFile = {
signatureFlow: 'ordered_numeric',
signers: [{}, {}],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(true)
expect(wrapper.vm.canReorder).toBe(true)
})
it('uses regular ul when not ordered_numeric', () => {
filesStore.selectedFile = {
signatureFlow: 'parallel',
signers: [{}, {}],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
expect(wrapper.vm.isOrderedNumeric).toBe(false)
})
it('uses regular ul when cannot reorder', () => {
filesStore.selectedFile = {
signatureFlow: 'ordered_numeric',
signers: [{}],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
expect(wrapper.vm.canReorder).toBe(false)
})
})
describe('RULE: signer.identify is the sole :key — no id/email fallback needed', () => {
it('renders one Signer stub per signer when all have identify set', () => {
filesStore.selectedFile = {
signers: [
{ identify: 'abc-1', displayName: 'Alice' },
{ identify: 'abc-2', displayName: 'Bob' },
{ identify: 'abc-3', displayName: 'Carol' },
],
}
wrapper = createWrapper()
const signerStubs = wrapper.findAllComponents({ name: 'Signer' })
expect(signerStubs).toHaveLength(3)
})
it('renders one Signer stub per signer in ordered_numeric mode with identify', () => {
filesStore.selectedFile = {
signatureFlow: 'ordered_numeric',
signers: [
{ identify: 'x-10', signingOrder: 1 },
{ identify: 'x-20', signingOrder: 2 },
],
}
filesStore.canSave = vi.fn().mockReturnValue(true)
wrapper = createWrapper()
const signerStubs = wrapper.findAllComponents({ name: 'Signer' })
expect(signerStubs).toHaveLength(2)
})
})
})