Rename ObservableProperty to Property. Add ReadOnlyProperty.

Author: ChebanovDD

samples/Unity.Mvvm.Calc/Assets/Scripts/Models/CalcModel.cs

@@ -23,8 +23,8 @@ public class CalcModel
 
         public CalcModel(IAppContext appContext)
         {
-            _result = new ObservableProperty<string>(string.Empty);
-            _expression = new ObservableProperty<string>(string.Empty);
+            _result = new Property<string>(string.Empty);
+            _expression = new Property<string>(string.Empty);
 
             _converter = appContext.Resolve<FloatToStrConverter>();
             _mathOperations = appContext.Resolve<IReadOnlyDictionary<char, IMathOperation>>();

samples/Unity.Mvvm.Counter/Assets/Scripts/ViewModels/CounterViewModel.cs

@@ -8,8 +8,8 @@ public class CounterViewModel : IBindingContext
     {
         public CounterViewModel()
         {
-            Count = new ObservableProperty<int>();
-            ThemeMode = new ObservableProperty<ThemeMode>();
+            Count = new Property<int>();
+            ThemeMode = new Property<ThemeMode>();
 
             IncrementCommand = new Command(IncrementCount);
             DecrementCommand = new Command(DecrementCount);

samples/Unity.Mvvm.CounterLegacy/Assets/Scripts/ViewModels/CounterViewModel.cs

@@ -5,7 +5,7 @@ namespace ViewModels
 {
     public class CounterViewModel : IBindingContext
     {
-        private readonly IProperty<int> _count = new ObservableProperty<int>();
+        private readonly IProperty<int> _count = new Property<int>();
 
         public CounterViewModel()
         {

samples/Unity.Mvvm.ToDoList/Assets/Scripts/ViewModels/AddTaskDialogViewModel.cs

@@ -13,8 +13,8 @@ public class AddTaskDialogViewModel : IBindingContext, IInitializable, IDisposab
 
         public AddTaskDialogViewModel(IAppContext appContext)
         {
+            _taskName = new Property<string>();
             _taskBroker = appContext.Resolve<TaskBroker>();
-            _taskName = new ObservableProperty<string>();
 
             AddTaskCommand = new Command(AddTask, CanAddTask);
         }

samples/Unity.Mvvm.ToDoList/Assets/Scripts/ViewModels/MainViewModel.cs

@@ -21,31 +21,30 @@ namespace ViewModels
 {
     public class MainViewModel : IBindingContext, IDisposable
     {
-        private readonly IDialogsService _dialogsService;
-
-        private readonly IProperty<string> _date;
         private readonly IProperty<int> _createdTasks;
         private readonly IProperty<int> _completedTasks;
-
         private readonly IProperty<bool> _isAddTaskDialogActive;
 
+        private readonly IReadOnlyProperty<string> _date;
         private readonly IReadOnlyProperty<ObservableCollection<TaskItemViewModel>> _taskItems;
 
+        private readonly IDialogsService _dialogsService;
+
         public MainViewModel(IAppContext appContext)
         {
             _dialogsService = appContext.Resolve<IDialogsService>();
 
             _taskItems =
-                new ObservableProperty<ObservableCollection<TaskItemViewModel>>(
+                new ReadOnlyProperty<ObservableCollection<TaskItemViewModel>>(
                     new ObservableCollection<TaskItemViewModel>());
             _taskItems.Value.CollectionChanged += OnTaskItemsCollectionChanged;
             ChangeAddTaskDialogVisibilityCommand = new AsyncCommand(ChangeAddTaskDialogVisibility);
 
-            _date = new ObservableProperty<string>(GetTodayDate());
-            _createdTasks = new ObservableProperty<int>(GetCreatedTasksCount(_taskItems.Value));
-            _completedTasks = new ObservableProperty<int>(GetCompletedTasksCount(_taskItems.Value));
+            _date = new ReadOnlyProperty<string>(GetTodayDate());
+            _createdTasks = new Property<int>(GetCreatedTasksCount(_taskItems.Value));
+            _completedTasks = new Property<int>(GetCompletedTasksCount(_taskItems.Value));
 
-            _isAddTaskDialogActive = new ObservableProperty<bool>();
+            _isAddTaskDialogActive = new Property<bool>();
 
             SubscribeOnTaskAddMessage(appContext.Resolve<TaskBroker>()).Forget();
         }

samples/Unity.Mvvm.ToDoList/Assets/Scripts/ViewModels/TaskItemViewModel.cs

@@ -7,8 +7,8 @@ namespace ViewModels
 {
     public class TaskItemViewModel : ICollectionItem, IInitializable, IDisposable
     {
-        private readonly IProperty<bool> _isDone = new ObservableProperty<bool>();
-        private readonly IProperty<string> _name = new ObservableProperty<string>();
+        private readonly IProperty<bool> _isDone = new Property<bool>();
+        private readonly IProperty<string> _name = new Property<string>();
 
         public TaskItemViewModel()
         {

…tyMvvmToolkit.Core/ObservableProperty.cs src/UnityMvvmToolkit.Core/Property.cssrc/UnityMvvmToolkit.Core/ObservableProperty.cs renamed to src/UnityMvvmToolkit.Core/Property.cs src/UnityMvvmToolkit.Core/ObservableProperty.cs renamed to src/UnityMvvmToolkit.Core/Property.cs

@@ -5,15 +5,15 @@
 
 namespace UnityMvvmToolkit.Core
 {
-    public sealed class ObservableProperty<TType> : IProperty<TType>
+    public sealed class Property<TType> : IProperty<TType>
     {
         private TType _value;
 
-        public ObservableProperty()
+        public Property() : this(default)
         {
         }
 
-        public ObservableProperty(TType value)
+        public Property(TType value)
         {
             _value = value;
         }
@@ -50,9 +50,9 @@ private void SetValue(TType value)
             ValueChanged?.Invoke(this, value);
         }
 
-        public static implicit operator ObservableProperty<TType>(TType value)
+        public static implicit operator Property<TType>(TType value)
         {
-            return new ObservableProperty<TType>(value);
+            return new Property<TType>(value);
         }
     }
 }

src/UnityMvvmToolkit.Core/ReadOnlyProperty.cs

@@ -0,0 +1,24 @@
+using System;
+using UnityMvvmToolkit.Core.Interfaces;
+
+#pragma warning disable CS0067
+
+namespace UnityMvvmToolkit.Core
+{
+    public sealed class ReadOnlyProperty<TType> : IReadOnlyProperty<TType>
+    {
+        public ReadOnlyProperty(TType value)
+        {
+            Value = value;
+        }
+
+        public TType Value { get; }
+
+        public event EventHandler<TType> ValueChanged;
+
+        public static implicit operator ReadOnlyProperty<TType>(TType value)
+        {
+            return new ReadOnlyProperty<TType>(value);
+        }
+    }
+}

…olkit/Runtime/Core/ObservableProperty.cs …nityMvvmToolkit/Runtime/Core/Property.cssrc/UnityMvvmToolkit.UnityPackage/Assets/Plugins/UnityMvvmToolkit/Runtime/Core/ObservableProperty.cs renamed to src/UnityMvvmToolkit.UnityPackage/Assets/Plugins/UnityMvvmToolkit/Runtime/Core/Property.cs src/UnityMvvmToolkit.UnityPackage/Assets/Plugins/UnityMvvmToolkit/Runtime/Core/ObservableProperty.cs renamed to src/UnityMvvmToolkit.UnityPackage/Assets/Plugins/UnityMvvmToolkit/Runtime/Core/Property.cs

@@ -5,15 +5,15 @@
 
 namespace UnityMvvmToolkit.Core
 {
-    public sealed class ObservableProperty<TType> : IProperty<TType>
+    public sealed class Property<TType> : IProperty<TType>
     {
         private TType _value;
 
-        public ObservableProperty()
+        public Property() : this(default)
         {
         }
 
-        public ObservableProperty(TType value)
+        public Property(TType value)
         {
             _value = value;
         }
@@ -50,9 +50,9 @@ private void SetValue(TType value)
             ValueChanged?.Invoke(this, value);
         }
 
-        public static implicit operator ObservableProperty<TType>(TType value)
+        public static implicit operator Property<TType>(TType value)
         {
-            return new ObservableProperty<TType>(value);
+            return new Property<TType>(value);
         }
     }
 }