Skip to content

Commit 48d6a39

Browse files
committed
nit: fixes
1 parent 4a528f0 commit 48d6a39

4 files changed

Lines changed: 14 additions & 12 deletions

File tree

.husky/pre-commit

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
npx --no-install lint-staged
1+
npx --no-install lint-staged
2+
pnpm test

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
"lint-staged": {
2424
"**/*.{ts,tsx}": [
2525
"eslint --max-warnings=0",
26-
"prettier --write --config .prettierrc",
27-
"pnpm test"
26+
"prettier --write --config .prettierrc"
2827
]
2928
},
3029
"devDependencies": {

packages/react-qr-code/src/components/finder-patterns-outer.tsx

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,18 +73,20 @@ export const FinderPatternsOuter = ({
7373
'Z',
7474
)
7575
} else if (style === 'pinched-square') {
76+
const PINCH_CONTROL_POINT = 0.5
77+
const INNER_CONTROL_POINT = 1.25
7678
ops.push(
7779
`M ${x} ${y}` +
78-
`Q ${x + 0.5} ${y + FINDER_PATTERN_SIZE / 2}, ${x} ${y + FINDER_PATTERN_SIZE}` +
79-
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + FINDER_PATTERN_SIZE - 0.5}, ${x + FINDER_PATTERN_SIZE} ${y + FINDER_PATTERN_SIZE}` +
80-
`Q ${x + FINDER_PATTERN_SIZE - 0.5} ${y + FINDER_PATTERN_SIZE / 2}, ${x + FINDER_PATTERN_SIZE} ${y}` +
81-
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + 0.5}, ${x} ${y}` +
80+
`Q ${x + PINCH_CONTROL_POINT} ${y + FINDER_PATTERN_SIZE / 2}, ${x} ${y + FINDER_PATTERN_SIZE}` +
81+
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + FINDER_PATTERN_SIZE - PINCH_CONTROL_POINT}, ${x + FINDER_PATTERN_SIZE} ${y + FINDER_PATTERN_SIZE}` +
82+
`Q ${x + FINDER_PATTERN_SIZE - PINCH_CONTROL_POINT} ${y + FINDER_PATTERN_SIZE / 2}, ${x + FINDER_PATTERN_SIZE} ${y}` +
83+
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + PINCH_CONTROL_POINT}, ${x} ${y}` +
8284
'z' +
8385
`M ${x + 1} ${y + 1}` +
84-
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + 1.25}, ${x + FINDER_PATTERN_SIZE - 1} ${y + 1}` +
85-
`Q ${x + FINDER_PATTERN_SIZE - 1.25} ${y + FINDER_PATTERN_SIZE / 2}, ${x + FINDER_PATTERN_SIZE - 1} ${y + FINDER_PATTERN_SIZE - 1}` +
86-
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + FINDER_PATTERN_SIZE - 1.25}, ${x + 1} ${y + FINDER_PATTERN_SIZE - 1}` +
87-
`Q ${x + 1.25} ${y + FINDER_PATTERN_SIZE / 2}, ${x + 1} ${y + 1}` +
86+
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + INNER_CONTROL_POINT}, ${x + FINDER_PATTERN_SIZE - 1} ${y + 1}` +
87+
`Q ${x + FINDER_PATTERN_SIZE - INNER_CONTROL_POINT} ${y + FINDER_PATTERN_SIZE / 2}, ${x + FINDER_PATTERN_SIZE - 1} ${y + FINDER_PATTERN_SIZE - 1}` +
88+
`Q ${x + FINDER_PATTERN_SIZE / 2} ${y + FINDER_PATTERN_SIZE - INNER_CONTROL_POINT}, ${x + 1} ${y + FINDER_PATTERN_SIZE - 1}` +
89+
`Q ${x + INNER_CONTROL_POINT} ${y + FINDER_PATTERN_SIZE / 2}, ${x + 1} ${y + 1}` +
8890
'z',
8991
)
9092
} else {

packages/react-qr-code/src/utils/svg.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export const pinchedSquare = (
4747
`Q ${x + size / 2} ${y + size - controlOffset}, ${x + size} ${y + size}` +
4848
`Q ${x + size - controlOffset} ${y + size / 2}, ${x + size} ${y}` +
4949
`Q ${x + size / 2} ${y + controlOffset}, ${x} ${y}` +
50-
'z'
50+
'Z'
5151

5252
export const hashtag = (x: number, y: number, size: number) => {
5353
const eigth = size / 8

0 commit comments

Comments
 (0)