release fix 2

Author: KrishSingaria

.github/workflows/release.yml

@@ -11,24 +11,31 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
+        # Build on all 3 OSs
         os: [ubuntu-latest, windows-latest, macos-latest]
 
     steps:
       - uses: actions/checkout@v4
 
-      # Build the wheels
       - name: Build wheels
         uses: pypa/[email protected]
         env:
-          # Skip old Python versions and PyPy to save time
+          # Skip old Python versions
           CIBW_SKIP: "cp36-* cp37-* cp38-* pp*"
-          # Force C++20 standard for Linux builds (Nanobind needs it)
+          
+          # Linux: Force C++20
           CIBW_ENVIRONMENT_LINUX: "CXXFLAGS='-std=c++20'"
-
-      - uses: actions/upload-artifact@v4
-        with:
-          name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
-          path: ./wheelhouse/*.whl
+          
+          # macOS: Install OpenMP (libomp) before building
+          CIBW_BEFORE_ALL_MACOS: "brew install libomp"
+          
+          # macOS: Tell CMake where to find OpenMP
+          # (Homebrew puts it in a weird spot, we need to point to it)
+          CIBW_ENVIRONMENT_MACOS: >
+            CFLAGS="-Xpreprocessor -fopenmp -I$(brew --prefix libomp)/include"
+            CXXFLAGS="-Xpreprocessor -fopenmp -I$(brew --prefix libomp)/include"
+            LDFLAGS="-L$(brew --prefix libomp)/lib -lomp"
+            OpenMP_ROOT="$(brew --prefix libomp)"
 
   build_sdist:
     name: Build source distribution

src/CSR.hpp

@@ -85,15 +85,15 @@ inline std::span<size_t> CSR::get_edges(size_t nodeId){
 }
 
 inline void CSR::set_access_pattern(bool isRandom){
-    #ifndef _WIN32 
+    #ifdef __linux__
     if(isRandom){
         madvise(this->nnzRow,this->sizeofnnzRow,MADV_RANDOM);
         madvise(this->colPtr,this->sizeofcolPtr,MADV_RANDOM);
     }else{
         madvise(this->nnzRow,this->sizeofcolPtr,MADV_SEQUENTIAL);
         madvise(this->colPtr,this->sizeofcolPtr,MADV_SEQUENTIAL);
     }
-    #endif // linux
+    #endif // linux only, no mac/windows
 }
 
 #endif

src/MemoryMap.hpp

@@ -80,8 +80,7 @@ inline MemoryMap::MemoryMap(const char* path){
 
     CloseHandle(hMap);
     CloseHandle(hFile);
-
-    #else // linux
+    #else // linux/mac
     if((fd = open(path,O_RDONLY)) == -1){
         throw std::runtime_error("File open failed");
     }
@@ -97,8 +96,10 @@ inline MemoryMap::MemoryMap(const char* path){
         throw std::runtime_error("mmap failed");
     }
 
-    // memory advise to use huge pages
-    madvise(mappedptr,length, MADV_HUGEPAGE);
+    // Only use Huge Pages on Linux. macOS don't support this flag.
+    #ifdef __linux__
+        madvise(mappedptr, length, MADV_HUGEPAGE);
+    #endif
 
     #endif