const ref foreach

alister-chowdhury · alister-chowdhury · commit f9339a1b4cf3 · 2025-11-29T16:32:09.000Z
diff --git a/source/opt/instruction.cpp b/source/opt/instruction.cpp
@@ -586,7 +586,7 @@ bool Instruction::IsSetBindingUniformlyReadOnly() const {
     assert(false && "Set and binding couldn't be resolved!");
     return false;
   }
-  for (const auto other_inst : context()->types_values()) {
+  for (const auto& other_inst : context()->types_values()) {
     if (other_inst.opcode() != spv::Op::OpVariable) {
       continue;
     }

Original file line number	Diff line number	Diff line change
`@@ -586,7 +586,7 @@ bool Instruction::IsSetBindingUniformlyReadOnly() const {`
`586`	`586`	`assert(false && "Set and binding couldn't be resolved!");`
`587`	`587`	`return false;`
`588`	`588`	`}`
`589`		`- for (const auto other_inst : context()->types_values()) {`
	`589`	`+ for (const auto& other_inst : context()->types_values()) {`
`590`	`590`	`if (other_inst.opcode() != spv::Op::OpVariable) {`
`591`	`591`	`continue;`
`592`	`592`	`}`