Ban untyped pointers in OpSizeOf

Author: spencer-lunarg

source/val/validate_misc.cpp

@@ -93,6 +93,11 @@ spv_result_t ValidateSizeOf(ValidationState_t& _, const Instruction* inst) {
   if (!_.IsConcreteType(pointer_id)) {
     return _.diag(SPV_ERROR_INVALID_DATA, inst)
            << "OpSizeOf Pointer operand is not concrete.";
+  } else if (_.FindDef(pointer_id)->opcode() ==
+             spv::Op::OpTypeUntypedPointerKHR) {
+    return _.diag(SPV_ERROR_INVALID_DATA, inst)
+           << "OpSizeOf Pointer operand is to an untyped pointer, which size "
+              "is not well defined.";
   }
 
   return SPV_SUCCESS;

test/val/val_misc_test.cpp

@@ -155,6 +155,33 @@ TEST_F(ValidateMisc, SizeOfStructWithAbstract) {
               HasSubstr("OpSizeOf Pointer operand is not concrete"));
 }
 
+TEST_F(ValidateMisc, SizeOfUntyped) {
+  const std::string spirv = R"(
+               OpCapability Addresses
+               OpCapability UntypedPointersKHR
+               OpCapability Kernel
+               OpExtension "SPV_KHR_untyped_pointers"
+               OpMemoryModel Physical64 OpenCL
+               OpEntryPoint Kernel %f "f"
+       %void = OpTypeVoid
+        %i32 = OpTypeInt 32 0
+       %fnTy = OpTypeFunction %void
+%untyped_ptr = OpTypeUntypedPointerKHR CrossWorkgroup
+          %f = OpFunction %void None %fnTy
+      %entry = OpLabel
+          %s = OpSizeOf %i32 %untyped_ptr
+               OpReturn
+               OpFunctionEnd
+)";
+
+  CompileSuccessfully(spirv, SPV_ENV_UNIVERSAL_1_1);
+  EXPECT_EQ(SPV_ERROR_INVALID_DATA,
+            ValidateInstructions(SPV_ENV_UNIVERSAL_1_1));
+  EXPECT_THAT(getDiagnosticString(),
+              HasSubstr("OpSizeOf Pointer operand is to an untyped pointer, "
+                        "which size is not well defined"));
+}
+
 TEST_F(ValidateMisc, SizeOfFloat) {
   const std::string spirv = R"(
                OpCapability Addresses