Ignore ordinary stores when trimming VariablePointers

VariablePointers is about pointer values that remain first-class in the final module. A plain OpStore stores through a pointer. It does not by itself prove that the module still needs VariablePointers.\n\nThe SPIR-V OpStore definition says that Pointer is the pointer to store through and Object is the object to store. The variable pointers rules separately constrain the case where a pointer is the Object operand of OpStore or the result of OpLoad. Ordinary stores of non-pointer objects through StorageBuffer pointers do not require keeping VariablePointers alive.\n\nStop treating every OpStore as a VariablePointers requirement and add a regression test for a normal StorageBuffer store that should trim the stale capability.\n\nSpec references:\nhttps://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#OpStore\nhttps://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#VariablePointers

Author: AnastaZIuk

source/opt/trim_variable_pointers_capabilities_pass.cpp

@@ -249,7 +249,6 @@ void AddVariablePointerCapabilityRequirements(
 
   switch (instruction->opcode()) {
     case spv::Op::OpReturnValue:
-    case spv::Op::OpStore:
     case spv::Op::OpPtrAccessChain:
     case spv::Op::OpPtrEqual:
     case spv::Op::OpPtrNotEqual:

test/opt/trim_variable_pointers_capabilities_pass_test.cpp

@@ -62,6 +62,45 @@ TEST_F(TrimVariablePointersCapabilitiesPassTest,
   EXPECT_EQ(std::get<1>(result), Pass::Status::SuccessWithChange);
 }
 
+TEST_F(TrimVariablePointersCapabilitiesPassTest,
+       VariablePointers_RemovedForOrdinaryStorageBufferStores) {
+  const std::string kTest = R"(
+               OpCapability Shader
+               OpCapability VariablePointers
+; CHECK:       OpCapability Shader
+; CHECK-NOT:   OpCapability VariablePointers
+               OpMemoryModel Logical GLSL450
+               OpEntryPoint GLCompute %main "main" %buf
+               OpExecutionMode %main LocalSize 1 1 1
+               OpDecorate %_struct_4 Block
+               OpMemberDecorate %_struct_4 0 Offset 0
+               OpDecorate %buf DescriptorSet 0
+               OpDecorate %buf Binding 0
+       %void = OpTypeVoid
+          %3 = OpTypeFunction %void
+      %float = OpTypeFloat 32
+    %v3float = OpTypeVector %float 3
+    %float_0 = OpConstant %float 0
+         %11 = OpConstantComposite %v3float %float_0 %float_0 %float_0
+       %uint = OpTypeInt 32 0
+     %uint_0 = OpConstant %uint 0
+  %_struct_4 = OpTypeStruct %v3float
+%_ptr_StorageBuffer__struct_4 = OpTypePointer StorageBuffer %_struct_4
+%_ptr_StorageBuffer_v3float = OpTypePointer StorageBuffer %v3float
+        %buf = OpVariable %_ptr_StorageBuffer__struct_4 StorageBuffer
+       %main = OpFunction %void None %3
+          %9 = OpLabel
+         %10 = OpAccessChain %_ptr_StorageBuffer_v3float %buf %uint_0
+               OpStore %10 %11
+               OpReturn
+               OpFunctionEnd
+  )";
+  const auto result =
+      SinglePassRunAndMatch<TrimVariablePointersCapabilitiesPass>(
+          kTest, /* skip_nop= */ false);
+  EXPECT_EQ(std::get<1>(result), Pass::Status::SuccessWithChange);
+}
+
 TEST_F(TrimVariablePointersCapabilitiesPassTest,
        VariablePointers_RemainsForWorkgroupSelect) {
   const std::string kTest = R"(