const ref foreach

alister-chowdhury · s-perron · commit 135185f7148b · 2026-03-27T13:37:32.000-04:00
diff --git a/source/opt/instruction.cpp b/source/opt/instruction.cpp
@@ -587,7 +587,7 @@ bool Instruction::IsSetBindingUniformlyReadOnly() const {
     assert(false && "Set and binding couldn't be resolved!");
     return false;
   }
-  for (const auto other_inst : context()->types_values()) {
+  for (const auto& other_inst : context()->types_values()) {
     if (other_inst.opcode() != spv::Op::OpVariable) {
       continue;
     }

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,7 @@ bool Instruction::IsSetBindingUniformlyReadOnly() const {`
`587`	`587`	`assert(false && "Set and binding couldn't be resolved!");`
`588`	`588`	`return false;`
`589`	`589`	`}`
`590`		`- for (const auto other_inst : context()->types_values()) {`
	`590`	`+ for (const auto& other_inst : context()->types_values()) {`
`591`	`591`	`if (other_inst.opcode() != spv::Op::OpVariable) {`
`592`	`592`	`continue;`
`593`	`593`	`}`