remove use of jl_set_value on 1.9. fix UndefVarError for new nightly error formatting (#709)

Co-authored-by: Ian Butterworth <[email protected]>

Author: simonbyrne

docs/src/devdocs/binaries_part_2.md

@@ -175,8 +175,12 @@ int main(int argc, char *argv[])
     jl_set_ARGS(argc, argv);
 
     // Set PROGRAM_FILE to argv[0].
-    jl_set_global(jl_base_module,
-        jl_symbol("PROGRAM_FILE"), (jl_value_t*)jl_cstr_to_string(argv[0]));
+#if JULIA_VERSION_MAJOR == 1 && JULIA_VERSION_MINOR >= 9
+    jl_binding_t *bp = jl_get_binding_wr(jl_base_module, jl_symbol("PROGRAM_FILE"), 1);
+    jl_checked_assignment(bp, (jl_value_t*)jl_cstr_to_string(argv[0]));
+#else
+    jl_set_global(jl_base_module, jl_symbol("PROGRAM_FILE"), (jl_value_t*)jl_cstr_to_string(argv[0]));    
+#endif
 
     // Set Base.ARGS to `String[ unsafe_string(argv[i]) for i = 1:argc ]`
     jl_array_t *ARGS = (jl_array_t*)jl_get_global(jl_base_module, jl_symbol("ARGS"));

src/embedding_wrapper.c

@@ -104,7 +104,12 @@ int main(int argc, char *argv[]) {
     checked_eval_string("append!(empty!(Base.ARGS), Core.ARGS)");
     jl_value_t *firstarg = checked_eval_string("popfirst!(ARGS)");
     JL_GC_PUSH1(&firstarg);
-    jl_set_global(jl_base_module, jl_symbol("PROGRAM_FILE"), firstarg);
+#if JULIA_VERSION_MAJOR == 1 && JULIA_VERSION_MINOR >= 9
+    jl_binding_t *bp = jl_get_binding_wr(jl_base_module, jl_symbol("PROGRAM_FILE"), 1);
+    jl_checked_assignment(bp, firstarg);
+#else
+    jl_set_global(jl_base_module, jl_symbol("PROGRAM_FILE"), firstarg);    
+#endif
     JL_GC_POP();
 
     // call the work function, and get back a value

test/runtests.jl

@@ -132,7 +132,8 @@ end
 
             io = IOBuffer()
             p = run(pipeline(ignorestatus(`$(app_path("Undefined"))`), stderr=io;))
-            @test occursin("UndefVarError: undefined not defined", String(take!(io)))
+            str = String(take!(io))
+            @test all(occursin(str), ["UndefVarError:", "undefined", "not defined"])
             @test p.exitcode == 1
         end
     end