Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit fb91bf2

Browse files
author
Stefan Kock
committed
SORMAS-Foundation#4140 Bugfix: Added a merge function with last wins (as before)
1 parent 8fb56b6 commit fb91bf2

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

sormas-backend/src/main/java/de/symeda/sormas/backend/feature/FeatureConfigurationService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public void createMissingFeatureConfigurations() {
126126

127127
List<FeatureConfiguration> featureConfigurations = getAll();
128128
Map<FeatureType, FeatureConfiguration> existingListOfConfigurations =
129-
featureConfigurations.stream().collect(Collectors.toMap(FeatureConfiguration::getFeatureType, Function.identity()));
129+
featureConfigurations.stream().collect(Collectors.toMap(FeatureConfiguration::getFeatureType, Function.identity(), (e1, e2) -> e2));
130130

131131
FeatureType.getAllServerFeatures().forEach(featureType -> {
132132
FeatureConfiguration savedConfiguration = existingListOfConfigurations.get(featureType);
@@ -141,7 +141,7 @@ public void updateFeatureConfigurations() {
141141

142142
List<FeatureConfiguration> featureConfigurations = getAll();
143143
Map<FeatureType, FeatureConfiguration> featureConfigurationMap =
144-
featureConfigurations.stream().collect(Collectors.toMap(FeatureConfiguration::getFeatureType, Function.identity()));
144+
featureConfigurations.stream().collect(Collectors.toMap(FeatureConfiguration::getFeatureType, Function.identity(), (e1, e2) -> e2));
145145

146146
FeatureType.getAllServerFeatures().forEach(featureType -> {
147147
if (featureType.isDependent()) {

sormas-backend/src/test/java/de/symeda/sormas/backend/feature/FeatureConfigurationServiceTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@ public void testUpdateFeatureConfigurations() {
2424

2525
createConfigurations();
2626
FeatureConfigurationService featureConfigurationService = getBean(FeatureConfigurationService.class);
27+
28+
/*
29+
* update relies on that all serverFeature configurations are already present,
30+
* that's why the createMissing needs to be run before.
31+
*/
32+
featureConfigurationService.createMissingFeatureConfigurations();
2733
featureConfigurationService.updateFeatureConfigurations();
2834
}
2935

0 commit comments

Comments
 (0)