Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit ee391fe

Browse files
BarnaBarthabarnabartha
andauthored
SORMAS-Foundation#3873 - execute follow up calculation logic also for import (SORMAS-Foundation#3976)
* SORMAS-Foundation#3873 - execute follow up calculation logic also for import - the issue due to which this was ignored for import from SORMAS-Foundation#2641 has been fixed in the meantime with SORMAS-Foundation#3424 * SORMAS-Foundation#3873 - remove unnecessary commented lines + do not execute handle case changes for contact imports * SORMAS-Foundation#3873 - fix compilation issue Co-authored-by: barnabartha <[email protected]>
1 parent 3367aed commit ee391fe

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

sormas-api/src/main/java/de/symeda/sormas/api/contact/ContactFacade.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public interface ContactFacade {
4242

4343
ContactDto saveContact(ContactDto dto);
4444

45-
ContactDto saveContact(ContactDto dto, boolean handleChanges);
45+
ContactDto saveContact(ContactDto dto, boolean handleChanges, boolean handleCaseChanges);
4646

4747
ContactReferenceDto getReferenceByUuid(String uuid);
4848

sormas-backend/src/main/java/de/symeda/sormas/backend/caze/CaseFacadeEjb.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2872,7 +2872,7 @@ private void mergeCase(CaseDataDto leadCaseData, CaseDataDto otherCaseData, bool
28722872
ContactDto newContact = ContactDto.build(leadCase.toReference(), leadCase.getDisease(), leadCase.getDiseaseDetails());
28732873
newContact.setPerson(new PersonReferenceDto(contact.getPerson().getUuid()));
28742874
fillDto(newContact, ContactFacadeEjb.toDto(contact), cloning);
2875-
contactFacade.saveContact(newContact, false);
2875+
contactFacade.saveContact(newContact, false, false);
28762876
} else {
28772877
// simply move existing entities to the merge target
28782878
contact.setCaze(leadCase);

sormas-backend/src/main/java/de/symeda/sormas/backend/contact/ContactFacadeEjb.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
import javax.persistence.criteria.Root;
5959
import javax.validation.constraints.NotNull;
6060

61-
import de.symeda.sormas.backend.common.CriteriaBuilderHelper;
6261
import org.apache.commons.collections.CollectionUtils;
6362
import org.slf4j.Logger;
6463
import org.slf4j.LoggerFactory;
@@ -123,7 +122,7 @@
123122
import de.symeda.sormas.backend.caze.CaseService;
124123
import de.symeda.sormas.backend.clinicalcourse.ClinicalCourseFacadeEjb;
125124
import de.symeda.sormas.backend.common.AbstractDomainObject;
126-
import de.symeda.sormas.backend.common.BaseAdoService;
125+
import de.symeda.sormas.backend.common.CriteriaBuilderHelper;
127126
import de.symeda.sormas.backend.common.TaskCreationException;
128127
import de.symeda.sormas.backend.epidata.EpiData;
129128
import de.symeda.sormas.backend.epidata.EpiDataFacadeEjb;
@@ -275,11 +274,11 @@ public ContactReferenceDto getReferenceByUuid(String uuid) {
275274

276275
@Override
277276
public ContactDto saveContact(ContactDto dto) {
278-
return saveContact(dto, true);
277+
return saveContact(dto, true, true);
279278
}
280279

281280
@Override
282-
public ContactDto saveContact(ContactDto dto, boolean handleChanges) {
281+
public ContactDto saveContact(ContactDto dto, boolean handleChanges, boolean handleCaseChanges) {
283282
final Contact existingContact = dto.getUuid() != null ? contactService.getByUuid(dto.getUuid()) : null;
284283
final ContactDto existingContactDto = toDto(existingContact);
285284
restorePseudonymizedDto(dto, existingContact, existingContactDto);
@@ -321,7 +320,7 @@ public ContactDto saveContact(ContactDto dto, boolean handleChanges) {
321320
}
322321
contactService.udpateContactStatus(entity);
323322

324-
if (entity.getCaze() != null) {
323+
if (handleCaseChanges && entity.getCaze() != null) {
325324
caseFacade.onCaseChanged(CaseFacadeEjbLocal.toDto(entity.getCaze()), entity.getCaze());
326325
}
327326
}
@@ -531,7 +530,8 @@ public List<ContactExportDto> getExportList(ContactCriteria contactCriteria, int
531530
ContactJoins visitContactJoins = new ContactJoins(visitsCqRoot);
532531

533532
visitsCq.where(
534-
CriteriaBuilderHelper.and(cb, contact.get(AbstractDomainObject.ID).in(exportContactIds), cb.isNotEmpty(visitsCqRoot.get(Contact.VISITS))));
533+
CriteriaBuilderHelper
534+
.and(cb, contact.get(AbstractDomainObject.ID).in(exportContactIds), cb.isNotEmpty(visitsCqRoot.get(Contact.VISITS))));
535535
visitsCq.multiselect(
536536
Stream
537537
.concat(

sormas-ui/src/main/java/de/symeda/sormas/ui/contact/importer/ContactImporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ protected ImportLineResult importDataFromCsvLine(
202202
}
203203
}
204204

205-
FacadeProvider.getContactFacade().saveContact(newContact, false);
205+
FacadeProvider.getContactFacade().saveContact(newContact, true, false);
206206

207207
consumer.result = null;
208208
return ImportLineResult.SUCCESS;

0 commit comments

Comments
 (0)