Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit e897118

Browse files
SORMAS-Foundation#3591 - Temporarily disabled new contact directory filtering logic
1 parent 675d8d2 commit e897118

3 files changed

Lines changed: 25 additions & 24 deletions

File tree

sormas-backend/src/main/java/de/symeda/sormas/backend/contact/ContactFacadeEjb.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,11 @@
126126
import de.symeda.sormas.backend.epidata.EpiData;
127127
import de.symeda.sormas.backend.epidata.EpiDataFacadeEjb;
128128
import de.symeda.sormas.backend.epidata.EpiDataFacadeEjb.EpiDataFacadeEjbLocal;
129-
import de.symeda.sormas.backend.exposure.Exposure;
130129
import de.symeda.sormas.backend.event.ContactEventSummaryDetails;
131130
import de.symeda.sormas.backend.event.Event;
132131
import de.symeda.sormas.backend.event.EventParticipant;
133132
import de.symeda.sormas.backend.event.EventService;
133+
import de.symeda.sormas.backend.exposure.Exposure;
134134
import de.symeda.sormas.backend.externaljournal.ExternalJournalService;
135135
import de.symeda.sormas.backend.facility.Facility;
136136
import de.symeda.sormas.backend.location.Location;

sormas-backend/src/main/java/de/symeda/sormas/backend/contact/ContactService.java

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -893,11 +893,11 @@ public Predicate createUserFilterForJoin(CriteriaBuilder cb, CriteriaQuery cq, F
893893
@SuppressWarnings("rawtypes")
894894
public Predicate createUserFilterForJoin(CriteriaBuilder cb, CriteriaQuery cq, From<?, Contact> contactPath, ContactCriteria contactCriteria) {
895895

896-
Predicate userFilter = null;
896+
// Predicate userFilter = null;
897897

898-
if (contactCriteria == null || contactCriteria.getIncludeContactsFromOtherJurisdictions()) {
899-
userFilter = caseService.createUserFilter(cb, cq, contactPath.join(Contact.CAZE, JoinType.LEFT));
900-
}
898+
// if (contactCriteria == null || contactCriteria.getIncludeContactsFromOtherJurisdictions()) {
899+
Predicate userFilter = caseService.createUserFilter(cb, cq, contactPath.join(Contact.CAZE, JoinType.LEFT));
900+
// }
901901
Predicate filter;
902902
if (userFilter != null) {
903903
filter = cb.or(createUserFilterWithoutCase(cb, cq, contactPath, contactCriteria), userFilter);
@@ -930,12 +930,12 @@ public Predicate createUserFilterWithoutCase(
930930
}
931931
}
932932

933-
Predicate filter = null;
933+
// Predicate filter = null;
934934
// whoever created it or is assigned to it is allowed to access it
935-
if (contactCriteria == null || contactCriteria.getIncludeContactsFromOtherJurisdictions()) {
936-
filter = cb.equal(contactPath.join(Contact.REPORTING_USER, JoinType.LEFT), currentUser);
937-
filter = cb.or(filter, cb.equal(contactPath.join(Contact.CONTACT_OFFICER, JoinType.LEFT), currentUser));
938-
}
935+
// if (contactCriteria == null || contactCriteria.getIncludeContactsFromOtherJurisdictions()) {
936+
Predicate filter = cb.equal(contactPath.join(Contact.REPORTING_USER, JoinType.LEFT), currentUser);
937+
filter = cb.or(filter, cb.equal(contactPath.join(Contact.CONTACT_OFFICER, JoinType.LEFT), currentUser));
938+
// }
939939
switch (jurisdictionLevel) {
940940
case REGION:
941941
final Region region = currentUser.getRegion();
@@ -1189,8 +1189,10 @@ public Predicate buildCriteriaFilter(ContactCriteria contactCriteria, CriteriaBu
11891189
and(cb, filter, cb.equal(joins.getEventParticipants().get(EventParticipant.UUID), contactCriteria.getEventParticipant().getUuid()));
11901190
}
11911191
if (contactCriteria.getOnlyContactsWithSourceCaseInGivenEvent() != null) {
1192-
filter =
1193-
and(cb, filter, cb.equal(joins.getCaseEvent().get(Event.UUID), contactCriteria.getOnlyContactsWithSourceCaseInGivenEvent().getUuid()));
1192+
filter = and(
1193+
cb,
1194+
filter,
1195+
cb.equal(joins.getCaseEvent().get(Event.UUID), contactCriteria.getOnlyContactsWithSourceCaseInGivenEvent().getUuid()));
11941196
}
11951197

11961198
return filter;

sormas-ui/src/main/java/de/symeda/sormas/ui/contact/ContactsFilterForm.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import de.symeda.sormas.api.person.PersonDto;
3838
import de.symeda.sormas.api.region.DistrictReferenceDto;
3939
import de.symeda.sormas.api.region.RegionReferenceDto;
40-
import de.symeda.sormas.api.user.JurisdictionLevel;
4140
import de.symeda.sormas.api.user.UserDto;
4241
import de.symeda.sormas.api.user.UserRole;
4342
import de.symeda.sormas.api.utils.DateFilterOption;
@@ -294,17 +293,17 @@ public void addMoreFilters(CustomLayout moreFiltersContainer) {
294293
null,
295294
CHECKBOX_STYLE));
296295

297-
final JurisdictionLevel userJurisdictionLevel = UserRole.getJurisdictionLevel(UserProvider.getCurrent().getUserRoles());
298-
if (userJurisdictionLevel != JurisdictionLevel.NATION && userJurisdictionLevel != JurisdictionLevel.NONE) {
299-
addField(
300-
moreFiltersContainer,
301-
CheckBox.class,
302-
FieldConfiguration.withCaptionAndStyle(
303-
ContactCriteria.INCLUDE_CONTACTS_FROM_OTHER_JURISDICTIONS,
304-
I18nProperties.getCaption(Captions.contactInludeContactsFromOtherJurisdictions),
305-
I18nProperties.getDescription(Descriptions.descContactIncludeContactsFromOtherJurisdictions),
306-
CHECKBOX_STYLE));
307-
}
296+
// final JurisdictionLevel userJurisdictionLevel = UserRole.getJurisdictionLevel(UserProvider.getCurrent().getUserRoles());
297+
// if (userJurisdictionLevel != JurisdictionLevel.NATION && userJurisdictionLevel != JurisdictionLevel.NONE) {
298+
// addField(
299+
// moreFiltersContainer,
300+
// CheckBox.class,
301+
// FieldConfiguration.withCaptionAndStyle(
302+
// ContactCriteria.INCLUDE_CONTACTS_FROM_OTHER_JURISDICTIONS,
303+
// I18nProperties.getCaption(Captions.contactInludeContactsFromOtherJurisdictions),
304+
// I18nProperties.getDescription(Descriptions.descContactIncludeContactsFromOtherJurisdictions),
305+
// CHECKBOX_STYLE));
306+
// }
308307

309308
moreFiltersContainer.addComponent(buildWeekAndDateFilter(), WEEK_AND_DATE_FILTER);
310309
}

0 commit comments

Comments
 (0)