SORMAS-Foundation#3253 - fix count of missing case contact information query

Author: barnabartha

sormas-backend/src/main/java/de/symeda/sormas/backend/caze/CaseFacadeEjb.java

@@ -3128,7 +3128,7 @@ public long countCasesWithMissingContactInformation(List<String> caseUuids, Mess
 			final String messageTypeColumn = messageType == MessageType.EMAIL ? Person.EMAIL_ADDRESS : Person.PHONE;
 			return cb.and(
 				root.get(Case.UUID).in(caseUuids),
-				cb.and(cb.isNull(personJoin.get(messageTypeColumn)), cb.notEqual(personJoin.get(messageTypeColumn), StringUtils.EMPTY)));
+				cb.or(cb.isNull(personJoin.get(messageTypeColumn)), cb.equal(personJoin.get(messageTypeColumn), StringUtils.EMPTY)));
 		})));
 
 		return totalCount.get();

sormas-backend/src/test/java/de/symeda/sormas/backend/caze/CaseFacadeEjbTest.java

@@ -37,6 +37,7 @@
 import java.util.stream.Collectors;
 
 import de.symeda.sormas.api.VisitOrigin;
+import de.symeda.sormas.api.messaging.MessageType;
 import org.junit.Assert;
 import org.junit.Rule;
 import org.junit.Test;
@@ -149,6 +150,30 @@ public void testDiseaseChangeUpdatesContacts() {
 		assertEquals(null, contact.getFollowUpUntil());
 	}
 
+	@Test
+	public void testCountCasesWithMisingContactInformation() {
+		RDCF rdcf = creator.createRDCF("Region", "District", "Community", "Facility");
+		RDCFEntities newRDCF = creator.createRDCFEntities("New Region", "New District", "New Community", "New Facility");
+		UserDto user = useSurveillanceOfficerLogin(rdcf);
+
+		PersonDto cazePerson = creator.createPerson("Case", "Person");
+		CaseDataDto caze = creator.createCase(
+				user.toReference(),
+				cazePerson.toReference(),
+				Disease.EVD,
+				CaseClassification.PROBABLE,
+				InvestigationStatus.PENDING,
+				new Date(),
+				rdcf);
+
+		Assert.assertEquals(1, getCaseFacade().countCasesWithMissingContactInformation(Arrays.asList(caze.getUuid()), MessageType.SMS));
+
+		cazePerson.setPhone("40742140797");
+		getPersonFacade().savePerson(cazePerson);
+
+		Assert.assertEquals(0, getCaseFacade().countCasesWithMissingContactInformation(Arrays.asList(caze.getUuid()), MessageType.SMS));
+	}
+
 	@Test
 	public void testMovingCaseUpdatesTaskAssigneeAndCreatesPreviousHospitalization() {