Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit 62f243c

Browse files
author
FredrikSchäferVitagroup
committed
Merge branch 'development' into feature-3195-Unit-tests-for-the-ExternalVisitsRessource
2 parents 17033ac + 8f9c6d5 commit 62f243c

22 files changed

Lines changed: 351 additions & 97 deletions

File tree

SERVER_CUSTOMIZATION.md

Lines changed: 33 additions & 32 deletions
Large diffs are not rendered by default.

sormas-api/src/main/java/de/symeda/sormas/api/externaljournal/ExternalJournalFacade.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ public interface ExternalJournalFacade {
1515

1616
RegisterResult registerPatientDiaryPerson(PersonDto person);
1717

18-
boolean isPersonExportable(PersonDto person);
18+
ExternalPersonValidation validatePatientDiaryPerson(PersonDto person);
1919
}
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package de.symeda.sormas.api.externaljournal;
2+
3+
import java.io.Serializable;
4+
5+
public class ExternalPersonValidation implements Serializable {
6+
7+
private boolean valid;
8+
private String message;
9+
10+
public ExternalPersonValidation(boolean valid, String message) {
11+
this.valid = valid;
12+
this.message = message;
13+
}
14+
15+
public boolean isValid() {
16+
return valid;
17+
}
18+
19+
public void setValid(boolean valid) {
20+
this.valid = valid;
21+
}
22+
23+
public String getMessage() {
24+
return message;
25+
}
26+
27+
public void setMessage(String message) {
28+
this.message = message;
29+
}
30+
}

sormas-api/src/main/java/de/symeda/sormas/api/externaljournal/PatientDiaryConfig.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ public class PatientDiaryConfig implements Serializable, Cloneable {
1212
private String authUrl;
1313
private String email;
1414
private String password;
15+
private UserConfig defaultUser;
1516

1617
public String getUrl() {
1718
return url;
@@ -53,6 +54,14 @@ public void setPassword(String password) {
5354
this.password = password;
5455
}
5556

57+
public UserConfig getDefaultUser() {
58+
return defaultUser;
59+
}
60+
61+
public void setDefaultUser(UserConfig defaultUser) {
62+
this.defaultUser = defaultUser;
63+
}
64+
5665
@Override
5766
public boolean equals(Object o) {
5867
if (this == o)
@@ -64,12 +73,13 @@ public boolean equals(Object o) {
6473
&& Objects.equals(externalDataUrl, that.externalDataUrl)
6574
&& Objects.equals(authUrl, that.authUrl)
6675
&& Objects.equals(email, that.email)
67-
&& Objects.equals(password, that.password);
76+
&& Objects.equals(password, that.password)
77+
&& Objects.equals(defaultUser, that.defaultUser);
6878
}
6979

7080
@Override
7181
public int hashCode() {
72-
return Objects.hash(url, externalDataUrl, authUrl, email, password);
82+
return Objects.hash(url, externalDataUrl, authUrl, email, password, defaultUser);
7383
}
7484

7585
@Override

sormas-api/src/main/java/de/symeda/sormas/api/externaljournal/SymptomJournalConfig.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public class SymptomJournalConfig implements Serializable, Cloneable {
1111
private String authUrl;
1212
private String clientId;
1313
private String secret;
14+
private UserConfig defaultUser;
1415

1516
public String getUrl() {
1617
return url;
@@ -44,6 +45,14 @@ public void setSecret(String secret) {
4445
this.secret = secret;
4546
}
4647

48+
public UserConfig getDefaultUser() {
49+
return defaultUser;
50+
}
51+
52+
public void setDefaultUser(UserConfig defaultUser) {
53+
this.defaultUser = defaultUser;
54+
}
55+
4756
@Override
4857
public boolean equals(Object o) {
4958
if (this == o)
@@ -54,12 +63,13 @@ public boolean equals(Object o) {
5463
return Objects.equals(url, that.url)
5564
&& Objects.equals(authUrl, that.authUrl)
5665
&& Objects.equals(clientId, that.clientId)
57-
&& Objects.equals(secret, that.secret);
66+
&& Objects.equals(secret, that.secret)
67+
&& Objects.equals(defaultUser, that.defaultUser);
5868
}
5969

6070
@Override
6171
public int hashCode() {
62-
return Objects.hash(url, authUrl, clientId, secret);
72+
return Objects.hash(url, authUrl, clientId, secret, defaultUser);
6373
}
6474

6575
@Override
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
/*
2+
* SORMAS® - Surveillance Outbreak Response Management & Analysis System
3+
* Copyright © 2016-2020 Helmholtz-Zentrum für Infektionsforschung GmbH (HZI)
4+
*
5+
* This program is free software: you can redistribute it and/or modify
6+
* it under the terms of the GNU General Public License as published by
7+
* the Free Software Foundation, either version 3 of the License, or
8+
* (at your option) any later version.
9+
*
10+
* This program is distributed in the hope that it will be useful,
11+
* but WITHOUT ANY WARRANTY; without even the implied warranty of
12+
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13+
* GNU General Public License for more details.
14+
*
15+
* You should have received a copy of the GNU General Public License
16+
* along with this program. If not, see <https://www.gnu.org/licenses/>.
17+
*/
18+
19+
package de.symeda.sormas.api.externaljournal;
20+
21+
import java.util.Objects;
22+
23+
/**
24+
* @author Alex Vidrean
25+
* @since 28-Oct-20
26+
*/
27+
public class UserConfig {
28+
29+
private String username;
30+
31+
private String password;
32+
33+
public String getUsername() {
34+
return username;
35+
}
36+
37+
public void setUsername(String username) {
38+
this.username = username;
39+
}
40+
41+
public String getPassword() {
42+
return password;
43+
}
44+
45+
public void setPassword(String password) {
46+
this.password = password;
47+
}
48+
49+
@Override
50+
public boolean equals(Object o) {
51+
if (this == o)
52+
return true;
53+
if (o == null || getClass() != o.getClass())
54+
return false;
55+
UserConfig that = (UserConfig) o;
56+
return Objects.equals(username, that.username) && Objects.equals(password, that.password);
57+
}
58+
59+
@Override
60+
public int hashCode() {
61+
return Objects.hash(username, password);
62+
}
63+
}

sormas-api/src/main/java/de/symeda/sormas/api/i18n/Captions.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1092,7 +1092,6 @@ public interface Captions {
10921092
String PathogenTests = "PathogenTests";
10931093
String patientDiaryPersonNotExportable = "patientDiaryPersonNotExportable";
10941094
String patientDiaryRegistrationError = "patientDiaryRegistrationError";
1095-
String patientDiaryRegistrationSuccess = "patientDiaryRegistrationSuccess";
10961095
String Person = "Person";
10971096
String Person_address = "Person.address";
10981097
String Person_addresses = "Person.addresses";

sormas-api/src/main/java/de/symeda/sormas/api/i18n/Validations.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ public interface Validations {
3636
String emptyOverwrittenFollowUpUntilDate = "emptyOverwrittenFollowUpUntilDate";
3737
String errorsInForm = "errorsInForm";
3838
String exportNoNameSpecified = "exportNoNameSpecified";
39-
String externalJournalPersonValidation = "externalJournalPersonValidation";
39+
String externalJournalPersonValidationBirthdate = "externalJournalPersonValidationBirthdate";
40+
String externalJournalPersonValidationEmail = "externalJournalPersonValidationEmail";
41+
String externalJournalPersonValidationError = "externalJournalPersonValidationError";
42+
String externalJournalPersonValidationNoEmailOrPhone = "externalJournalPersonValidationNoEmailOrPhone";
43+
String externalJournalPersonValidationPhone = "externalJournalPersonValidationPhone";
4044
String futureDate = "futureDate";
4145
String futureDateStrict = "futureDateStrict";
4246
String importAreaAlreadyExists = "importAreaAlreadyExists";

sormas-api/src/main/resources/captions.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1950,6 +1950,5 @@ BAGExport=BAG Export
19501950
SurvnetGateway.title=SurvNet
19511951
SurvnetGateway.send=send to own SurvNet instance
19521952

1953-
patientDiaryRegistrationSuccess=Successfully registered person in the patient diary.
19541953
patientDiaryRegistrationError=Could not register person in the patient diary.
19551954
patientDiaryPersonNotExportable=Cannot export the person to the patient diary. The person needs a valid birthdate and either a valid phone number or email address.

sormas-api/src/main/resources/validations.properties

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,8 @@ sormasToSormasSenderNameMissing = Sender name is missing
123123
sormasToSormasSampleExists = This sample already exists
124124
validPhoneNumber = %s must be a valid phone number
125125
validEmailAddress = %s must be a valid email address
126-
externalJournalPersonValidation = Persons exported to an external journal need a valid birthdate and either a valid phone number or email address.
126+
externalJournalPersonValidationBirthdate = Invalid birthdate.
127+
externalJournalPersonValidationEmail = Invalid email address.
128+
externalJournalPersonValidationError = Invalid data provided for person exported to external journal:
129+
externalJournalPersonValidationPhone = Invalid phone number.
130+
externalJournalPersonValidationNoEmailOrPhone = Please provide an email address or a phone number.

0 commit comments

Comments
 (0)