Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit 5cc5b19

Browse files
author
barnabartha
committed
SORMAS-Foundation#2527 - fix width + height issues of diagrams within the dashboard page
1 parent f380786 commit 5cc5b19

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

sormas-ui/src/main/java/de/symeda/sormas/ui/dashboard/AbstractDashboardView.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ protected AbstractDashboardView(String viewName) {
7777
dashboardLayout.setStyleName("crud-main-layout");
7878

7979
addComponent(dashboardLayout);
80+
setExpandRatio(dashboardLayout, 1);
8081
}
8182

8283
protected void navigateToDashboardView(Property.ValueChangeEvent e) {

sormas-ui/src/main/java/de/symeda/sormas/ui/dashboard/campaigns/CampaignDashboardView.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ public CampaignDashboardView() {
5050
dashboardSwitcher.addValueChangeListener(e -> navigateToDashboardView(e));
5151

5252
filterLayout.setInfoLabelText(I18nProperties.getString(Strings.infoCampaignsDashboard));
53-
dashboardLayout.setHeightUndefined();
53+
dashboardLayout.setExpandRatio(filterLayout, 0);
54+
dashboardLayout.setSizeFull();
5455
}
5556

5657
@Override
@@ -72,12 +73,14 @@ public void refreshDashboard() {
7273
tabLayout.setSpacing(false);
7374
campaignDashboardDiagramComponents.add(tabLayout);
7475
dashboardLayout.addComponent(tabLayout);
76+
dashboardLayout.setExpandRatio(tabLayout, 1);
7577

7678
final OptionGroup tabSwitcher = new OptionGroup();
7779
final VerticalLayout tabSwitcherLayout = new VerticalLayout(tabSwitcher);
7880
tabSwitcherLayout.setMargin(new MarginInfo(false, false, false, true));
7981
tabSwitcherLayout.setSpacing(false);
8082
tabLayout.addComponent(tabSwitcherLayout);
83+
tabLayout.setExpandRatio(tabSwitcherLayout, 0);
8184

8285
final Map<String, Map<CampaignDashboardDiagramDto, List<CampaignDiagramDataDto>>> campaignFormDataTabMap =
8386
groupCampaignFormDataByTab(dataProvider.getCampaignFormDataMap());
@@ -118,7 +121,8 @@ public void refreshDashboard() {
118121
diagramsWrapper.setSizeFull();
119122

120123
final CssLayout diagramsLayout = new CssLayout();
121-
diagramsLayout.setWidth(gridTemplateAreaCreator.getWidthsSum() < 100 ? gridTemplateAreaCreator.getWidthsSum() : 100, Unit.PERCENTAGE);
124+
diagramsLayout
125+
.setWidth(gridTemplateAreaCreator.getNrOfGridAreaColumns() == 1 ? gridTemplateAreaCreator.getWidthsSum() : 100, Unit.PERCENTAGE);
122126
diagramsLayout.setHeight(gridTemplateAreaCreator.getGridContainerHeight(), Unit.PERCENTAGE);
123127
final String gridCssClass = tabId.replaceAll("[^a-zA-Z]+", "") + generateRandomString() + GRID_CONTAINER;
124128

@@ -139,6 +143,7 @@ public void refreshDashboard() {
139143

140144
diagramsWrapper.setVisible(false);
141145
tabLayout.addComponent(diagramsWrapper);
146+
tabLayout.setExpandRatio(diagramsWrapper, 1);
142147
});
143148

144149
tabSwitcher.setValue(tabs.isEmpty() ? StringUtils.EMPTY : tabs.get(0));

sormas-ui/src/main/java/de/symeda/sormas/ui/dashboard/campaigns/GridTemplateAreaCreator.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ public Integer getWidthsSum() {
8686
return widthsSum;
8787
}
8888

89+
public Integer getNrOfGridAreaColumns() {
90+
return nrOfGridAreaColumns;
91+
}
92+
8993
private boolean rowIsNull(int x, Integer nrOfGridColumnAreas) {
9094
for (int y = 0; y < nrOfGridColumnAreas; y++) {
9195
if (grid[y][x] != null)

0 commit comments

Comments
 (0)